mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugo Villeneuve <hugo@hugovil.com>
To: Stefano Radaelli <stefano.radaelli21@gmail.com>
Cc: Frank Li <Frank.Li@nxp.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	pierluigi.p@variscite.com,
	Stefano Radaelli <stefano.r@variscite.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Shawn Guo <shawnguo@kernel.org>, Joseph Guo <qijian.guo@nxp.com>,
	Josua Mayer <josua@solid-run.com>,
	Ernest Van Hoecke <ernest.vanhoecke@toradex.com>,
	Mehmet Fide <mehmet.fide@screeningeagle.com>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Markus Niebel <Markus.Niebel@ew.tq-group.com>,
	Hugo Villeneuve <hvilleneuve@dimonoff.com>,
	Stefan Eichenberger <eichest@gmail.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH v4 00/13] ARM: dts: imx6ul: Add Variscite VAR-SOM-6UL and DART-6UL
Date: Fri, 2 Oct 2026 11:17:22 -0400	[thread overview]
Message-ID: <20261002111722.a09e76b8e19fdfe3dc857b4e@hugovil.com> (raw)
In-Reply-To: <ar-cgeR8U0dmOTvI@Lord-Beerus.station>

Hi Stefano,

On Fri, 2 Oct 2026 13:58:57 +0200
Stefano Radaelli <stefano.radaelli21@gmail.com> wrote:

> On Thu, Oct 01, 2026 at 02:43:44PM -0400, Hugo Villeneuve wrote:
> 
> Hi Hugo,
> 
> > 
> > Great to know Variscite is adding support for the DART-6UL.
> > 
> 
> Thank you Hugo :)
> Over the past year, we have been prioritizing security and consistency
> by adopting a mainline-first approach.
> We have added support for almost all of our SOMs and configurations,
> as well as several driver changes and additions:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/?h=master&qt=author&q=Stefano+Radaelli
> And now it's time for the immortal i.MX6UL!
> 
> > 
> > Please work with the existing modular DTSI files, do not simply remove
> > them and reimplement them into your own files.
> > 
> 
> Agreed. Where possible, I’ll reuse the modular files you added and
> propose fix commits wherever changes are needed.
> 
> > 
> > I tested it and it works. But like I said, if adjustments need to be
> > made, they are welcome and can be done in a separate patch to fix it.
> > This sequencing is something not very well documented in Variscite
> > datasheets. I asked Variscite support to improve the documentation for
> > that aspect but it was not accepted.
> > 
> > 
> > > For the LWB5 option, the procedure enables WIFI_PWR, waits 10 ms,
> > > enables WLAN_EN and BT_EN, waits 200 ms, then lowers BT_EN before
> > > re-enumerating the SDIO device.
> > > The other Broadcom option does not use the separate WIFI_PWR step.
> > > The existing regulator and MMC power-sequence nodes do not express that
> > > complete, module-dependent procedure, particularly the BT_EN step during
> > > Wi-Fi initialization.
> > > The scripts also select the Bluetooth firmware according to the detected
> > > SDIO device.
> > 
> > Firmware loading is handled properly by the kernel without external
> > scripts (tested with Concerto EVK).
> > 
> > 
> > > We use that procedure to avoid sequencing-related failures for our
> > > customers.
> > > This approach is not new to Variscite’s mainline DTS files.
> > 
> > Yes, this is an old way of doing things, which may have been
> > appropriate in the past when proper support in the kernel was missing
> > to achieve the proper sequencing, but no longer true these days, unless
> > I am mistaken.
> > 
> 
> We are glad the kernel-managed sequence works on your Concerto EVK.
> However, it is wrong for the LWB5 module configuration we support:
> it does not follow the required power-up order and timing validated
> by Variscite.

Please detail exactly what is wrong so that it can be fixed. Better,
create a patch to fix/improve it.


> The sequence is based on the module requirements and has been tested
> in our labs and across customer configurations over many years.
> A successful test on your EVK does not show that it is correct for all
> the modules and configurations we ship.

Again, like I said before, if things are not optimal they can be
fixed/improved, not completely wiped out.

I can help you with this (test/implementation) if you explain the
problems properly.


> The GPL-2.0-only userspace scripts implement this required sequence.
> This is not a matter of preference or an old approach we kept by habit;
> replacing it with the sequence in the current DTS would risk breaking
> supported Variscite configurations.

Please be more specific.


> If a future kernel implementation can reproduce the complete,
> module-specific sequence, Variscite will be happy to update all affected
> DTS files to use it, after completing the necessary lab testing across
> the supported module variants and configurations.

You need to work with the existing kernel implementation, not delete it.

> If you need any additional material, datasheets, or other information
> from Variscite, please let me know at stefano.r@variscite.com.
> I’ll be happy to provide whatever is needed!

As mentioned before, please add the required timing
sequencing info to your datasheets, it will help everyone.


-- 
Hugo Villeneuve

      reply	other threads:[~2026-10-02 15:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 15:17 Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 01/13] dt-bindings: arm: fsl: Add Variscite i.MX6UL board variants Stefano Radaelli
2026-10-01  7:46   ` Krzysztof Kozlowski
2026-09-29 15:17 ` [PATCH v4 02/13] dt-bindings: arm: fsl: Add Variscite i.MX6ULL " Stefano Radaelli
2026-10-01  8:07   ` Krzysztof Kozlowski
2026-09-29 15:17 ` [PATCH v4 03/13] dt-bindings: arm: fsl: Add Variscite i.MX6ULZ " Stefano Radaelli
2026-10-01  8:09   ` Krzysztof Kozlowski
2026-10-01  9:10     ` Stefano Radaelli
2026-10-01  9:38       ` Krzysztof Kozlowski
2026-09-29 15:17 ` [PATCH v4 04/13] net: phy: micrel: Check RMII clock select property presence Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 05/13] dt-bindings: net: micrel: Fix RMII clock select property type Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 06/13] ARM: dts: imx6ul: Add Variscite SoM and DART base files Stefano Radaelli
2026-09-29 16:15   ` Hugo Villeneuve
2026-09-29 15:17 ` [PATCH v4 07/13] ARM: dts: imx6ul: Add Variscite audio codec files Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 08/13] ARM: dts: imx6ul: Add Variscite storage and wireless files Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 09/13] ARM: dts: imx6ul: Add Variscite carrier board files Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 10/13] ARM: dts: imx6ul: Reuse Variscite DTSI files for Concerto Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 11/13] ARM: dts: imx6ul: Add Variscite i.MX6UL board variants Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 12/13] ARM: dts: imx6ull: Add Variscite i.MX6ULL " Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 13/13] ARM: dts: imx6ulz: Add Variscite i.MX6ULZ " Stefano Radaelli
2026-09-29 16:14 ` [PATCH v4 00/13] ARM: dts: imx6ul: Add Variscite VAR-SOM-6UL and DART-6UL Hugo Villeneuve
2026-09-29 17:41   ` Stefano Radaelli
2026-10-01 18:43     ` Hugo Villeneuve
2026-10-02 11:58       ` Stefano Radaelli
2026-10-02 15:17         ` Hugo Villeneuve [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261002111722.a09e76b8e19fdfe3dc857b4e@hugovil.com \
    --to=hugo@hugovil.com \
    --cc=Frank.Li@nxp.com \
    --cc=Markus.Niebel@ew.tq-group.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=eichest@gmail.com \
    --cc=ernest.vanhoecke@toradex.com \
    --cc=festevam@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=hkallweit1@gmail.com \
    --cc=hvilleneuve@dimonoff.com \
    --cc=imx@lists.linux.dev \
    --cc=josua@solid-run.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mehmet.fide@screeningeagle.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pierluigi.p@variscite.com \
    --cc=qijian.guo@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stefano.r@variscite.com \
    --cc=stefano.radaelli21@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®