From: Arnd Bergmann <arnd@kernel.org>
To: Linus Walleij <linusw@kernel.org>, Long Zhao <longzhao@ambarella.com>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>,
"Benoît Monin" <benoit.monin@bootlin.com>,
"Benjamin Boortz" <bennib@mailbox.org>,
"Frank Li" <Frank.Li@nxp.com>, "Johan Hovold" <johan@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] pinctrl: ambarella: add CONFIG_OF dependency
Date: Fri, 2 Oct 2026 14:46:20 +0200 [thread overview]
Message-ID: <20261002124636.3514597-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
On randconfig builds without CONFIG_OF, this driver fails to link:
x86_64-linux-ld: vmlinux.o: in function `pinconf_generic_dt_node_to_map_all':
pinctrl-ambarella.c:(.text+0x54cdf0): undefined reference to `pinconf_generic_dt_node_to_map'
Enforce OF as a dependency as we do for other such drivers.
Fixes: b40e9d140c24 ("pinctrl: ambarella: add CV75 pin controller")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 6fe53a684dc0..83f68bdd951a 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -41,6 +41,7 @@ config PINCTRL_AMB
bool "Ambarella pin controller support"
depends on ARCH_AMBARELLA || COMPILE_TEST
depends on HAS_IOMEM
+ depends on OF
default y if ARCH_AMBARELLA
select GENERIC_PINCONF
select GENERIC_PINCTRL_GROUPS
--
2.53.0
next reply other threads:[~2026-10-02 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 12:46 Arnd Bergmann [this message]
2026-10-02 21:46 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002124636.3514597-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=bennib@mailbox.org \
--cc=benoit.monin@bootlin.com \
--cc=conor.dooley@microchip.com \
--cc=johan@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longzhao@ambarella.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®