* [PATCH] pinctrl: ambarella: add CONFIG_OF dependency
@ 2026-10-02 12:46 Arnd Bergmann
2026-10-02 21:46 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2026-10-02 12:46 UTC (permalink / raw)
To: Linus Walleij, Long Zhao
Cc: Arnd Bergmann, Conor Dooley, Bartosz Golaszewski,
Benoît Monin, Benjamin Boortz, Frank Li, Johan Hovold,
linux-gpio, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
On randconfig builds without CONFIG_OF, this driver fails to link:
x86_64-linux-ld: vmlinux.o: in function `pinconf_generic_dt_node_to_map_all':
pinctrl-ambarella.c:(.text+0x54cdf0): undefined reference to `pinconf_generic_dt_node_to_map'
Enforce OF as a dependency as we do for other such drivers.
Fixes: b40e9d140c24 ("pinctrl: ambarella: add CV75 pin controller")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 6fe53a684dc0..83f68bdd951a 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -41,6 +41,7 @@ config PINCTRL_AMB
bool "Ambarella pin controller support"
depends on ARCH_AMBARELLA || COMPILE_TEST
depends on HAS_IOMEM
+ depends on OF
default y if ARCH_AMBARELLA
select GENERIC_PINCONF
select GENERIC_PINCTRL_GROUPS
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: ambarella: add CONFIG_OF dependency
2026-10-02 12:46 [PATCH] pinctrl: ambarella: add CONFIG_OF dependency Arnd Bergmann
@ 2026-10-02 21:46 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2026-10-02 21:46 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Long Zhao, Arnd Bergmann, Conor Dooley, Bartosz Golaszewski,
Benoît Monin, Benjamin Boortz, Frank Li, Johan Hovold,
linux-gpio, linux-kernel
On Fri, Oct 2, 2026 at 2:46 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> On randconfig builds without CONFIG_OF, this driver fails to link:
>
> x86_64-linux-ld: vmlinux.o: in function `pinconf_generic_dt_node_to_map_all':
> pinctrl-ambarella.c:(.text+0x54cdf0): undefined reference to `pinconf_generic_dt_node_to_map'
>
> Enforce OF as a dependency as we do for other such drivers.
>
> Fixes: b40e9d140c24 ("pinctrl: ambarella: add CV75 pin controller")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-02 21:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-02 12:46 [PATCH] pinctrl: ambarella: add CONFIG_OF dependency Arnd Bergmann
2026-10-02 21:46 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®