mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: Add mute LED quirk for HP Pavilion 15-eg3xxx (103c:8bfd)
@ 2026-10-02 18:59 Jaidheer Sirigineedi
  2026-10-03  9:49 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Jaidheer Sirigineedi @ 2026-10-02 18:59 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai
  Cc: linux-sound, linux-kernel, Jaidheer Sirigineedi

The mute LED on the HP Pavilion Laptop 15-eg3xxx (PCI SSID 103c:8bfd,
Realtek ALC287) does not work because the machine has no entry in the
quirk table. No fixup is applied, so the mute LED is never driven, even
though the mute function itself works.

The LED is controlled via GPIO pin 4 (mask 0x10), which is exactly what
ALC287_FIXUP_HP_GPIO_LED configures. This was verified on the hardware
with hda-verb: setting the GPIO data bit lights the mute LED, and
clearing it turns the LED off.

  hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_MASK 0x10
  hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DIRECTION 0x10
  hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DATA 0x10   # LED on
  hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DATA 0x00   # LED off

Add a quirk entry for 103c:8bfd using ALC287_FIXUP_HP_GPIO_LED.

Signed-off-by: Jaidheer Sirigineedi <jaidheer7@gmail.com>
---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 5127a111c..f4bea59dd 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7598,6 +7598,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8be8, "HP Envy 17", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8be9, "HP Envy x360 2-in-1 Laptop 15-fh0xxx", ALC245_FIXUP_HP_ENVY_X360_15_FH0XXX),
 	SND_PCI_QUIRK(0x103c, 0x8bf0, "HP", ALC236_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8bfd, "HP Pavilion 15-eg3xxx", ALC287_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8c15, "HP Spectre x360 2-in-1 Laptop 14-eu0xxx", ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX),
 	SND_PCI_QUIRK(0x103c, 0x8c16, "HP Spectre x360 2-in-1 Laptop 16-aa0xxx", ALC245_FIXUP_HP_SPECTRE_X360_16_AA0XXX),
 	SND_PCI_QUIRK(0x103c, 0x8c17, "HP Spectre x360 2-in-1 Laptop 16-aa0xxx", ALC245_FIXUP_HP_SPECTRE_X360_16_AA0XXX),
-- 
2.53.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Add mute LED quirk for HP Pavilion 15-eg3xxx (103c:8bfd)
  2026-10-02 18:59 [PATCH] ALSA: hda/realtek: Add mute LED quirk for HP Pavilion 15-eg3xxx (103c:8bfd) Jaidheer Sirigineedi
@ 2026-10-03  9:49 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-10-03  9:49 UTC (permalink / raw)
  To: Jaidheer Sirigineedi
  Cc: Jaroslav Kysela, Takashi Iwai, linux-sound, linux-kernel

On Fri, 02 Oct 2026 20:59:51 +0200,
Jaidheer Sirigineedi wrote:
> 
> The mute LED on the HP Pavilion Laptop 15-eg3xxx (PCI SSID 103c:8bfd,
> Realtek ALC287) does not work because the machine has no entry in the
> quirk table. No fixup is applied, so the mute LED is never driven, even
> though the mute function itself works.
> 
> The LED is controlled via GPIO pin 4 (mask 0x10), which is exactly what
> ALC287_FIXUP_HP_GPIO_LED configures. This was verified on the hardware
> with hda-verb: setting the GPIO data bit lights the mute LED, and
> clearing it turns the LED off.
> 
>   hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_MASK 0x10
>   hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DIRECTION 0x10
>   hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DATA 0x10   # LED on
>   hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DATA 0x00   # LED off
> 
> Add a quirk entry for 103c:8bfd using ALC287_FIXUP_HP_GPIO_LED.
> 
> Signed-off-by: Jaidheer Sirigineedi <jaidheer7@gmail.com>

Applied now.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-03  9:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-02 18:59 [PATCH] ALSA: hda/realtek: Add mute LED quirk for HP Pavilion 15-eg3xxx (103c:8bfd) Jaidheer Sirigineedi
2026-10-03  9:49 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®