* [PATCH] iio: imu: inv_icm42600: drop stale vdd_supply kernel-doc
@ 2026-10-03 5:53 Arnav Kapoor
2026-10-03 19:22 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Arnav Kapoor @ 2026-10-03 5:53 UTC (permalink / raw)
To: Jean-Baptiste Maneyrol, Jonathan Cameron
Cc: David Lechner, Nuno Sá,
Andy Shevchenko, Sean Nyekjaer, linux-iio, linux-kernel,
Arnav Kapoor
The vdd_supply member was removed from struct inv_icm42600_state when
the driver switched to devm_regulator_get_enable() for the VDD
regulator, but its kernel-doc entry was left behind. This triggers a
W=1 warning:
Warning: drivers/iio/imu/inv_icm42600/inv_icm42600.h:186 Excess struct
member 'vdd_supply' description in 'inv_icm42600_state'
Drop the stale line.
Fixes: 9fd569aa3d70 ("iio: imu: inv_icm42600: Use devm_regulator_get_enable() for vdd regulator")
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
---
Comment-only change, checked with scripts/kernel-doc -Wall.
drivers/iio/imu/inv_icm42600/inv_icm42600.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600.h b/drivers/iio/imu/inv_icm42600/inv_icm42600.h
index e56943931b6a..3737e79dbcc1 100644
--- a/drivers/iio/imu/inv_icm42600/inv_icm42600.h
+++ b/drivers/iio/imu/inv_icm42600/inv_icm42600.h
@@ -151,7 +151,6 @@ struct inv_icm42600_apex {
* @chip: chip identifier.
* @name: chip name.
* @map: regmap pointer.
- * @vdd_supply: VDD voltage regulator for the chip.
* @vddio_supply: I/O voltage regulator for the chip.
* @irq: chip irq, required to enable/disable and set wakeup
* @orientation: sensor chip orientation relative to main hardware.
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iio: imu: inv_icm42600: drop stale vdd_supply kernel-doc
2026-10-03 5:53 [PATCH] iio: imu: inv_icm42600: drop stale vdd_supply kernel-doc Arnav Kapoor
@ 2026-10-03 19:22 ` Andy Shevchenko
2026-10-04 10:43 ` Arnav Kapoor
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2026-10-03 19:22 UTC (permalink / raw)
To: Arnav Kapoor
Cc: Jean-Baptiste Maneyrol, Jonathan Cameron, David Lechner,
Nuno Sá,
Andy Shevchenko, Sean Nyekjaer, linux-iio, linux-kernel
On Sat, Oct 03, 2026 at 11:23:36AM +0530, Arnav Kapoor wrote:
> The vdd_supply member was removed from struct inv_icm42600_state when
> the driver switched to devm_regulator_get_enable() for the VDD
> regulator, but its kernel-doc entry was left behind. This triggers a
> W=1 warning:
>
> Warning: drivers/iio/imu/inv_icm42600/inv_icm42600.h:186 Excess struct
> member 'vdd_supply' description in 'inv_icm42600_state'
>
> Drop the stale line.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> ---
> Comment-only change, checked with scripts/kernel-doc -Wall.
Is this the only issue with kernel-doc in the entire driver?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: imu: inv_icm42600: drop stale vdd_supply kernel-doc
2026-10-03 19:22 ` Andy Shevchenko
@ 2026-10-04 10:43 ` Arnav Kapoor
0 siblings, 0 replies; 3+ messages in thread
From: Arnav Kapoor @ 2026-10-04 10:43 UTC (permalink / raw)
To: andriy.shevchenko
Cc: jean-baptiste.maneyrol, jic23, dlechner, nuno.sa, andy, sean,
linux-iio, linux-kernel
On Sat, Oct 03, 2026, Andy Shevchenko wrote:
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Thanks!
> > ---
> > Comment-only change, checked with scripts/kernel-doc -Wall.
>
> Is this the only issue with kernel-doc in the entire driver?
No, I only checked the header I changed. On the whole driver,
kernel-doc -Wall also warns about three functions that describe their
return value with "Returns ..." instead of a "Return:" section:
inv_icm42600_buffer_update_watermark(), inv_icm42600_setup() and
inv_icm42600_irq_init().
I'll send a v2 series with a second patch fixing those, so the driver
has no kernel-doc warnings left.
Arnav
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-04 10:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-03 5:53 [PATCH] iio: imu: inv_icm42600: drop stale vdd_supply kernel-doc Arnav Kapoor
2026-10-03 19:22 ` Andy Shevchenko
2026-10-04 10:43 ` Arnav Kapoor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®