From: Anton Danilov <littlesmilingcloud@gmail.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: netdev@vger.kernel.org, Jason Wang <jasowangio@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Ido Schimmel <idosch@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] tun: use pskb_may_pull_reason() and remove SKB_DROP_REASON_HDR_TRUNC
Date: Sat, 3 Oct 2026 16:21:52 +0300 [thread overview]
Message-ID: <20261003132155.4174966-1-littlesmilingcloud@gmail.com> (raw)
In-Reply-To: <willemdebruijn.kernel.3b99b3605b4c1@gmail.com>
On Thu, Oct 01, 2026 at 03:00:37PM -0400, Willem de Bruijn wrote:
> Anton Danilov wrote:
> > case IFF_TAP:
> > - if (!pskb_may_pull(skb, ETH_HLEN)) {
> > + drop_reason = pskb_may_pull_reason(skb, ETH_HLEN);
>
> Should we update the skb_may_pull in the above IFF_TUN similarly?
I left it out because that pull never used HDR_TRUNC, so converting it
is a separate change: its drop is reported as NOT_SPECIFIED today, and
with pskb_may_pull_reason() it becomes PKT_TOO_SMALL.
I will convert it in v2.
prev parent reply other threads:[~2026-10-03 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 9:39 Anton Danilov
2026-10-01 17:24 ` Ido Schimmel
2026-10-01 19:00 ` Willem de Bruijn
2026-10-03 13:21 ` Anton Danilov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261003132155.4174966-1-littlesmilingcloud@gmail.com \
--to=littlesmilingcloud@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jasowangio@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®