mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 1/2] MAINTAINERS: cover all hugetlb headers under HUGETLB SUBSYSTEM
@ 2026-10-03  6:00 Enze Li
  2026-10-03  6:00 ` [PATCH v2 2/2] mm/hugetlb_cgroup: add trailing #endif comment for include guard Enze Li
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Enze Li @ 2026-10-03  6:00 UTC (permalink / raw)
  To: muchun.song, osalvador, david, akpm, sj
  Cc: linux-mm, linux-kernel, enze.li, Enze Li, Joe Perches

The HUGETLB SUBSYSTEM F: entries list include/linux/hugetlb.h
explicitly, but other hugetlb headers are not covered, so
get_maintainer.pl does not attribute them to the hugetlb maintainers.

Enumerating headers by hand is also fragile: any header not listed (such
as hugetlb_cgroup.h) falls outside the subsystem.  Joe Perches suggested
using a glob F: entry, which covers all current and future hugetlb
headers in one line and avoids the gap.

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Enze Li <lienze@kylinos.cn>
---
Changes in v2:
- Adopt the glob pattern "F: include/linux/hugetlb*" as suggested by
  Joe Perches.
- Drop the Acked-by: tags from Muchun Song and David Hildenbrand, since
  the patch content changed.

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index fc95062c7e38..5c38da7090db 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12097,7 +12097,7 @@ F:	Documentation/admin-guide/mm/hugetlbpage.rst
 F:	Documentation/mm/hugetlbfs_reserv.rst
 F:	Documentation/mm/vmemmap_dedup.rst
 F:	fs/hugetlbfs/
-F:	include/linux/hugetlb.h
+F:	include/linux/hugetlb*
 F:	include/linux/vmemmap-optimization.h
 F:	include/trace/events/hugetlbfs.h
 F:	mm/hugetlb.c

base-commit: 763ad0211c7b587344f03bc4d1299810aeb736f4
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] mm/hugetlb_cgroup: add trailing #endif comment for include guard
  2026-10-03  6:00 [PATCH v2 1/2] MAINTAINERS: cover all hugetlb headers under HUGETLB SUBSYSTEM Enze Li
@ 2026-10-03  6:00 ` Enze Li
  2026-10-03 14:17 ` [PATCH v2 1/2] MAINTAINERS: cover all hugetlb headers under HUGETLB SUBSYSTEM David Hildenbrand (Arm)
  2026-10-03 17:43 ` SJ Park
  2 siblings, 0 replies; 4+ messages in thread
From: Enze Li @ 2026-10-03  6:00 UTC (permalink / raw)
  To: muchun.song, osalvador, david, akpm, sj
  Cc: linux-mm, linux-kernel, enze.li, Enze Li

The final #endif that closes the _LINUX_HUGETLB_CGROUP_H include guard
is left without a comment.  Add the macro name to the comment for
consistency and easier navigation.

Signed-off-by: Enze Li <lienze@kylinos.cn>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
Acked-by: Muchun Song <muchun.song@linux.dev>
Reviewed-by: SJ Park <sj@kernel.org>
---
Changes in v2:
- No code changes.  Carried tags from David Hildenbrand, Muchun Song and
  SJ Park forward.

 include/linux/hugetlb_cgroup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/hugetlb_cgroup.h b/include/linux/hugetlb_cgroup.h
index 16d72c8c71f6..b4e0958eabf3 100644
--- a/include/linux/hugetlb_cgroup.h
+++ b/include/linux/hugetlb_cgroup.h
@@ -268,4 +268,4 @@ static inline void hugetlb_cgroup_migrate(struct folio *old_folio,
 }
 
 #endif  /* CONFIG_CGROUP_HUGETLB */
-#endif
+#endif /* _LINUX_HUGETLB_CGROUP_H */
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/2] MAINTAINERS: cover all hugetlb headers under HUGETLB SUBSYSTEM
  2026-10-03  6:00 [PATCH v2 1/2] MAINTAINERS: cover all hugetlb headers under HUGETLB SUBSYSTEM Enze Li
  2026-10-03  6:00 ` [PATCH v2 2/2] mm/hugetlb_cgroup: add trailing #endif comment for include guard Enze Li
@ 2026-10-03 14:17 ` David Hildenbrand (Arm)
  2026-10-03 17:43 ` SJ Park
  2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand (Arm) @ 2026-10-03 14:17 UTC (permalink / raw)
  To: Enze Li, muchun.song, osalvador, akpm, sj
  Cc: linux-mm, linux-kernel, enze.li, Joe Perches

On 10/3/26 08:00, Enze Li wrote:
> The HUGETLB SUBSYSTEM F: entries list include/linux/hugetlb.h
> explicitly, but other hugetlb headers are not covered, so
> get_maintainer.pl does not attribute them to the hugetlb maintainers.
> 
> Enumerating headers by hand is also fragile: any header not listed (such
> as hugetlb_cgroup.h) falls outside the subsystem.  Joe Perches suggested
> using a glob F: entry, which covers all current and future hugetlb
> headers in one line and avoids the gap.
> 
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Enze Li <lienze@kylinos.cn>
> ---
> Changes in v2:
> - Adopt the glob pattern "F: include/linux/hugetlb*" as suggested by
>   Joe Perches.
> - Drop the Acked-by: tags from Muchun Song and David Hildenbrand, since
>   the patch content changed.
> 
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fc95062c7e38..5c38da7090db 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12097,7 +12097,7 @@ F:	Documentation/admin-guide/mm/hugetlbpage.rst
>  F:	Documentation/mm/hugetlbfs_reserv.rst
>  F:	Documentation/mm/vmemmap_dedup.rst
>  F:	fs/hugetlbfs/
> -F:	include/linux/hugetlb.h
> +F:	include/linux/hugetlb*
>  F:	include/linux/vmemmap-optimization.h
>  F:	include/trace/events/hugetlbfs.h
>  F:	mm/hugetlb.c
> 
> base-commit: 763ad0211c7b587344f03bc4d1299810aeb736f4

Acked-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/2] MAINTAINERS: cover all hugetlb headers under HUGETLB SUBSYSTEM
  2026-10-03  6:00 [PATCH v2 1/2] MAINTAINERS: cover all hugetlb headers under HUGETLB SUBSYSTEM Enze Li
  2026-10-03  6:00 ` [PATCH v2 2/2] mm/hugetlb_cgroup: add trailing #endif comment for include guard Enze Li
  2026-10-03 14:17 ` [PATCH v2 1/2] MAINTAINERS: cover all hugetlb headers under HUGETLB SUBSYSTEM David Hildenbrand (Arm)
@ 2026-10-03 17:43 ` SJ Park
  2 siblings, 0 replies; 4+ messages in thread
From: SJ Park @ 2026-10-03 17:43 UTC (permalink / raw)
  To: Enze Li
  Cc: SJ Park, muchun.song, osalvador, david, akpm, linux-mm,
	linux-kernel, enze.li, Joe Perches

On Sat,  3 Oct 2026 14:00:28 +0800 Enze Li <lienze@kylinos.cn> wrote:

> The HUGETLB SUBSYSTEM F: entries list include/linux/hugetlb.h
> explicitly, but other hugetlb headers are not covered, so
> get_maintainer.pl does not attribute them to the hugetlb maintainers.
> 
> Enumerating headers by hand is also fragile: any header not listed (such
> as hugetlb_cgroup.h) falls outside the subsystem.  Joe Perches suggested
> using a glob F: entry, which covers all current and future hugetlb
> headers in one line and avoids the gap.

Looks good to me.

> 
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Enze Li <lienze@kylinos.cn>

Reviewed-by: SJ Park <sj@kernel.org>


Thanks,
SJ

[...]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-10-03 17:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-03  6:00 [PATCH v2 1/2] MAINTAINERS: cover all hugetlb headers under HUGETLB SUBSYSTEM Enze Li
2026-10-03  6:00 ` [PATCH v2 2/2] mm/hugetlb_cgroup: add trailing #endif comment for include guard Enze Li
2026-10-03 14:17 ` [PATCH v2 1/2] MAINTAINERS: cover all hugetlb headers under HUGETLB SUBSYSTEM David Hildenbrand (Arm)
2026-10-03 17:43 ` SJ Park

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®