* [PATCH v4 1/2] userfaultfd: clear the inherited uffd bit in move_swap_pte()
2026-10-03 10:30 [PATCH v4 0/2] userfaultfd: clear the inherited uffd bit in move_swap_pte() Donggeun Yoo
@ 2026-10-03 10:30 ` Donggeun Yoo
2026-10-03 10:30 ` [PATCH v4 2/2] selftests/mm: add tests for UFFDIO_MOVE of a uffd-protected swap entry Donggeun Yoo
2026-10-04 20:07 ` [PATCH v4 0/2] userfaultfd: clear the inherited uffd bit in move_swap_pte() Andrew Morton
2 siblings, 0 replies; 6+ messages in thread
From: Donggeun Yoo @ 2026-10-03 10:30 UTC (permalink / raw)
To: akpm, rppt
Cc: peterx, surenb, aarcange, david, ljs, liam, vbabka, mhocko,
shuah, kas, linux-mm, linux-kselftest, linux-kernel,
donggeunyoo.kernel, stable
UFFDIO_MOVE on a swapped-out page installs the source PTE at the
destination unchanged, so a uffd bit set on a write-protected or
RWP-protected source lands in a destination VMA that was never
registered for either. Nothing clears it there, and userspace sees:
- /proc/<pid>/pagemap reports the page as uffd-tracked (bit 57), both
while it is swapped out and after it is faulted back in.
- MADV_COLLAPSE fails with EINVAL on a range containing it, because the
collapse scan bails on a swap entry with the uffd bit set.
- With CONFIG_PAGE_TABLE_CHECK, faulting the page in warns.
do_swap_page() carries the bit into the present PTE and, since the
destination isn't WP-registered, also makes it writable:
WARNING: mm/page_table_check.c:202 at __page_table_check_ptes_set+0x185/0x1e0
Call Trace:
set_ptes+0x67/0xc0
do_swap_page+0x990/0xfe0
__handle_mm_fault+0x7d0/0xeb0
handle_mm_fault+0x9c/0x250
do_user_addr_fault+0x207/0x650
exc_page_fault+0x65/0x150
asm_exc_page_fault+0x26/0x30
Reaching it takes UFFDIO_MOVE out of a WP- or RWP-protected area into
one that isn't, on a page that is swapped out at the time. It hasn't
been seen in practice.
A resident page doesn't carry the bit, because move_present_ptes() builds
the destination PTE from dst_vma->vm_page_prot. Clear it on the moved
swap entry as well, then re-arm it if the destination is RWP-registered.
The WP case has been there since v6.8, where UFFDIO_MOVE was added.
Fixes: adef440691ba ("userfaultfd: UFFDIO_MOVE uABI")
Cc: <stable@vger.kernel.org>
Assisted-by: LLM
Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
---
mm/userfaultfd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c
index 74f04c323c50f..f39f109f17989 100644
--- a/mm/userfaultfd.c
+++ b/mm/userfaultfd.c
@@ -1449,6 +1449,7 @@ static int move_swap_pte(struct mm_struct *mm, struct vm_area_struct *dst_vma,
orig_src_pte = ptep_get_and_clear(mm, src_addr, src_pte);
if (pgtable_supports_soft_dirty())
orig_src_pte = pte_swp_mksoft_dirty(orig_src_pte);
+ orig_src_pte = pte_swp_clear_uffd(orig_src_pte);
/* Re-arm RWP on the moved swap entry if dst_vma is RWP-registered. */
if (userfaultfd_rwp(dst_vma))
orig_src_pte = pte_swp_mkuffd(orig_src_pte);
--
2.53.0
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v4 2/2] selftests/mm: add tests for UFFDIO_MOVE of a uffd-protected swap entry
2026-10-03 10:30 [PATCH v4 0/2] userfaultfd: clear the inherited uffd bit in move_swap_pte() Donggeun Yoo
2026-10-03 10:30 ` [PATCH v4 1/2] " Donggeun Yoo
@ 2026-10-03 10:30 ` Donggeun Yoo
2026-10-05 10:43 ` David Hildenbrand (Arm)
2026-10-04 20:07 ` [PATCH v4 0/2] userfaultfd: clear the inherited uffd bit in move_swap_pte() Andrew Morton
2 siblings, 1 reply; 6+ messages in thread
From: Donggeun Yoo @ 2026-10-03 10:30 UTC (permalink / raw)
To: akpm, rppt
Cc: peterx, surenb, aarcange, david, ljs, liam, vbabka, mhocko,
shuah, kas, linux-mm, linux-kselftest, linux-kernel,
donggeunyoo.kernel
Move a swapped-out page out of a write-protected or RWP-protected area into
a destination registered for missing faults only, and read pagemap bit 57
at the destination. The destination was never protected, so the bit must
be clear.
Assisted-by: LLM
Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
---
tools/testing/selftests/mm/uffd-unit-tests.c | 84 ++++++++++++++++++++
1 file changed, 84 insertions(+)
diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c
index ef9b3956bdcfd..97484c82f24e1 100644
--- a/tools/testing/selftests/mm/uffd-unit-tests.c
+++ b/tools/testing/selftests/mm/uffd-unit-tests.c
@@ -2037,6 +2037,75 @@ static void uffd_move_pmd_split_test(uffd_global_test_opts_t *gopts, uffd_test_a
uffd_move_pmd_handle_fault);
}
+/*
+ * Moving a swapped-out page out of a write-protected or RWP-protected area
+ * must not carry the uffd bit into a destination registered for missing
+ * faults only: such a bit is never cleared afterwards, so pagemap keeps
+ * reporting the page as uffd-tracked.
+ *
+ * Needs a swap device; skipped if MADV_PAGEOUT cannot evict the page.
+ */
+static void uffd_move_swap_test_common(uffd_global_test_opts_t *gopts,
+ bool rwp)
+{
+ unsigned long page_size = gopts->page_size;
+ struct uffdio_move move = {
+ .dst = (unsigned long)gopts->area_dst,
+ .src = (unsigned long)gopts->area_src,
+ .len = page_size,
+ };
+ int pagemap_fd = pagemap_open();
+
+ if (rwp) {
+ if (uffd_register_rwp(gopts->uffd, gopts->area_src, page_size))
+ err("register src failure");
+ rwprotect_range(gopts->uffd, (unsigned long)gopts->area_src,
+ page_size, true);
+ } else {
+ if (uffd_register(gopts->uffd, gopts->area_src, page_size,
+ false, true, false))
+ err("register src failure");
+ wp_range(gopts->uffd, (unsigned long)gopts->area_src,
+ page_size, true);
+ }
+ if (uffd_register(gopts->uffd, gopts->area_dst, page_size,
+ true, false, false))
+ err("register dst failure");
+
+ if (madvise(gopts->area_src, page_size, MADV_PAGEOUT))
+ err("MADV_PAGEOUT");
+ if (!pagemap_is_swapped(pagemap_fd, gopts->area_src)) {
+ uffd_test_skip("MADV_PAGEOUT did not swap the page; is swap enabled?");
+ goto out;
+ }
+
+ if (ioctl(gopts->uffd, UFFDIO_MOVE, &move)) {
+ uffd_test_fail("UFFDIO_MOVE failed: %s", strerror(errno));
+ goto out;
+ }
+
+ if (pagemap_get_entry(pagemap_fd, gopts->area_dst) & PM_UFFD_WP)
+ uffd_test_fail("uffd bit moved into an area registered for missing faults only");
+ else
+ uffd_test_pass();
+out:
+ close(pagemap_fd);
+ uffd_unregister(gopts->uffd, gopts->area_src, page_size);
+ uffd_unregister(gopts->uffd, gopts->area_dst, page_size);
+}
+
+static void uffd_move_swap_wp_test(uffd_global_test_opts_t *gopts,
+ uffd_test_args_t *targs)
+{
+ uffd_move_swap_test_common(gopts, false);
+}
+
+static void uffd_move_swap_rwp_test(uffd_global_test_opts_t *gopts,
+ uffd_test_args_t *targs)
+{
+ uffd_move_swap_test_common(gopts, true);
+}
+
static bool
uffdio_verify_results(const char *name, int ret, int error, long result)
{
@@ -2359,6 +2428,21 @@ uffd_test_case_t uffd_tests[] = {
.uffd_feature_required = UFFD_FEATURE_MOVE,
.test_case_ops = &uffd_move_test_pmd_case_ops,
},
+ {
+ .name = "move-swap-wp",
+ .uffd_fn = uffd_move_swap_wp_test,
+ .mem_targets = MEM_ANON,
+ .uffd_feature_required = UFFD_FEATURE_MOVE |
+ UFFD_FEATURE_PAGEFAULT_FLAG_WP,
+ .test_case_ops = &uffd_move_test_case_ops,
+ },
+ {
+ .name = "move-swap-rwp",
+ .uffd_fn = uffd_move_swap_rwp_test,
+ .mem_targets = MEM_ANON,
+ .uffd_feature_required = UFFD_FEATURE_MOVE | UFFD_FEATURE_RWP,
+ .test_case_ops = &uffd_move_test_case_ops,
+ },
{
.name = "wp-fork",
.uffd_fn = uffd_wp_fork_test,
--
2.53.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v4 2/2] selftests/mm: add tests for UFFDIO_MOVE of a uffd-protected swap entry
2026-10-03 10:30 ` [PATCH v4 2/2] selftests/mm: add tests for UFFDIO_MOVE of a uffd-protected swap entry Donggeun Yoo
@ 2026-10-05 10:43 ` David Hildenbrand (Arm)
2026-10-05 11:50 ` Donggeun Yoo
0 siblings, 1 reply; 6+ messages in thread
From: David Hildenbrand (Arm) @ 2026-10-05 10:43 UTC (permalink / raw)
To: Donggeun Yoo, akpm, rppt
Cc: peterx, surenb, aarcange, ljs, liam, vbabka, mhocko, shuah, kas,
linux-mm, linux-kselftest, linux-kernel
On 10/3/26 12:30, Donggeun Yoo wrote:
> Move a swapped-out page out of a write-protected or RWP-protected area into
> a destination registered for missing faults only, and read pagemap bit 57
> at the destination. The destination was never protected, so the bit must
> be clear.
>
> Assisted-by: LLM
> Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
> ---
> tools/testing/selftests/mm/uffd-unit-tests.c | 84 ++++++++++++++++++++
The CI complains as reply to this patch:
...
Running userfaultfd(2) test
✗ userfaultfd(2) tests failed
Running VMA merge test
# # Totals: pass:27 fail:0 xfail:0 xpass:0 skip:0 error:0
# SUMMARY: PASS=1 SKIP=0 FAIL=0
✓ VMA merge tests passed
Running vmalloc test
# SUMMARY: PASS=1 SKIP=0 FAIL=0
✓ vmalloc tests passed
==========================================
✗ userfaultfd(2) test failed:
# not ok 43 minor-collapse on shmem
------------------------------------------
Didn't look into the details / trying to reproduce.
--
Cheers,
David
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/2] selftests/mm: add tests for UFFDIO_MOVE of a uffd-protected swap entry
2026-10-05 10:43 ` David Hildenbrand (Arm)
@ 2026-10-05 11:50 ` Donggeun Yoo
0 siblings, 0 replies; 6+ messages in thread
From: Donggeun Yoo @ 2026-10-05 11:50 UTC (permalink / raw)
To: linux-mm, linux-kselftest, linux-kernel
Cc: peterx, surenb, aarcange, ljs, liam, vbabka, mhocko, shuah, kas,
donggeunyoo.kernel
On Mon, 5 Oct 2026 12:43:48 +0200, David Hildenbrand (Arm) wrote:
> The CI complains as reply to this patch:
> ...
> ✗ userfaultfd(2) test failed:
> # not ok 43 minor-collapse on shmem
Thanks for passing it on. I couldn't reproduce it here. Could you share
the full log of the failing run, or a link to it?
Donggeun
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 0/2] userfaultfd: clear the inherited uffd bit in move_swap_pte()
2026-10-03 10:30 [PATCH v4 0/2] userfaultfd: clear the inherited uffd bit in move_swap_pte() Donggeun Yoo
2026-10-03 10:30 ` [PATCH v4 1/2] " Donggeun Yoo
2026-10-03 10:30 ` [PATCH v4 2/2] selftests/mm: add tests for UFFDIO_MOVE of a uffd-protected swap entry Donggeun Yoo
@ 2026-10-04 20:07 ` Andrew Morton
2 siblings, 0 replies; 6+ messages in thread
From: Andrew Morton @ 2026-10-04 20:07 UTC (permalink / raw)
To: Donggeun Yoo
Cc: rppt, peterx, surenb, aarcange, david, ljs, liam, vbabka, mhocko,
shuah, kas, linux-mm, linux-kselftest, linux-kernel
On Sat, 3 Oct 2026 19:30:28 +0900 Donggeun Yoo <donggeunyoo.kernel@gmail.com> wrote:
> UFFDIO_MOVE on a swapped-out page installs the source PTE at the
> destination unchanged, so a uffd bit set on a write-protected or
> RWP-protected source lands in a destination VMA that was never
> registered for either, and nothing clears it afterwards. Patch 1 clears
> the bit, then re-arms it if the destination is RWP-registered, which is
> what the present-page and zeropage move paths already do. Patch 2 adds
> the tests that catch it.
Thanks, I updated mm-hotfixes-unstable with this version.
> Changes in v4:
> - patch 1: add Acked-by from David Hildenbrand and Mike Rapoport; no
> code change
> - patch 2: protect the source right after registering it, open pagemap
> at the top, and use a designated initializer for the move (David
> Hildenbrand)
> - patch 2: fail only the test case, not the whole run, when UFFDIO_MOVE
> fails (David Hildenbrand)
Here's how v4 altered mm.git:
tools/testing/selftests/mm/uffd-unit-tests.c | 36 ++++++++---------
1 file changed, 18 insertions(+), 18 deletions(-)
--- a/tools/testing/selftests/mm/uffd-unit-tests.c~b
+++ a/tools/testing/selftests/mm/uffd-unit-tests.c
@@ -2049,28 +2049,29 @@ static void uffd_move_swap_test_common(u
bool rwp)
{
unsigned long page_size = gopts->page_size;
- struct uffdio_move move = { };
- int pagemap_fd;
+ struct uffdio_move move = {
+ .dst = (unsigned long)gopts->area_dst,
+ .src = (unsigned long)gopts->area_src,
+ .len = page_size,
+ };
+ int pagemap_fd = pagemap_open();
if (rwp) {
if (uffd_register_rwp(gopts->uffd, gopts->area_src, page_size))
err("register src failure");
- } else if (uffd_register(gopts->uffd, gopts->area_src, page_size,
- false, true, false)) {
- err("register src failure");
- }
- if (uffd_register(gopts->uffd, gopts->area_dst, page_size,
- true, false, false))
- err("register dst failure");
-
- if (rwp)
rwprotect_range(gopts->uffd, (unsigned long)gopts->area_src,
page_size, true);
- else
+ } else {
+ if (uffd_register(gopts->uffd, gopts->area_src, page_size,
+ false, true, false))
+ err("register src failure");
wp_range(gopts->uffd, (unsigned long)gopts->area_src,
page_size, true);
+ }
+ if (uffd_register(gopts->uffd, gopts->area_dst, page_size,
+ true, false, false))
+ err("register dst failure");
- pagemap_fd = pagemap_open();
if (madvise(gopts->area_src, page_size, MADV_PAGEOUT))
err("MADV_PAGEOUT");
if (!pagemap_is_swapped(pagemap_fd, gopts->area_src)) {
@@ -2078,11 +2079,10 @@ static void uffd_move_swap_test_common(u
goto out;
}
- move.dst = (unsigned long)gopts->area_dst;
- move.src = (unsigned long)gopts->area_src;
- move.len = page_size;
- if (ioctl(gopts->uffd, UFFDIO_MOVE, &move))
- err("UFFDIO_MOVE");
+ if (ioctl(gopts->uffd, UFFDIO_MOVE, &move)) {
+ uffd_test_fail("UFFDIO_MOVE failed: %s", strerror(errno));
+ goto out;
+ }
if (pagemap_get_entry(pagemap_fd, gopts->area_dst) & PM_UFFD_WP)
uffd_test_fail("uffd bit moved into an area registered for missing faults only");
_
^ permalink raw reply [flat|nested] 6+ messages in thread