mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Vishal Badole <Vishal.Badole@amd.com>,
	tony.luck@intel.com, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] EDAC/amd64: Set zn_regs_v2 for all Family 1Ah models
Date: Sun, 4 Oct 2026 13:05:25 -0400	[thread overview]
Message-ID: <20261004170525.GC2673@yaz-khff2.amd.com> (raw)
In-Reply-To: <20261004160412.GAasJ4_AhYcuacY6ZM@fat_crate.local>

On Sun, Oct 04, 2026 at 09:04:12AM -0700, Borislav Petkov wrote:
> On Sun, Oct 04, 2026 at 11:14:47AM -0400, Yazen Ghannam wrote:
> > Because it becomes an empty case once this flag set is moved up.
> 
> No, models 0x40... are supported. The others which are not explicitly listed
> there are not.
> 
> And no, the code doesn't enforce it yet but probably it should. And there
> should be a default: label for the models too which returns -ENODEV, like it
> does for the unknown families.
> 

I see what you mean, but I think that's a bigger issue with the current
design. And I want to move away from that.

The current design is "opt-in" for each new model/group even if there's
no technical difference. So we keep having to write these minor model
check patches just to load the module.

I'd rather we load unconditionally for all models with the same base
behavior using sane defaults. Then we can have model-specific patches
for variations, if needed.

Essentially, we could avoid a whole class of patches for derivative
(client, embedded, etc.) products. The module would load with the sane
defaults. If the test folks find an issue, then we can have a
model-specific patch.

This is how we've been trending with AMD64 EDAC. The family init has
been shrinking over the years.

Thanks,
Yazen

  reply	other threads:[~2026-10-04 17:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 11:32 [PATCH v3 0/2] EDAC/amd64: Fix UMC csrow decode and consolidate Family 1Ah setup Vishal Badole
2026-10-02 11:32 ` [PATCH v3 1/2] EDAC/amd64: Mask UMC chip select to the four implemented selects Vishal Badole
2026-10-02 11:32 ` [PATCH v3 2/2] EDAC/amd64: Set zn_regs_v2 for all Family 1Ah models Vishal Badole
2026-10-03  1:22   ` Borislav Petkov
2026-10-04 15:14     ` Yazen Ghannam
2026-10-04 16:04       ` Borislav Petkov
2026-10-04 17:05         ` Yazen Ghannam [this message]
2026-10-04 17:50           ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261004170525.GC2673@yaz-khff2.amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=Vishal.Badole@amd.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®