* [PATCH] block: fix kernel-doc of bio_copy_kern()
@ 2026-10-05 6:48 Manuel Ebner
2026-10-05 8:42 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Manuel Ebner @ 2026-10-05 6:48 UTC (permalink / raw)
To: Jens Axboe
Cc: Manuel Ebner, Fengnan Chang, Christoph Hellwig, linux-block,
linux-kernel
Remove obsolete argument in kernel-doc fixing:
$ ./scripts/kernel-doc -none block/blk-map.c
Warning: block/blk-map.c:366 Excess function parameter 'op' description in 'bio_copy_kern'
Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
CC: Fengnan Chang <changfengnan@bytedance.com>
CC: Christoph Hellwig <hch@lst.de>
---
Let me know if 'op' should be explained as a variable instead.
---
block/blk-map.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/blk-map.c b/block/blk-map.c
index 81cba3af4..e0c2b8236 100644
--- a/block/blk-map.c
+++ b/block/blk-map.c
@@ -356,7 +356,6 @@ static void bio_copy_kern_endio_read(struct bio *bio)
* @rq: request to fill
* @data: pointer to buffer to copy
* @len: length in bytes
- * @op: bio/request operation
* @gfp_mask: allocation flags for bio and page allocation
*
* copy the kernel address into a bio suitable for io to a block
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] block: fix kernel-doc of bio_copy_kern()
2026-10-05 6:48 [PATCH] block: fix kernel-doc of bio_copy_kern() Manuel Ebner
@ 2026-10-05 8:42 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2026-10-05 8:42 UTC (permalink / raw)
To: Manuel Ebner
Cc: Jens Axboe, Fengnan Chang, Christoph Hellwig, linux-block, linux-kernel
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-05 8:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-05 6:48 [PATCH] block: fix kernel-doc of bio_copy_kern() Manuel Ebner
2026-10-05 8:42 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®