* [PATCH v2] wifi: iwlwifi: mld: include VI packets in low latency detection
@ 2026-10-05 14:42 Endrik Einberg
0 siblings, 0 replies; only message in thread
From: Endrik Einberg @ 2026-10-05 14:42 UTC (permalink / raw)
To: miriam.rachel.korenblit
Cc: linux-wireless, netdev, linux-kernel, Endrik Einberg
iwl_mld_is_vo_vi_pkt() checks whether the mapped access category
is less than IEEE80211_AC_VI.
Since mac80211 defines IEEE80211_AC_VO as 0 and IEEE80211_AC_VI as 1,
this only matches voice traffic and excludes video traffic.
This was discovered during Wi-Fi troubleshooting with LLM assistance,
then confirmed through runtime testing and manual code inspection.
Synthetic video-priority UDP traffic did not automatically
activate low-latency mode, whereas voice-priority traffic did
(observed through the iwlmld debugfs state).
Include IEEE80211_AC_VI as intended,
matching behaviour of iwlmvm's iwl_mvm_calc_tcm_stats().
Explicitly specify the two values to match,
avoiding such issues from enum value comparison in the future.
Fixes: d1e879ec600f ("wifi: iwlwifi: add iwlmld sub-driver")
Signed-off-by: Endrik Einberg <git@endrik.dev>
---
Changes in v2:
- Match IEEE80211_AC_VO and _VI explicitly, as suggested by Miri.
- Describe how the issue was discovered and confirmed.
drivers/net/wireless/intel/iwlwifi/mld/low_latency.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mld/low_latency.c b/drivers/net/wireless/intel/iwlwifi/mld/low_latency.c
index a4ddc32e2860..e7482623111c 100644
--- a/drivers/net/wireless/intel/iwlwifi/mld/low_latency.c
+++ b/drivers/net/wireless/intel/iwlwifi/mld/low_latency.c
@@ -257,7 +257,8 @@ static bool iwl_mld_is_vo_vi_pkt(struct ieee80211_hdr *hdr)
if (tid >= IWL_MAX_TID_COUNT)
return false;
- return tid_to_mac80211_ac[tid] < IEEE80211_AC_VI;
+ return tid_to_mac80211_ac[tid] == IEEE80211_AC_VI ||
+ tid_to_mac80211_ac[tid] == IEEE80211_AC_VO;
}
void iwl_mld_low_latency_update_counters(struct iwl_mld *mld,
--
2.53.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-05 14:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-05 14:42 [PATCH v2] wifi: iwlwifi: mld: include VI packets in low latency detection Endrik Einberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®