From: Thorsten Blum <blum@kernel.org>
To: Danilo Krummrich <dakr@kernel.org>,
Alice Ryhl <aliceryhl@google.com>,
Alexandre Courbot <acourbot@nvidia.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Gary Guo <gary@garyguo.net>, Timur Tabi <ttabi@nvidia.com>,
Robin Murphy <robin.murphy@arm.com>,
Tim Kovalenko <tim.kovalenko@proton.me>
Cc: Thorsten Blum <blum@kernel.org>,
nova-gpu@lists.linux.dev, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] gpu: nova-core: firmware: fwsec: use zeroed() to zero-pad buffers
Date: Tue, 6 Oct 2026 12:04:36 +0200 [thread overview]
Message-ID: <20261006100442.80432-3-blum@kernel.org> (raw)
Use KVec::zeroed() to allocate the zero-padded microcode buffer and copy
the bootloader code into it. Also use KVVec::zeroed() to initialize the
firmware object's leading zero padding.
Signed-off-by: Thorsten Blum <blum@kernel.org>
---
drivers/gpu/nova-core/firmware/fwsec/bootloader.rs | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/nova-core/firmware/fwsec/bootloader.rs b/drivers/gpu/nova-core/firmware/fwsec/bootloader.rs
index ec4d92317a93..37dcd4bf4711 100644
--- a/drivers/gpu/nova-core/firmware/fwsec/bootloader.rs
+++ b/drivers/gpu/nova-core/firmware/fwsec/bootloader.rs
@@ -137,10 +137,8 @@ pub(crate) fn new(
.align_up(Alignment::new::<{ falcon::MEM_BLOCK_ALIGNMENT }>())
.ok_or(EINVAL)?;
- let mut ucode = KVec::with_capacity(aligned_code_size, GFP_KERNEL)?;
- ucode.extend_from_slice(code, GFP_KERNEL)?;
- ucode.resize(aligned_code_size, 0, GFP_KERNEL)?;
-
+ let mut ucode = KVec::zeroed(aligned_code_size, GFP_KERNEL)?;
+ ucode[..code.len()].copy_from_slice(code);
ucode
};
@@ -162,8 +160,7 @@ pub(crate) fn new(
.ok_or(EOVERFLOW)?
};
- let mut firmware_obj = KVVec::new();
- firmware_obj.extend_with(align_padding, 0u8, GFP_KERNEL)?;
+ let mut firmware_obj = KVVec::zeroed(align_padding, GFP_KERNEL)?;
firmware_obj.extend_from_slice(firmware.ucode.0.as_slice(), GFP_KERNEL)?;
(
reply other threads:[~2026-10-06 10:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006100442.80432-3-blum@kernel.org \
--to=blum@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=robin.murphy@arm.com \
--cc=simona@ffwll.ch \
--cc=tim.kovalenko@proton.me \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®