* [PATCH] gpu: nova-core: firmware: fwsec: use zeroed() to zero-pad buffers
@ 2026-10-06 10:04 Thorsten Blum
0 siblings, 0 replies; only message in thread
From: Thorsten Blum @ 2026-10-06 10:04 UTC (permalink / raw)
To: Danilo Krummrich, Alice Ryhl, Alexandre Courbot, David Airlie,
Simona Vetter, Gary Guo, Timur Tabi, Robin Murphy, Tim Kovalenko
Cc: Thorsten Blum, nova-gpu, dri-devel, linux-kernel
Use KVec::zeroed() to allocate the zero-padded microcode buffer and copy
the bootloader code into it. Also use KVVec::zeroed() to initialize the
firmware object's leading zero padding.
Signed-off-by: Thorsten Blum <blum@kernel.org>
---
drivers/gpu/nova-core/firmware/fwsec/bootloader.rs | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/nova-core/firmware/fwsec/bootloader.rs b/drivers/gpu/nova-core/firmware/fwsec/bootloader.rs
index ec4d92317a93..37dcd4bf4711 100644
--- a/drivers/gpu/nova-core/firmware/fwsec/bootloader.rs
+++ b/drivers/gpu/nova-core/firmware/fwsec/bootloader.rs
@@ -137,10 +137,8 @@ pub(crate) fn new(
.align_up(Alignment::new::<{ falcon::MEM_BLOCK_ALIGNMENT }>())
.ok_or(EINVAL)?;
- let mut ucode = KVec::with_capacity(aligned_code_size, GFP_KERNEL)?;
- ucode.extend_from_slice(code, GFP_KERNEL)?;
- ucode.resize(aligned_code_size, 0, GFP_KERNEL)?;
-
+ let mut ucode = KVec::zeroed(aligned_code_size, GFP_KERNEL)?;
+ ucode[..code.len()].copy_from_slice(code);
ucode
};
@@ -162,8 +160,7 @@ pub(crate) fn new(
.ok_or(EOVERFLOW)?
};
- let mut firmware_obj = KVVec::new();
- firmware_obj.extend_with(align_padding, 0u8, GFP_KERNEL)?;
+ let mut firmware_obj = KVVec::zeroed(align_padding, GFP_KERNEL)?;
firmware_obj.extend_from_slice(firmware.ucode.0.as_slice(), GFP_KERNEL)?;
(
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-06 10:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-06 10:04 [PATCH] gpu: nova-core: firmware: fwsec: use zeroed() to zero-pad buffers Thorsten Blum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®