mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: wendler.david@gmail.com
To: james.a.fairweather@gmail.com
Cc: chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_usbpd_notify: Only use parent drvdata when parent is GOOG0004
Date: Thu,  8 Oct 2026 03:43:51 -0500	[thread overview]
Message-ID: <20261008084351.7680-1-wendler.david@gmail.com> (raw)
In-Reply-To: <20261003222855.23707-1-james.a.fairweather@gmail.com>

Hi James,

I wanted to report successful testing of this fix on another affected
Chromebook.

Hardware:
- ASUS Chromebook C223NA (BABYMEGA, CORAL)
- Intel Apollo Lake
- Omarchy / Arch Linux, kernel 7.2.5-3-omarchy

Before the fix, disconnecting and reconnecting the USB-C charger could
cause a kernel oops and leave the system unresponsive. On this machine,
GOOG0003:00 has PNP0C09:00 as its parent rather than GOOG0004.

I built and loaded a locally adapted version of cros_usbpd_notify
incorporating the parent-device validation and NULL fallback described
in your patch.

After applying the fix:
- Six consecutive USB-C charger disconnect/reconnect cycles succeeded.
- No kernel oops or system hangs were observed.
- SSH remained responsive throughout testing.
- USB-PD negotiation reached 15V/3A (45W).
- The battery correctly reported Charging after reconnection.

The driver also produced the expected diagnostic message:

  Couldn't get Chrome EC device pointer.

This was a locally adapted implementation rather than a byte-for-byte
build of the submitted patch, but the results support the fix on the
BABYMEGA platform as well.

Thanks for tracking this down!

David

      parent reply	other threads:[~2026-10-08  8:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-03 22:28 James Fairweather
2026-10-05  3:41 ` Tzung-Bi Shih
2026-10-06  7:14 ` Sergey Tiraspolsky
2026-10-06 10:28 ` Tzung-Bi Shih
2026-10-08  8:43 ` wendler.david [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261008084351.7680-1-wendler.david@gmail.com \
    --to=wendler.david@gmail.com \
    --cc=chrome-platform@lists.linux.dev \
    --cc=james.a.fairweather@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®