* [PATCH v3 0/2] platform/x86: uniwill-laptop: Support the PCSpecialist Recoil 16 AMD
@ 2026-10-08 13:56 Mohamed Jouini
2026-10-08 13:56 ` [PATCH v3 1/2] platform/x86: uniwill-laptop: Add " Mohamed Jouini
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Mohamed Jouini @ 2026-10-08 13:56 UTC (permalink / raw)
To: Armin Wolf, Hans de Goede, Ilpo Järvinen
Cc: Werner Sembach, Christoffer Sandberg, platform-driver-x86,
linux-kernel, Mohamed Jouini
The PCSpecialist Recoil 16 AMD is a rebadged TUXEDO Stellaris 16 Gen7 AMD
(board X6FR57TY), which the driver does not match today because of the
different DMI vendor and board name.
Patch 1 adds it with the existing Stellaris 16 Gen7 AMD feature set.
Patch 2 maps the "Sc" key (WMI event 0xD0) to KEY_ROTATE_DISPLAY.
Tested on the Recoil 16 AMD (BIOS N.1.39PCS10) with the v2 driver built
against 7.2.7: the Sc key, the hwmon fan and temperature readings, and
all three charging profiles. v3 only follows the descriptor rename, so
the device gets the same feature set as in v2. Charging from below 70%,
with the charge counted from current_now:
Profile CV (4S) per cell stops at, of a Standard charge
Standard 17.405 V 4.35 V 100%
Long_Life 17.194 V 4.30 V about 93%
Trickle 16.818 V 4.20 V about 90%
In every profile the EC then reports 100% / Full, as Armin said it
would.
Changes in v3:
- Rebased on for-next: the Stellaris 16 Gen7 AMD feature set is now
gmxixxx_xxxx45xx_xxxx55xx_xxxx57xx_descriptor (Ilpo).
- Patch 2 unchanged. On v1, TUXEDO confirmed they know of no device
using event 0xD0, which settles the question attached to Armin's
Reviewed-by:
https://lore.kernel.org/r/66a47248ecfa1704186274f2c245d3f5@tuxedo.de
Changes in v2:
- Patch 1 uses the existing Stellaris 16 Gen7 AMD feature set (charging
profiles) instead of the percentage charge limit (Armin).
- Dropped the platform profile patch for now (Armin).
- Added Armin's Reviewed-by to the Sc key patch.
v2: https://lore.kernel.org/r/20260927014031.3465252-1-amad3v@gmail.com
v1: https://lore.kernel.org/r/20260925211635.1422516-1-amad3v@gmail.com
Mohamed Jouini (2):
platform/x86: uniwill-laptop: Add PCSpecialist Recoil 16 AMD
platform/x86: uniwill-laptop: Map the screen rotation key
drivers/platform/x86/uniwill/uniwill-acpi.c | 11 +++++++++++
drivers/platform/x86/uniwill/uniwill-wmi.h | 3 +++
2 files changed, 14 insertions(+)
base-commit: 98f039265e580291d5e76a11b2072541fbb1c393
--
2.56.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 1/2] platform/x86: uniwill-laptop: Add PCSpecialist Recoil 16 AMD
2026-10-08 13:56 [PATCH v3 0/2] platform/x86: uniwill-laptop: Support the PCSpecialist Recoil 16 AMD Mohamed Jouini
@ 2026-10-08 13:56 ` Mohamed Jouini
2026-10-08 13:56 ` [PATCH v3 2/2] platform/x86: uniwill-laptop: Map the screen rotation key Mohamed Jouini
2026-10-08 17:38 ` [PATCH v3 0/2] platform/x86: uniwill-laptop: Support the PCSpecialist Recoil 16 AMD Ilpo Järvinen
2 siblings, 0 replies; 4+ messages in thread
From: Mohamed Jouini @ 2026-10-08 13:56 UTC (permalink / raw)
To: Armin Wolf, Hans de Goede, Ilpo Järvinen
Cc: Werner Sembach, Christoffer Sandberg, platform-driver-x86,
linux-kernel, Mohamed Jouini
The PCSpecialist Recoil 16 AMD is a rebadged TUXEDO Stellaris 16 Gen7 AMD
but reports sys_vendor "PCSpecialist" and board name "X6FR57TY", so the
existing entry does not match it. Use the Stellaris 16 Gen7 AMD feature
set.
Signed-off-by: Mohamed Jouini <amad3v@gmail.com>
---
Changes in v3:
- Rebased on for-next; the feature set is now named
gmxixxx_xxxx45xx_xxxx55xx_xxxx57xx_descriptor (Ilpo).
Changes in v2:
- Use the existing Stellaris 16 Gen7 AMD feature set (charging profiles)
instead of a separate descriptor with the percentage charge limit.
drivers/platform/x86/uniwill/uniwill-acpi.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/platform/x86/uniwill/uniwill-acpi.c b/drivers/platform/x86/uniwill/uniwill-acpi.c
index 07b69629b..dc9b73afd 100644
--- a/drivers/platform/x86/uniwill/uniwill-acpi.c
+++ b/drivers/platform/x86/uniwill/uniwill-acpi.c
@@ -3451,6 +3451,14 @@ static const struct dmi_system_id uniwill_dmi_table[] __initconst = {
},
.driver_data = &gmxixxx_xxxx45xx_xxxx55xx_xxxx57xx_descriptor,
},
+ {
+ .ident = "PCSpecialist Recoil 16 AMD",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "PCSpecialist"),
+ DMI_EXACT_MATCH(DMI_BOARD_NAME, "X6FR57TY"),
+ },
+ .driver_data = &gmxixxx_xxxx45xx_xxxx55xx_xxxx57xx_descriptor,
+ },
{
.ident = "TUXEDO Stellaris 16 Gen7 Intel",
.matches = {
--
2.56.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 2/2] platform/x86: uniwill-laptop: Map the screen rotation key
2026-10-08 13:56 [PATCH v3 0/2] platform/x86: uniwill-laptop: Support the PCSpecialist Recoil 16 AMD Mohamed Jouini
2026-10-08 13:56 ` [PATCH v3 1/2] platform/x86: uniwill-laptop: Add " Mohamed Jouini
@ 2026-10-08 13:56 ` Mohamed Jouini
2026-10-08 17:38 ` [PATCH v3 0/2] platform/x86: uniwill-laptop: Support the PCSpecialist Recoil 16 AMD Ilpo Järvinen
2 siblings, 0 replies; 4+ messages in thread
From: Mohamed Jouini @ 2026-10-08 13:56 UTC (permalink / raw)
To: Armin Wolf, Hans de Goede, Ilpo Järvinen
Cc: Werner Sembach, Christoffer Sandberg, platform-driver-x86,
linux-kernel, Mohamed Jouini
The PCSpecialist Recoil 16 AMD / TUXEDO Stellaris 16 Gen7 chassis has an
"Sc" key next to F12, meant to rotate the lay-flat screen by 180 degrees.
It reports WMI event 0xD0, which is currently reported as KEY_UNKNOWN.
Map it to KEY_ROTATE_DISPLAY.
Signed-off-by: Mohamed Jouini <amad3v@gmail.com>
Reviewed-by: Armin Wolf <W_Armin@gmx.de>
---
Changes in v3:
- None. TUXEDO know of no device using event 0xD0:
https://lore.kernel.org/r/66a47248ecfa1704186274f2c245d3f5@tuxedo.de
Changes in v2:
- Added Reviewed-by.
drivers/platform/x86/uniwill/uniwill-acpi.c | 3 +++
drivers/platform/x86/uniwill/uniwill-wmi.h | 3 +++
2 files changed, 6 insertions(+)
diff --git a/drivers/platform/x86/uniwill/uniwill-acpi.c b/drivers/platform/x86/uniwill/uniwill-acpi.c
index dc9b73afd..6b0dd0e4f 100644
--- a/drivers/platform/x86/uniwill/uniwill-acpi.c
+++ b/drivers/platform/x86/uniwill/uniwill-acpi.c
@@ -506,6 +506,9 @@ static const struct key_entry uniwill_keymap[] = {
/* Reported when the user wants to toggle the webcam */
{ KE_IGNORE, UNIWILL_OSD_WEBCAM_TOGGLE, { KEY_UNKNOWN }},
+ /* Reported when the user wants to rotate the (lay-flat) screen by 180 degrees */
+ { KE_KEY, UNIWILL_OSD_ROTATE_SCREEN, { KEY_ROTATE_DISPLAY }},
+
{ KE_END }
};
diff --git a/drivers/platform/x86/uniwill/uniwill-wmi.h b/drivers/platform/x86/uniwill/uniwill-wmi.h
index b25b2f312..1b6f650c4 100644
--- a/drivers/platform/x86/uniwill/uniwill-wmi.h
+++ b/drivers/platform/x86/uniwill/uniwill-wmi.h
@@ -117,6 +117,9 @@
#define UNIWILL_OSD_WEBCAM_TOGGLE 0xCF
+/* "Sc" key next to F12 on the PCSpecialist Recoil 16 / Stellaris 16 Gen7 */
+#define UNIWILL_OSD_ROTATE_SCREEN 0xD0
+
#define UNIWILL_OSD_KBD_BACKLIGHT_CHANGED 0xF0
struct device;
--
2.56.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 0/2] platform/x86: uniwill-laptop: Support the PCSpecialist Recoil 16 AMD
2026-10-08 13:56 [PATCH v3 0/2] platform/x86: uniwill-laptop: Support the PCSpecialist Recoil 16 AMD Mohamed Jouini
2026-10-08 13:56 ` [PATCH v3 1/2] platform/x86: uniwill-laptop: Add " Mohamed Jouini
2026-10-08 13:56 ` [PATCH v3 2/2] platform/x86: uniwill-laptop: Map the screen rotation key Mohamed Jouini
@ 2026-10-08 17:38 ` Ilpo Järvinen
2 siblings, 0 replies; 4+ messages in thread
From: Ilpo Järvinen @ 2026-10-08 17:38 UTC (permalink / raw)
To: Armin Wolf, Hans de Goede, Mohamed Jouini
Cc: Werner Sembach, Christoffer Sandberg, platform-driver-x86, linux-kernel
On Thu, 08 Oct 2026 14:56:22 +0100, Mohamed Jouini wrote:
> The PCSpecialist Recoil 16 AMD is a rebadged TUXEDO Stellaris 16 Gen7 AMD
> (board X6FR57TY), which the driver does not match today because of the
> different DMI vendor and board name.
>
> Patch 1 adds it with the existing Stellaris 16 Gen7 AMD feature set.
> Patch 2 maps the "Sc" key (WMI event 0xD0) to KEY_ROTATE_DISPLAY.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.
The list of commits applied:
[1/2] platform/x86: uniwill-laptop: Add PCSpecialist Recoil 16 AMD
commit: 99ee4a2405fafe9636cb1c834cc3753ef5705041
[2/2] platform/x86: uniwill-laptop: Map the screen rotation key
commit: 37dcbefbcf314ab032ee6bb7f7363c1de5e886a7
--
i.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-10-08 17:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-08 13:56 [PATCH v3 0/2] platform/x86: uniwill-laptop: Support the PCSpecialist Recoil 16 AMD Mohamed Jouini
2026-10-08 13:56 ` [PATCH v3 1/2] platform/x86: uniwill-laptop: Add " Mohamed Jouini
2026-10-08 13:56 ` [PATCH v3 2/2] platform/x86: uniwill-laptop: Map the screen rotation key Mohamed Jouini
2026-10-08 17:38 ` [PATCH v3 0/2] platform/x86: uniwill-laptop: Support the PCSpecialist Recoil 16 AMD Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®