* [PATCH] mm/damon: fix typo and grammar
@ 2026-10-08 16:20 Manuel Ebner
2026-10-09 2:54 ` Enze Li
2026-10-09 8:18 ` SJ Park
0 siblings, 2 replies; 3+ messages in thread
From: Manuel Ebner @ 2026-10-08 16:20 UTC (permalink / raw)
To: SJ Park, Andrew Morton
Cc: Manuel Ebner, Adrian Huang (Lenovo), damon, linux-mm, linux-kernel
DAMON_RCLAIM -> DAMON_RECLAIM
set as -> set to
Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
CC: Adrian Huang (Lenovo) <adrianhuang0701@gmail.com>
---
I hope I got the right git-tree. somehow there's 'damon/next'
and 'damon/next/damon/next'
The other patches will take a couple more days.
mm/damon/reclaim.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c
index 014b0779ea..a84cea070e 100644
--- a/mm/damon/reclaim.c
+++ b/mm/damon/reclaim.c
@@ -19,8 +19,8 @@
/*
* Enable or disable DAMON_RECLAIM.
*
- * You can enable DAMON_RCLAIM by setting the value of this parameter as ``Y``.
- * Setting it as ``N`` disables DAMON_RECLAIM. Note that DAMON_RECLAIM could
+ * You can enable DAMON_RECLAIM by setting the value of this parameter to ``Y``.
+ * Setting it to ``N`` disables DAMON_RECLAIM. Note that DAMON_RECLAIM could
* do no real monitoring and reclamation due to the watermarks-based activation
* condition. Refer to below descriptions for the watermarks parameter for
* this.
@@ -31,9 +31,9 @@ static bool enabled __read_mostly;
* Make DAMON_RECLAIM reads the input parameters again, except ``enabled``.
*
* Input parameters that updated while DAMON_RECLAIM is running are not applied
- * by default. Once this parameter is set as ``Y``, DAMON_RECLAIM reads values
+ * by default. Once this parameter is set to ``Y``, DAMON_RECLAIM reads values
* of parameters except ``enabled`` again. Once the re-reading is done, this
- * parameter is set as ``N``. If invalid parameters are found while the
+ * parameter is set to ``N``. If invalid parameters are found while the
* re-reading, DAMON_RECLAIM will be disabled.
*/
static bool commit_inputs __read_mostly;
@@ -92,11 +92,11 @@ module_param(quota_autotune_feedback, ulong, 0600);
/*
* Auto-tune monitoring intervals.
*
- * If this parameter is set as ``Y``, DAMON_RECLAIM automatically tunes DAMON's
+ * If this parameter is set to ``Y``, DAMON_RECLAIM automatically tunes DAMON's
* sampling and aggregation intervals. The auto-tuning aims to capture
* meaningful amount of access events in each DAMON-snapshot, while keeping the
* sampling intervals 5 milliseconds in minimum, and 10 seconds in maximum.
- * Setting this as ``N`` disables the auto-tuning.
+ * Setting this to ``N`` disables the auto-tuning.
*
* Disabled by default.
*/
@@ -151,7 +151,7 @@ static unsigned long addr_unit __read_mostly = 1;
/*
* Skip anonymous pages reclamation.
*
- * If this parameter is set as ``Y``, DAMON_RECLAIM does not reclaim anonymous
+ * If this parameter is set to ``Y``, DAMON_RECLAIM does not reclaim anonymous
* pages. By default, ``N``.
*/
static bool skip_anon __read_mostly;
--
2.55.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/damon: fix typo and grammar
2026-10-08 16:20 [PATCH] mm/damon: fix typo and grammar Manuel Ebner
@ 2026-10-09 2:54 ` Enze Li
2026-10-09 8:18 ` SJ Park
1 sibling, 0 replies; 3+ messages in thread
From: Enze Li @ 2026-10-09 2:54 UTC (permalink / raw)
To: Manuel Ebner, SJ Park, Andrew Morton
Cc: Adrian Huang (Lenovo), damon, linux-mm, linux-kernel
Hi Manuel,
On 10/9/26 12:20 AM, Manuel Ebner wrote:
> DAMON_RCLAIM -> DAMON_RECLAIM
> set as -> set to
>
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> CC: Adrian Huang (Lenovo) <adrianhuang0701@gmail.com>
> ---
> I hope I got the right git-tree. somehow there's 'damon/next'
> and 'damon/next/damon/next'
> The other patches will take a couple more days.
Thanks for fixing these, Manuel!
Your patch applies cleanly on top of the mm-new branch, so the git-tree
is fine for this one. For future DAMON patches, please base them on
Andrew Morton's mm-new branch:
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git (mm-new)
For more details, see here [1].
[1]
https://www.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#damon-maintainer-entry-profile
Reviewed-by: Enze Li <lienze@kylinos.cn>
Thanks,
Enze
<..>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/damon: fix typo and grammar
2026-10-08 16:20 [PATCH] mm/damon: fix typo and grammar Manuel Ebner
2026-10-09 2:54 ` Enze Li
@ 2026-10-09 8:18 ` SJ Park
1 sibling, 0 replies; 3+ messages in thread
From: SJ Park @ 2026-10-09 8:18 UTC (permalink / raw)
To: Manuel Ebner
Cc: SJ Park, Andrew Morton, Adrian Huang (Lenovo),
damon, linux-mm, linux-kernel
Hello Manuel,
Let's use "mm/damon/reclaim:" as the subject prefix.
On Thu, 8 Oct 2026 18:20:10 +0200 Manuel Ebner <manuelebnerli@mailbox.org> wrote:
> DAMON_RCLAIM -> DAMON_RECLAIM
> set as -> set to
>
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> CC: Adrian Huang (Lenovo) <adrianhuang0701@gmail.com>
Other than the subject prefix,
Reviewed-by: SJ Park <sj@kernel.org>
> ---
> I hope I got the right git-tree. somehow there's 'damon/next'
> and 'damon/next/damon/next'
> The other patches will take a couple more days.
mm-new is the recommended baseline for now. It might change in future. Please
refer to this document [1] for more details.
I applied this patch to damon/next [1] tree after changing the subject prefix
to what I suggested. We are now quite close to next merge window. It may
better to focus on making mm.git more stabilized and therefore ready for the
next merge window, rather than adding more changes that are not really urgent.
I understand this series is not really urgent. Hence, Andrew might not add
this patch until next -rc1 release. In the case, I will request adding this to
mm.git after next -rc1 release. So, no action from your side is needed for
now. Let me know if you think this is really urgent.
[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-09 8:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-08 16:20 [PATCH] mm/damon: fix typo and grammar Manuel Ebner
2026-10-09 2:54 ` Enze Li
2026-10-09 8:18 ` SJ Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®