mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Nicolas Schier <nsc@kernel.org>,
	Julian Braha <julianbraha@gmail.com>,
	Lorenzo Stoakes <ljs@kernel.org>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] kconfig: Improve ergonomics around disabling warnings with cc-option
Date: Thu, 8 Oct 2026 23:54:58 -0700	[thread overview]
Message-ID: <202610082354.46E0A9A41@keescook> (raw)
In-Reply-To: <20261007-scripts-kconfig-toolchain-improvements-v1-2-1e524178da11@kernel.org>

On Wed, Oct 07, 2026 at 05:22:22PM +0200, Nathan Chancellor wrote:
> This is essentially a port of commit 550ccb178de2 ("Make 'cc-option'
> work correctly for the -Wno-xyzzy pattern") to scripts/Kconfig.include,
> which simplifies the definition of many of the newly added CC_OPT_WNO_
> symbols in scripts/Kconfig.toolchain and matches cc-option's behavior in
> Kbuild.
> 
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
>  scripts/Kconfig.include   |  2 +-
>  scripts/Kconfig.toolchain | 18 +++++++++---------
>  2 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/scripts/Kconfig.include b/scripts/Kconfig.include
> index 622d21e6953f..a7d9201acfcc 100644
> --- a/scripts/Kconfig.include
> +++ b/scripts/Kconfig.include
> @@ -26,7 +26,7 @@ failure = $(if-success,$(1),n,y)
>  # $(cc-probe,<flag>)
>  # The command $(cc-option) and $(cc-option-str) test <flag> with. Not meant
>  # to be called directly; use one of those two instead.
> -cc-probe = trap "rm -rf .tmp_$$" EXIT; mkdir .tmp_$$; $(CC) -Werror $(CLANG_FLAGS) $(1) -c -x c /dev/null -o .tmp_$$/tmp.o
> +cc-probe = trap "rm -rf .tmp_$$" EXIT; mkdir .tmp_$$; $(CC) -Werror $(CLANG_FLAGS) $(shell,echo $(1) | sed "s;^-Wno-;-W;") -c -x c /dev/null -o .tmp_$$/tmp.o

Nice! Yeah, good cleanup.

Reviewed-by: Kees Cook <kees@kernel.org>

-- 
Kees Cook

  reply	other threads:[~2026-10-09  6:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 15:22 [PATCH 0/2] Initial ergonomic improvements to scripts/Kconfig.toolchain Nathan Chancellor
2026-10-07 15:22 ` [PATCH 1/2] scripts/Kconfig.toolchain: Drop compiler symbols from dependencies Nathan Chancellor
2026-10-09  6:54   ` Kees Cook
2026-10-09  8:41     ` Nicolas Schier
2026-10-09 19:22       ` Nathan Chancellor
2026-10-07 15:22 ` [PATCH 2/2] kconfig: Improve ergonomics around disabling warnings with cc-option Nathan Chancellor
2026-10-09  6:54   ` Kees Cook [this message]
2026-10-07 16:48 ` [PATCH 0/2] Initial ergonomic improvements to scripts/Kconfig.toolchain Nicolas Schier
2026-10-09  6:56   ` Kees Cook
2026-10-09 19:14     ` Nathan Chancellor
2026-10-09 19:43       ` Nicolas Schier
2026-10-09 20:27 ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202610082354.46E0A9A41@keescook \
    --to=kees@kernel.org \
    --cc=julianbraha@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nsc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®