mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Nicolas Schier <nsc@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
	Julian Braha <julianbraha@gmail.com>,
	Lorenzo Stoakes <ljs@kernel.org>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Initial ergonomic improvements to scripts/Kconfig.toolchain
Date: Thu, 8 Oct 2026 23:56:13 -0700	[thread overview]
Message-ID: <202610082355.D904DA02@keescook> (raw)
In-Reply-To: <179139172076.154975.7876331914722818497.b4-review@b4>

On Wed, Oct 07, 2026 at 06:48:40PM +0200, Nicolas Schier wrote:
> When I look into the resulting .config, I'd wish, these empty string
> kconfig symbols could be unset, e.g.
> 
>     # CONFIG_CC_OPT_WNO_FORMAT_TRUNCATION_NON_KPRINTF is not set
>     # CONFIG_CC_OPT_WNO_DEFAULT_CONST_INIT_UNSAFE is not set
>     CONFIG_CC_OPT_WNO_DANGLING_POINTER="-Wno-dangling-pointer"
>     CONFIG_CC_OPT_WVLA_LARGER_THAN="-Wvla-larger-than=1"
>     CONFIG_CC_HAS_WSTRINGOP_OVERFLOW=y
> 
> instead of the current:
> 
>     CONFIG_CC_OPT_WNO_FORMAT_TRUNCATION_NON_KPRINTF=""
>     CONFIG_CC_OPT_WNO_DEFAULT_CONST_INIT_UNSAFE=""
>     CONFIG_CC_OPT_WNO_DANGLING_POINTER="-Wno-dangling-pointer"
>     CONFIG_CC_OPT_WVLA_LARGER_THAN="-Wvla-larger-than=1"
>     CONFIG_CC_HAS_WSTRINGOP_OVERFLOW=y
> 
> but that would make things unneccessary more complicated, right now.

Yeah, it may be worth documenting somewhere that "CONFIG_CC_OPT_..."
will have empty strings, and if someone wants to test _availability_ of
a feature, they need to still create and use CONFIG_CC_HAS_... ?

-- 
Kees Cook

  reply	other threads:[~2026-10-09  6:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 15:22 Nathan Chancellor
2026-10-07 15:22 ` [PATCH 1/2] scripts/Kconfig.toolchain: Drop compiler symbols from dependencies Nathan Chancellor
2026-10-09  6:54   ` Kees Cook
2026-10-09  8:41     ` Nicolas Schier
2026-10-09 19:22       ` Nathan Chancellor
2026-10-07 15:22 ` [PATCH 2/2] kconfig: Improve ergonomics around disabling warnings with cc-option Nathan Chancellor
2026-10-09  6:54   ` Kees Cook
2026-10-07 16:48 ` [PATCH 0/2] Initial ergonomic improvements to scripts/Kconfig.toolchain Nicolas Schier
2026-10-09  6:56   ` Kees Cook [this message]
2026-10-09 19:14     ` Nathan Chancellor
2026-10-09 19:43       ` Nicolas Schier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202610082355.D904DA02@keescook \
    --to=kees@kernel.org \
    --cc=julianbraha@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nsc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®