* [PATCH] media: i2c: imx576: Fix line length register
@ 2026-10-09 4:46 David Carlier
2026-10-09 10:31 ` Himanshu Bhavani
0 siblings, 1 reply; 2+ messages in thread
From: David Carlier @ 2026-10-09 4:46 UTC (permalink / raw)
To: sakari.ailus, mchehab
Cc: himanshu.bhavani, hardevsinh.palaniya, linux-media, linux-kernel,
David Carlier
The line length is written to FRAME_LENGTH_LINES instead of
LINE_LENGTH_PCK. The value is later overwritten by the VBLANK control,
so the sensor runs with its default line length while the driver
reports HBLANK and PIXEL_RATE computed from IMX576_LINE_LENGTH.
Fixes: ee2e9bf41d3e ("media: i2c: add imx576 image sensor driver")
Signed-off-by: David Carlier <devnexen@gmail.com>
---
drivers/media/i2c/imx576.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx576.c b/drivers/media/i2c/imx576.c
index 3fcd28d18a51..6243683302c7 100644
--- a/drivers/media/i2c/imx576.c
+++ b/drivers/media/i2c/imx576.c
@@ -507,7 +507,7 @@ static int imx576_set_window(struct imx576 *imx576,
format = v4l2_subdev_state_get_format(state, 0);
/* Line length */
- cci_write(imx576->regmap, CCS_R_FRAME_LENGTH_LINES, IMX576_LINE_LENGTH,
+ cci_write(imx576->regmap, CCS_R_LINE_LENGTH_PCK, IMX576_LINE_LENGTH,
&ret);
/* Imaging area */
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: i2c: imx576: Fix line length register
2026-10-09 4:46 [PATCH] media: i2c: imx576: Fix line length register David Carlier
@ 2026-10-09 10:31 ` Himanshu Bhavani
0 siblings, 0 replies; 2+ messages in thread
From: Himanshu Bhavani @ 2026-10-09 10:31 UTC (permalink / raw)
To: David Carlier, sakari.ailus, mchehab
Cc: Hardevsinh Palaniya, linux-media, linux-kernel
Hi David,
>The line length is written to FRAME_LENGTH_LINES instead of
>LINE_LENGTH_PCK. The value is later overwritten by the VBLANK control,
>so the sensor runs with its default line length while the driver
>reports HBLANK and PIXEL_RATE computed from IMX576_LINE_LENGTH.
>
>Fixes: ee2e9bf41d3e ("media: i2c: add imx576 image sensor driver")
>Signed-off-by: David Carlier <devnexen@gmail.com>
>---
> drivers/media/i2c/imx576.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/media/i2c/imx576.c b/drivers/media/i2c/imx576.c
>index 3fcd28d18a51..6243683302c7 100644
>--- a/drivers/media/i2c/imx576.c
>+++ b/drivers/media/i2c/imx576.c
>@@ -507,7 +507,7 @@ static int imx576_set_window(struct imx576 *imx576,
> format = v4l2_subdev_state_get_format(state, 0);
>
> /* Line length */
>- cci_write(imx576->regmap, CCS_R_FRAME_LENGTH_LINES, IMX576_LINE_LENGTH,
>+ cci_write(imx576->regmap, CCS_R_LINE_LENGTH_PCK, IMX576_LINE_LENGTH,
> &ret);
>
> /* Imaging area */
>--
>2.55
Ah, thanks for catching this
Reviewed-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
Best Regards,
Himanshu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-09 10:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-09 4:46 [PATCH] media: i2c: imx576: Fix line length register David Carlier
2026-10-09 10:31 ` Himanshu Bhavani
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®