* kconfig: cleanup stale comment about 'keys' array
@ 2026-10-09 9:46 Julian Braha
2026-10-09 15:33 ` Nicolas Schier
2026-10-09 20:30 ` Nathan Chancellor
0 siblings, 2 replies; 3+ messages in thread
From: Julian Braha @ 2026-10-09 9:46 UTC (permalink / raw)
To: nathan, nsc; +Cc: linux-kbuild, linux-kernel, Julian Braha
'keys' was removed from 'dialog_textbox' in:
commit e14f1242a8be ("kconfig: menuconfig: simplify global jump key assignment")
but the comment referencing it was never removed.
Let's cleanup this stale comment.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
scripts/kconfig/lxdialog/textbox.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/scripts/kconfig/lxdialog/textbox.c b/scripts/kconfig/lxdialog/textbox.c
index 0abaf635978f..3fe7682fc8a8 100644
--- a/scripts/kconfig/lxdialog/textbox.c
+++ b/scripts/kconfig/lxdialog/textbox.c
@@ -145,8 +145,6 @@ static void refresh_text_box(WINDOW *dialog, WINDOW *box, int boxh, int boxw,
/*
* Display text from a file in a dialog box.
- *
- * keys is a null-terminated array
*/
int dialog_textbox(const char *title, const char *tbuf, int initial_height,
int initial_width, int *_vscroll, int *_hscroll,
--
2.55.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: kconfig: cleanup stale comment about 'keys' array
2026-10-09 9:46 kconfig: cleanup stale comment about 'keys' array Julian Braha
@ 2026-10-09 15:33 ` Nicolas Schier
2026-10-09 20:30 ` Nathan Chancellor
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Schier @ 2026-10-09 15:33 UTC (permalink / raw)
To: Julian Braha; +Cc: nathan, linux-kbuild, linux-kernel
On Fri, Oct 09, 2026 at 10:46:17AM +0100, Julian Braha wrote:
> 'keys' was removed from 'dialog_textbox' in:
> commit e14f1242a8be ("kconfig: menuconfig: simplify global jump key assignment")
> but the comment referencing it was never removed.
>
> Let's cleanup this stale comment.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
> scripts/kconfig/lxdialog/textbox.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Nicolas Schier <n.schier@fritz.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: kconfig: cleanup stale comment about 'keys' array
2026-10-09 9:46 kconfig: cleanup stale comment about 'keys' array Julian Braha
2026-10-09 15:33 ` Nicolas Schier
@ 2026-10-09 20:30 ` Nathan Chancellor
1 sibling, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2026-10-09 20:30 UTC (permalink / raw)
To: nsc, Julian Braha; +Cc: linux-kbuild, linux-kernel
On Fri, 09 Oct 2026 10:46:17 +0100, Julian Braha wrote:
> kconfig: cleanup stale comment about 'keys' array
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/kbuild/linux.git kbuild-next-unstable
Thanks!
[1/1] kconfig: cleanup stale comment about 'keys' array
https://git.kernel.org/kbuild/c/2160297cabd4b
Please look out for regression or issue reports or other follow up
comments, as they may result in the patch/series getting dropped or
reverted. Patches applied to an "unstable" branch are accepted pending
wider testing in -next and any post-commit review; they will generally
be moved to the main branch in a week if no issues are found.
Best regards,
--
Cheers,
Nathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-09 20:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-09 9:46 kconfig: cleanup stale comment about 'keys' array Julian Braha
2026-10-09 15:33 ` Nicolas Schier
2026-10-09 20:30 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®