[PATCH] power: supply: generic-adc-battery: Propagate charged GPIO errors

[PATCH] power: supply: generic-adc-battery: Propagate charged GPIO errors

[phucduc.bui]

From: bui duc phuc <phucduc.bui@gmail.com>

devm_gpiod_get_optional() may return an error pointer such as
-EPROBE_DEFER, but gab_probe() only checks for NULL. The error
pointer is then passed to gpiod_to_irq() and the original error,
including -EPROBE_DEFER, is lost.

Check the return value and propagate errors from the charged GPIO lookup.

Fixes: b0327ffb133f ("power: supply: generic-adc-battery: Use GPIO descriptors")
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
 drivers/power/supply/generic-adc-battery.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/power/supply/generic-adc-battery.c b/drivers/power/supply/generic-adc-battery.c
index 185f55d2fd70..f3ca3ebb2533 100644
--- a/drivers/power/supply/generic-adc-battery.c
+++ b/drivers/power/supply/generic-adc-battery.c
@@ -238,6 +238,9 @@ static int gab_probe(struct platform_device *pdev)
 		return dev_err_probe(&pdev->dev, ret, "Failed to register delayed work\n");
 
 	adc_bat->charge_finished = devm_gpiod_get_optional(&pdev->dev, "charged", GPIOD_IN);
+	if (IS_ERR(adc_bat->charge_finished))
+		return dev_err_probe(&pdev->dev, PTR_ERR(adc_bat->charge_finished),
+				     "failed to get charged GPIO\n");
 	if (adc_bat->charge_finished) {
 		int irq;
 
-- 
2.43.0

Re: [PATCH] power: supply: generic-adc-battery: Propagate charged GPIO errors

[Linus Walleij]

On Fri, Oct 9, 2026 at 1:24 PM <phucduc.bui@gmail.com> wrote:

> From: bui duc phuc <phucduc.bui@gmail.com>
>
> devm_gpiod_get_optional() may return an error pointer such as
> -EPROBE_DEFER, but gab_probe() only checks for NULL. The error
> pointer is then passed to gpiod_to_irq() and the original error,
> including -EPROBE_DEFER, is lost.
>
> Check the return value and propagate errors from the charged GPIO lookup.
>
> Fixes: b0327ffb133f ("power: supply: generic-adc-battery: Use GPIO descriptors")
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>

That's right.
Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij