mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Thorsten Leemhuis <linux@leemhuis.info>
Cc: Sasha Levin <sashal@kernel.org>,
	workflows@vger.kernel.org, ksummit@lists.linux.dev,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	corbet@lwn.net, skhan@linuxfoundation.org, rdunlap@infradead.org,
	broonie@kernel.org, tytso@mit.edu,
	Linux kernel regressions list <regressions@lists.linux.dev>
Subject: Re: [PATCH 2/2] agents: add a skill to determine Fixes tags
Date: Sat, 10 Oct 2026 06:33:05 -0400	[thread overview]
Message-ID: <20261010063228-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <c3ce794d-1ac2-4ef3-9e5c-1e171bd77a89@leemhuis.info>

On Sat, Oct 10, 2026 at 11:40:56AM +0200, Thorsten Leemhuis wrote:
> On 10/9/26 00:54, Sasha Levin wrote:
> >
> > +A ``Fixes:`` tag identifies the commit that introduced the bug being fixed. [...]
> 
> Sorry for partly hijacking this, but it seems appropriate while we are
> at it:
> 
> What exactly is the right commit to specify when it comes to a
> regression caused by a change that exposed a way older bug? The change
> that exposed it? The change that introduced it in the first place? Both?
> I'd tend to "both", but I guess some people might consider this as too
> noisy.
> 
> I've seen occasional discussions about this and our docs for humans are
> a bit vague here:
> 
> Documentation/process/submitting-patches.rst says:
> ""If your patch fixes a bug in a specific commit, e.g. you found an
> issue using git bisect, please use the ‘Fixes:’ tag with at least the
> first 12 characters of the SHA-1 ID, and the one line summary.
> [...]
> A Fixes: tag indicates that the patch fixes a bug in a previous commit.
> It is used to make it easy to determine where an issue originated""
> 
> And Documentation/process/5.Posting.rst says:
> ""One tag is used to refer to earlier commits which introduced problems
> fixed by the patch:""
> 
> Ciao, Thorsten

I'd say the one exposed it. this way it is useful to answer
the question "do i need this fix".


  reply	other threads:[~2026-10-10 10:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-08 22:54 [PATCH 0/2] agents: add portable agent skills and Fixes attribution Sasha Levin
2026-10-08 22:54 ` [PATCH 1/2] agents: add infrastructure for agent resources Sasha Levin
2026-10-09 10:27   ` Greg KH
2026-10-09 10:35     ` Sasha Levin
2026-10-09 10:53       ` Greg KH
2026-10-09 13:40   ` Leon Romanovsky
2026-10-09 14:20     ` Sasha Levin
2026-10-09 14:22       ` Konstantin Ryabitsev
2026-10-09 16:36         ` Leon Romanovsky
2026-10-09 22:28           ` Konstantin Ryabitsev
2026-10-08 22:54 ` [PATCH 2/2] agents: add a skill to determine Fixes tags Sasha Levin
2026-10-10  9:40   ` Thorsten Leemhuis
2026-10-10 10:33     ` Michael S. Tsirkin [this message]
2026-10-10 13:45       ` Sasha Levin
2026-10-09  9:42 ` [PATCH 0/2] agents: add portable agent skills and Fixes attribution Laurent Pinchart
2026-10-09 10:11   ` Sasha Levin
2026-10-09 16:30     ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261010063228-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=broonie@kernel.org \
    --cc=corbet@lwn.net \
    --cc=ksummit@lists.linux.dev \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=rdunlap@infradead.org \
    --cc=regressions@lists.linux.dev \
    --cc=sashal@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tytso@mit.edu \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®