mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Luka Gejak <luka.gejak@linux.dev>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Michael Straube <straube.linux@gmail.com>,
	Peter Robinson <pbrobinson@gmail.com>,
	Bitterblue Smith <rtl8821cerfe2@gmail.com>
Subject: Re: [PATCH rtw-next v8 5/7] wifi: rtw88: 8723b: add the RTL8723B chip driver
Date: Sat, 10 Oct 2026 12:18:39 +0200	[thread overview]
Message-ID: <2026101046-transport-unnerving-96de@gregkh> (raw)
In-Reply-To: <3028b229a6fbe02d2bcfa30c497b6a768ba8c928@linux.dev>

On Wed, Oct 07, 2026 at 10:35:25AM +0000, Luka Gejak wrote:
> October 7, 2026 at 12:06, "Greg KH" <gregkh@linuxfoundation.org mailto:gregkh@linuxfoundation.org?to=%22Greg%20KH%22%20%3Cgregkh%40linuxfoundation.org%3E > wrote:
> 
> 
> > 
> > On Wed, Oct 07, 2026 at 08:54:03AM +0000, Ping-Ke Shih wrote:
> > 
> > > 
> > > + Greg to staging rtl8723bs driver question
> > >  
> > >  Hi Greg,
> > >  
> > >  Luka Gejak <luka.gejak@linux.dev> wrote:
> > >  October 7, 2026 at 10:32, "Ping-Ke Shih" <pkshih@realtek.com
> > >  mailto:pkshih@realtek.com?to=%22Ping-Ke%20Shih%22%20%3Cpkshih%40realtek.com%3E > wrote:
> > >  
> > >  
> > >  >
> > >  > Luka Gejak <luka.gejak@linux.dev> wrote:
> > >  >
> > >  > >
> > >  > > October 7, 2026 at 04:57, "Ping-Ke Shih" <pkshih@realtek.com
> > >  > > mailto:pkshih@realtek.com?to=%22Ping-Ke%20Shih%22%20%3Cpkshih%40realtek.com%3E > wrote:
> > >  > >
> > >  > >
> > >  > >
> > >  > > Luka Gejak <luka.gejak@linux.dev> wrote:
> > >  > >
> > >  > > >
> > >  > > > Add the Realtek RTL8723B 802.11n chip driver: the chip operations, the
> > >  > > > power sequences, the efuse layout, the RF and IQ calibration, and the
> > >  > > > chip specific coexistence handling.
> > >  > > >
> > >  > > > The RTL8723B chip support is based on the initial work by
> > >  > > > Michael Straube <straube.linux@gmail.com>.
> > >  > > > Link: https://github.com/mistraube/rtw88/tree/rtl8723bs
> > >  > > >
> > >  > > > Co-developed-by: Michael Straube <straube.linux@gmail.com>
> > >  > > > Signed-off-by: Michael Straube <straube.linux@gmail.com>
> > >  > > > Signed-off-by: Luka Gejak <luka.gejak@linux.dev>
> > >  > > > Reviewed-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> > >  > > >
> > >  > > Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> > >  > >
> > >  > >
> > >  > > Hi Ping-Ke,
> > >  > >
> > >  > > Thanks for helping and reviewing the series throughout this
> > >  > > upstreaming process. Just one question, when is the series planned to
> > >  > > be applied to rtw-next? I am planning to send a patch to staging to
> > >  > > remove staging rtl8723bs and I need to have information when is it
> > >  > > landing.
> > >  > >
> > >  > I'll merge this patchset and send pull-request tomorrow, but I think you
> > >  > should remove staging rtl8723bs until this patchset drains to upstream.
> > >  >
> > >  > Ping-Ke
> > >  >
> > >  
> > >  Ok. Thanks for information. However, by the time this series reaches
> > >  upstream, won't the merge window be closed? Therefore 2 drivers for
> > >  the same chip will exist for one kernel version, and Greg previously
> > >  said that when a driver is merged we should remove staging so there
> > >  are no two drivers for the same chip.
> > >  
> > >  Luka did rewrite RTL8723BS vendor driver (i.e. staging rtl8723bs) into
> > >  upstream rtw88 driver, and I plan to merge this patchset and send
> > >  pull-request to wireless maintainer tomorrow. However, the two drivers
> > >  are existing at this moment. 
> > >  
> > >  My question is that can Luka send a patch to remove staging rtl8723bs,
> > >  and goes via my tree? Then you don't need to wait for my pull-request
> > >  being upstream. Can it work to you?
> > > 
> > That's fine with me, delete away!
> > 
> > thanks,
> > 
> > greg k-h
> >
> 
> Hi Greg,
> 
> I have sent the patch, and I think you are going to like this
> number: 66186 deletions

Very happy :)

> Not sure what people are going to use to learn though. It seems to
> me everyone is repeating the same patches.

Yeah, we need to dig up some more out-of-tree kernel code to add it for
them to churn on.  But really, this is a good thing, it's nice to see
real support for this hardware finally.

greg k-h

  reply	other threads:[~2026-10-10 10:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 13:06 [PATCH rtw-next v8 0/7] wifi: rtw88: add RTL8723B/RTL8723BS support Luka Gejak
2026-10-06 13:06 ` [PATCH rtw-next v8 1/7] wifi: rtw88: move the 88xxa CCK power detect setter to phy.c Luka Gejak
2026-10-08  2:52   ` Ping-Ke Shih
2026-10-06 13:06 ` [PATCH rtw-next v8 2/7] wifi: rtw88: 8723b: add the RTL8723B register definitions Luka Gejak
2026-10-06 13:06 ` [PATCH rtw-next v8 3/7] wifi: rtw88: 8723b: add the RTL8723B BB, RF and AGC tables Luka Gejak
2026-10-06 13:06 ` [PATCH rtw-next v8 4/7] wifi: rtw88: move the shared 8723x definitions to rtw8723x.h Luka Gejak
2026-10-07  2:38   ` Ping-Ke Shih
2026-10-06 13:06 ` [PATCH rtw-next v8 5/7] wifi: rtw88: 8723b: add the RTL8723B chip driver Luka Gejak
2026-10-07  2:57   ` Ping-Ke Shih
2026-10-07  8:24     ` Luka Gejak
2026-10-07  8:32       ` Ping-Ke Shih
2026-10-07  8:39         ` Luka Gejak
2026-10-07  8:54           ` Ping-Ke Shih
2026-10-07 10:06             ` Greg KH
2026-10-07 10:35               ` Luka Gejak
2026-10-10 10:18                 ` Greg KH [this message]
2026-10-09 12:40   ` Bitterblue Smith
2026-10-09 15:33     ` Luka Gejak
2026-10-06 13:07 ` [PATCH rtw-next v8 6/7] wifi: rtw88: 8723bs: add the RTL8723BS SDIO bind Luka Gejak
2026-10-06 13:07 ` [PATCH rtw-next v8 7/7] wifi: rtw88: 8723bs: enable building the RTL8723BS driver Luka Gejak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026101046-transport-unnerving-96de@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luka.gejak@linux.dev \
    --cc=pbrobinson@gmail.com \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®