mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Bitterblue Smith" <rtl8821cerfe2@gmail.com>,
	"Ping-Ke Shih" <pkshih@realtek.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Michael Straube" <straube.linux@gmail.com>,
	"Peter Robinson" <pbrobinson@gmail.com>
Subject: Re: [PATCH rtw-next v8 5/7] wifi: rtw88: 8723b: add the RTL8723B chip driver
Date: Tue, 20 Oct 2026 22:23:55 +0000	[thread overview]
Message-ID: <c76695aec44d818f319923495b7be5f2d1b4a699@linux.dev> (raw)
In-Reply-To: <c14d646f-b8b1-47ce-a92e-cbd5f534503f@gmail.com>

October 20, 2026 at 8:08 PM, "Bitterblue Smith" <rtl8821cerfe2@gmail.com> wrote:


> 
> On 06/10/2026 16:06, Luka Gejak wrote:
> 
> > 
> > Add the Realtek RTL8723B 802.11n chip driver: the chip operations, the
> >  power sequences, the efuse layout, the RF and IQ calibration, and the
> >  chip specific coexistence handling.
> >  
> >  The RTL8723B chip support is based on the initial work by
> >  Michael Straube <straube.linux@gmail.com>.
> >  Link: https://github.com/mistraube/rtw88/tree/rtl8723bs
> >  
> >  Co-developed-by: Michael Straube <straube.linux@gmail.com>
> >  Signed-off-by: Michael Straube <straube.linux@gmail.com>
> >  Signed-off-by: Luka Gejak <luka.gejak@linux.dev>
> >  Reviewed-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> >  ---
> >  drivers/net/wireless/realtek/rtw88/rtw8723b.c | 2534 +++++++++++++++++
> >  drivers/net/wireless/realtek/rtw88/rtw8723b.h | 14 +
> >  2 files changed, 2548 insertions(+)
> >  create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8723b.c
> >  create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8723b.h
> >  
> >  diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723b.c b/drivers/net/wireless/realtek/rtw88/rtw8723b.c
> >  new file mode 100644
> >  index 000000000000..8bb9c03d769c
> >  --- /dev/null
> >  +++ b/drivers/net/wireless/realtek/rtw88/rtw8723b.c
> > 
> [...]
> 
> > 
> > +static int rtw8723b_read_efuse(struct rtw_dev *rtwdev, u8 *log_map)
> >  +{
> >  + struct rtw_efuse *efuse = &rtwdev->efuse;
> >  + int ret;
> >  +
> >  + ret = rtw8723x_read_efuse(rtwdev, log_map);
> >  + if (ret)
> >  + return ret;
> >  +
> >  + /*
> >  + * Report a power track type this driver does not implement once,
> >  + * here, rather than on every two second pwr_track() tick.
> >  + */
> >  + if (efuse->power_track_type != 0)
> >  + rtw_warn(rtwdev, "unsupported power track type\n");
> >  +
> >  + /*
> >  + * No firmware hardware feature report exists, so fill the hardware
> >  + * capability here; a zero stream count kills the HT MCS set.
> >  + */
> >  + efuse->hw_cap.nss = max_t(u8, rtwdev->hal.rf_path_num, 1);
> > 
> Another thing I noticed too late: this chip always supports only one
> spatial stream. rf_path_num happens to be 1, so no harm done.

You are right, we can just set it directly, no need to derive the value.
I have sent a patch for it.

Best regards,
Luka Gejak

  reply	other threads:[~2026-10-20 22:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 13:06 [PATCH rtw-next v8 0/7] wifi: rtw88: add RTL8723B/RTL8723BS support Luka Gejak
2026-10-06 13:06 ` [PATCH rtw-next v8 1/7] wifi: rtw88: move the 88xxa CCK power detect setter to phy.c Luka Gejak
2026-10-08  2:52   ` Ping-Ke Shih
2026-10-06 13:06 ` [PATCH rtw-next v8 2/7] wifi: rtw88: 8723b: add the RTL8723B register definitions Luka Gejak
2026-10-06 13:06 ` [PATCH rtw-next v8 3/7] wifi: rtw88: 8723b: add the RTL8723B BB, RF and AGC tables Luka Gejak
2026-10-06 13:06 ` [PATCH rtw-next v8 4/7] wifi: rtw88: move the shared 8723x definitions to rtw8723x.h Luka Gejak
2026-10-07  2:38   ` Ping-Ke Shih
2026-10-06 13:06 ` [PATCH rtw-next v8 5/7] wifi: rtw88: 8723b: add the RTL8723B chip driver Luka Gejak
2026-10-07  2:57   ` Ping-Ke Shih
2026-10-07  8:24     ` Luka Gejak
2026-10-07  8:32       ` Ping-Ke Shih
2026-10-07  8:39         ` Luka Gejak
2026-10-07  8:54           ` Ping-Ke Shih
2026-10-07 10:06             ` Greg KH
2026-10-07 10:35               ` Luka Gejak
2026-10-10 10:18                 ` Greg KH
2026-10-12 11:31                   ` Luka Gejak
2026-10-14 13:04                     ` Greg KH
2026-10-14 13:13                       ` Luka Gejak
2026-10-09 12:40   ` Bitterblue Smith
2026-10-09 15:33     ` Luka Gejak
2026-10-20 18:08   ` Bitterblue Smith
2026-10-20 22:23     ` Luka Gejak [this message]
2026-10-06 13:07 ` [PATCH rtw-next v8 6/7] wifi: rtw88: 8723bs: add the RTL8723BS SDIO bind Luka Gejak
2026-10-06 13:07 ` [PATCH rtw-next v8 7/7] wifi: rtw88: 8723bs: enable building the RTL8723BS driver Luka Gejak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c76695aec44d818f319923495b7be5f2d1b4a699@linux.dev \
    --to=luka.gejak@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pbrobinson@gmail.com \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®