* [PATCH] rpmsg: glink: release channel OF node reference
@ 2026-10-12 7:50 Avi Weiss
0 siblings, 0 replies; only message in thread
From: Avi Weiss @ 2026-10-12 7:50 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Mathieu Poirier, linux-remoteproc, linux-arm-msm, linux-kernel,
Avi Weiss
qcom_glink_match_channel() returns a referenced child node, which
qcom_glink_rx_open() stores in rpdev->dev.of_node.
The release callback frees the rpmsg device but never drops the node
reference, so it leaks when the channel device goes away.
Drop the reference in qcom_glink_rpdev_release() before freeing the
device.
Fixes: b4f8e52b89f69 ("rpmsg: Introduce Qualcomm RPM glink driver")
Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
---
drivers/rpmsg/qcom_glink_native.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index 55793fc18293..5142730dabc4 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -1623,6 +1623,7 @@ static void qcom_glink_rpdev_release(struct device *dev)
{
struct rpmsg_device *rpdev = to_rpmsg_device(dev);
+ of_node_put(dev->of_node);
kfree(rpdev);
}
base-commit: c39c2cdbde1f2ad9e2886167e55ad6b4c4907d7f
--
2.43.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-12 7:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-12 7:50 [PATCH] rpmsg: glink: release channel OF node reference Avi Weiss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®