From: Thomas Zimmermann <tzimmermann@suse.de>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org, deller@gmx.de,
James.Bottomley@HansenPartnership.com, simona@ffwll.ch
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-parisc@vger.kernel.org,
sashiko-reviews@lists.linux.dev,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 0/2] vt: Simplify console-blanking interface
Date: Mon, 12 Oct 2026 11:27:37 +0200 [thread overview]
Message-ID: <20261012094114.38549-1-tzimmermann@suse.de> (raw)
The vt subsystem calls con_blank with what appears to be non-sensical
value. This is because the values and the type of the blank argument
do not match: it mixes up console blank state and monitor DPMS levels
for powersaving. The implmentations of con_blank in various consoles
suffer from the same problem. Update con_blank to a clearer interface.
Also update the consoles.
Patch 1 does a bit of preparation. It converts a boolean parameter
from int to bool, so that its meaning is clearer.
Patch 2 updates con_blank. The callback's blank parameter now controls
blanking in general. The new blank_mode parameter controls the monitor
status and related powersaving.
Tested with vgacon on a SiS 6202 VGA and with fbcon on a Matrox G200
VGA device. The latter also ran fbcon via DRM fbdev emulation. Its easy
to test this with setterm, like this
setterm --blank force # blank
setterm --blank poke # unblank
setterm --blank force --powersave powerdown # blank and turn off monitor
Blanking and unblanking still works in all tested cases.
Thomas Zimmermann (2):
vt: Use boolean as parameter to do_blank_screen() and
do_unblank_screen()
vt: Distinguish between blanking and VESA blank mode in con_blank
drivers/tty/vt/vt.c | 25 ++++++++--------
drivers/tty/vt/vt_ioctl.c | 12 ++++----
drivers/video/console/dummycon.c | 4 +--
drivers/video/console/newport_con.c | 4 +--
drivers/video/console/sticon.c | 4 +--
drivers/video/console/vgacon.c | 44 +++++++++++++++--------------
drivers/video/fbdev/core/fbcon.c | 23 +++++++--------
include/linux/console.h | 9 ++++--
include/linux/vt_kern.h | 5 ++--
9 files changed, 69 insertions(+), 61 deletions(-)
base-commit: b0bd9fb9e92aae2a653efa1d0407daa2aabe99d0
--
2.55.0
next reply other threads:[~2026-10-12 9:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 9:27 Thomas Zimmermann [this message]
2026-10-12 9:27 ` [PATCH 1/2] vt: Use boolean as parameter to do_blank_screen() and do_unblank_screen() Thomas Zimmermann
2026-10-12 11:30 ` Greg KH
2026-10-12 12:28 ` Thomas Zimmermann
2026-10-12 12:41 ` Thomas Zimmermann
2026-10-12 16:13 ` Greg KH
2026-10-12 9:27 ` [PATCH 2/2] vt: Distinguish between blanking and VESA blank mode in con_blank Thomas Zimmermann
2026-10-12 11:29 ` Greg KH
2026-10-12 12:08 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261012094114.38549-1-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=deller@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®