[PATCH v3 0/3] Add Nsiway NS2009 touchscreen support

[PATCH v3 0/3] Add Nsiway NS2009 touchscreen support

[Miotsuki Mizuno]

Add the vendor prefix, hardware binding and initial polling driver for
the four-wire resistive touchscreen controller.

Changes since v2:
- Use unevaluatedProperties: false and inherit the common touchscreen
  properties without redundant declarations.
- Simplify description without a literal block marker and keep one
  complete interrupt/supply example.
- Drop the inappropriate Suggested-by trailer.
- Use consistent author and sender names; include an explicit in-body
  author line in each patch to preserve authorship through mail relays.

The polling driver and vendor-prefix content are unchanged from v2.
IRQ operation, wakeup handling and touch resistance calculation remain
separate future driver work.

Based on current mainline 24a19b953e2a. Binding checks and a W=1 driver
object build were performed locally; M10 schema validation uses an
independent combination tree with the still-unmerged NS2009 dependencies.

Mizuno Miotsuki (3):
  dt-bindings: vendor-prefixes: add Nsiway
  dt-bindings: input: touchscreen: add Nsiway NS2009
  Input: add Nsiway NS2009 resistive touchscreen driver

 .../input/touchscreen/nsiway,ns2009.yaml      |  78 ++++++++
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 MAINTAINERS                                   |   7 +
 drivers/input/touchscreen/Kconfig             |  10 +
 drivers/input/touchscreen/Makefile            |   1 +
 drivers/input/touchscreen/ns2009.c            | 175 ++++++++++++++++++
 6 files changed, 273 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/nsiway,ns2009.yaml
 create mode 100644 drivers/input/touchscreen/ns2009.c


base-commit: 24a19b953e2a3d0ea5a8c4951a0ab8f32720c907
-- 
2.56.0

[PATCH v3 1/3] dt-bindings: vendor-prefixes: add Nsiway

[Miotsuki Mizuno]

From: Mizuno Miotsuki <founder@crepuse.com>

Nsiway manufactures the NS2009 I2C resistive touchscreen controller.
Add its vendor prefix for the touchscreen binding.

Signed-off-by: Mizuno Miotsuki <founder@crepuse.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index ba2002969373..a180012054c9 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -1214,6 +1214,8 @@ patternProperties:
     description: Novatek
   "^novtech,.*":
     description: NovTech, Inc.
+  "^nsiway,.*":
+    description: Shenzhen Nsiway Technology Co., Ltd.
   "^nuclei,.*":
     description: Nuclei System Technology
   "^numonyx,.*":
-- 
2.56.0

[PATCH v3 2/3] dt-bindings: input: touchscreen: add Nsiway NS2009

[Miotsuki Mizuno]

From: Mizuno Miotsuki <founder@crepuse.com>

Describe the Nsiway NS2009 four-wire resistive touchscreen controller
with optional pen interrupt, power and reference supplies, and touch
resistance measurement properties. Include one complete example.

Signed-off-by: Mizuno Miotsuki <founder@crepuse.com>
---
 .../input/touchscreen/nsiway,ns2009.yaml      | 78 +++++++++++++++++++
 MAINTAINERS                                   |  6 ++
 2 files changed, 84 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/nsiway,ns2009.yaml

diff --git a/Documentation/devicetree/bindings/input/touchscreen/nsiway,ns2009.yaml b/Documentation/devicetree/bindings/input/touchscreen/nsiway,ns2009.yaml
new file mode 100644
index 000000000000..caea15b5c5a3
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/touchscreen/nsiway,ns2009.yaml
@@ -0,0 +1,78 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/touchscreen/nsiway,ns2009.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Nsiway NS2009 resistive touchscreen controller
+
+maintainers:
+  - Mizuno Miotsuki <founder@crepuse.com>
+
+description:
+  Nsiway NS2009 is an I2C four-wire resistive touchscreen controller with
+  a 12-bit ADC, an active-low pen interrupt and touch resistance measurement.
+
+allOf:
+  - $ref: touchscreen.yaml#
+
+properties:
+  compatible:
+    const: nsiway,ns2009
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+    description:
+      Active-low pen interrupt output. Optional when the signal is not
+      connected.
+
+  wakeup-source:
+    type: boolean
+
+  vdd-supply:
+    description: Main power supply.
+
+  vref-supply:
+    description: External ADC reference voltage supply.
+
+  touchscreen-min-pressure:
+    minimum: 1
+    maximum: 4095
+    default: 80
+    description:
+      Minimum raw Z1 reading considered a touch. This is a contact detection
+      threshold, not a calibrated pressure value. Boards may require a higher
+      empirically determined threshold than the historical driver default.
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        touchscreen@48 {
+            compatible = "nsiway,ns2009";
+            reg = <0x48>;
+            interrupt-parent = <&gpio1>;
+            interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
+            wakeup-source;
+            vdd-supply = <&vdd>;
+            vref-supply = <&vref>;
+            touchscreen-x-plate-ohms = <400>;
+            touchscreen-min-pressure = <150>;
+            touchscreen-max-pressure = <4095>;
+            touchscreen-fuzz-pressure = <16>;
+            touchscreen-inverted-y;
+        };
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index f53047aa8d3c..696f2badc49c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19467,6 +19467,12 @@ S:	Maintained
 F:	Documentation/core-api/symbol-namespaces.rst
 F:	scripts/nsdeps
 
+NSIWAY NS2009 TOUCHSCREEN CONTROLLER
+M:	Mizuno Miotsuki <founder@crepuse.com>
+L:	linux-input@vger.kernel.org
+S:	Maintained
+F:	Documentation/devicetree/bindings/input/touchscreen/nsiway,ns2009.yaml
+
 NTB AMD DRIVER
 M:	Basavaraj Natikar <Basavaraj.Natikar@amd.com>
 M:	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
-- 
2.56.0

[PATCH v3 3/3] Input: add Nsiway NS2009 resistive touchscreen driver

[Miotsuki Mizuno]

From: Mizuno Miotsuki <founder@crepuse.com>

Add polling support for the Nsiway NS2009 I2C touchscreen controller using
the input polling API and managed input allocation. Read 12-bit X/Y ADC
values and report BTN_TOUCH from the raw Z1 contact threshold. Apply
coordinate transforms through the common touchscreen helpers.

This implementation derives from Icenowy Zheng's 2017 polling driver.
Keep its historical threshold default while allowing a firmware override,
and retain the original copyright and author attribution.

Report the touch key on every successful sample and let the input core
filter repeated values. A private pen-down flag would become stale when
the core clears key state during inhibit or reset. On a failed, short or
malformed I2C read, discard the coordinates and release the contact so a
failed bus cannot leave it stuck down. A later valid sample reports a new
contact.

Validate the zero padding in the low nibble of the second byte as specified
by the 12-bit read-command format. Reject malformed responses before
assigning the decoded value, and rate-limit the diagnostic output.

Tested on UNIHIKER M10 V1.2 with a Linux 6.18 validation module: clicks,
long presses, drags, release, axis orientation and three held-contact
inhibit/uninhibit cycles. The validation module only changes the driver
registration name to replace the existing built-in driver.

Link: https://lore.kernel.org/all/20170315155140.54518-4-icenowy@aosc.xyz/

Signed-off-by: Mizuno Miotsuki <founder@crepuse.com>
---
 MAINTAINERS                        |   1 +
 drivers/input/touchscreen/Kconfig  |  10 ++
 drivers/input/touchscreen/Makefile |   1 +
 drivers/input/touchscreen/ns2009.c | 175 +++++++++++++++++++++++++++++
 4 files changed, 187 insertions(+)
 create mode 100644 drivers/input/touchscreen/ns2009.c

diff --git a/MAINTAINERS b/MAINTAINERS
index 696f2badc49c..e282c02ec13f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19472,6 +19472,7 @@ M:	Mizuno Miotsuki <founder@crepuse.com>
 L:	linux-input@vger.kernel.org
 S:	Maintained
 F:	Documentation/devicetree/bindings/input/touchscreen/nsiway,ns2009.yaml
+F:	drivers/input/touchscreen/ns2009.c
 
 NTB AMD DRIVER
 M:	Basavaraj Natikar <Basavaraj.Natikar@amd.com>
diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 9b9ae8ac3f7f..d4cdf1a7e057 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -691,6 +691,16 @@ config TOUCHSCREEN_MTOUCH
 	  To compile this driver as a module, choose M here: the
 	  module will be called mtouch.
 
+config TOUCHSCREEN_NS2009
+	tristate "Nsiway NS2009 touchscreen controller"
+	depends on I2C
+	help
+	  Say Y here if you have a resistive touchscreen using the Nsiway
+	  NS2009 controller connected over I2C.
+
+	  To compile this driver as a module, choose M here: the module will be
+	  called ns2009.
+
 config TOUCHSCREEN_NOVATEK_NVT_TS
 	tristate "Novatek NT11205 touchscreen support"
 	depends on I2C
diff --git a/drivers/input/touchscreen/Makefile b/drivers/input/touchscreen/Makefile
index bfd9de83389d..c5fc2062d7cf 100644
--- a/drivers/input/touchscreen/Makefile
+++ b/drivers/input/touchscreen/Makefile
@@ -68,6 +68,7 @@ obj-$(CONFIG_TOUCHSCREEN_MIGOR)		+= migor_ts.o
 obj-$(CONFIG_TOUCHSCREEN_MMS114)	+= mms114.o
 obj-$(CONFIG_TOUCHSCREEN_MSG2638)	+= msg2638.o
 obj-$(CONFIG_TOUCHSCREEN_MTOUCH)	+= mtouch.o
+obj-$(CONFIG_TOUCHSCREEN_NS2009)	+= ns2009.o
 obj-$(CONFIG_TOUCHSCREEN_NOVATEK_NVT_TS)	+= novatek-nvt-ts.o
 obj-$(CONFIG_TOUCHSCREEN_HP600)		+= hp680_ts_input.o
 obj-$(CONFIG_TOUCHSCREEN_HP7XX)		+= jornada720_ts.o
diff --git a/drivers/input/touchscreen/ns2009.c b/drivers/input/touchscreen/ns2009.c
new file mode 100644
index 000000000000..d5c1f9f96bb6
--- /dev/null
+++ b/drivers/input/touchscreen/ns2009.c
@@ -0,0 +1,175 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Nsiway NS2009 resistive touchscreen controller
+ *
+ * Copyright (C) 2017 Icenowy Zheng <icenowy@aosc.xyz>
+ * Portions derived from silead.c:
+ * Copyright (C) 2014-2015 Intel Corporation
+ */
+
+#include <linux/i2c.h>
+#include <linux/input.h>
+#include <linux/input/touchscreen.h>
+#include <linux/module.h>
+#include <linux/property.h>
+
+#define NS2009_POLL_INTERVAL_MS		30
+#define NS2009_MAX_12BIT		0xfff
+
+#define NS2009_READ_X_LOW_POWER_12BIT	0xc0
+#define NS2009_READ_Y_LOW_POWER_12BIT	0xd0
+#define NS2009_READ_Z1_LOW_POWER_12BIT	0xe0
+
+/* Historical driver default; boards may override via firmware properties. */
+#define NS2009_DEFAULT_PEN_DOWN_Z1	80
+
+struct ns2009_data {
+	struct i2c_client *client;
+	struct touchscreen_properties prop;
+	u16 pen_down_z1;
+};
+
+static int ns2009_read_data(struct ns2009_data *data, u8 command, u16 *value)
+{
+	u8 raw[2];
+	int error;
+
+	error = i2c_smbus_read_i2c_block_data(data->client, command,
+					      sizeof(raw), raw);
+	if (error < 0)
+		return error;
+	if (error != sizeof(raw))
+		return -EIO;
+	/* The 12-bit result is left-aligned; the remaining bits must be zero. */
+	if (raw[1] & 0x0f) {
+		dev_err_ratelimited(&data->client->dev,
+				    "invalid sample for command %#02x: %02x %02x\n",
+				    command, raw[0], raw[1]);
+		return -EIO;
+	}
+
+	*value = (raw[0] << 4) | (raw[1] >> 4);
+	return 0;
+}
+
+static void ns2009_poll(struct input_dev *input)
+{
+	struct ns2009_data *data = input_get_drvdata(input);
+	u16 x, y, z1;
+	int error;
+
+	error = ns2009_read_data(data, NS2009_READ_Z1_LOW_POWER_12BIT, &z1);
+	if (error)
+		goto read_error;
+
+	if (z1 < data->pen_down_z1)
+		goto release;
+
+	error = ns2009_read_data(data, NS2009_READ_X_LOW_POWER_12BIT, &x);
+	if (error)
+		goto read_error;
+
+	error = ns2009_read_data(data, NS2009_READ_Y_LOW_POWER_12BIT, &y);
+	if (error)
+		goto read_error;
+
+	/* The input core filters repeats and may independently clear key state. */
+	input_report_key(input, BTN_TOUCH, 1);
+	touchscreen_report_pos(input, &data->prop, x, y, false);
+	input_sync(input);
+	return;
+
+read_error:
+	dev_err_ratelimited(&data->client->dev,
+			    "failed to poll touch data: %d\n", error);
+	/* An unreadable sample must not leave an active touch stuck down. */
+release:
+	input_report_key(input, BTN_TOUCH, 0);
+	input_sync(input);
+}
+
+static int ns2009_probe(struct i2c_client *client)
+{
+	struct device *dev = &client->dev;
+	struct ns2009_data *data;
+	struct input_dev *input;
+	u32 value;
+	int error;
+
+	if (!i2c_check_functionality(client->adapter,
+				     I2C_FUNC_SMBUS_READ_I2C_BLOCK))
+		return dev_err_probe(dev, -EOPNOTSUPP,
+				     "required SMBus block read is unavailable\n");
+
+	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
+	if (!data)
+		return -ENOMEM;
+
+	input = devm_input_allocate_device(dev);
+	if (!input)
+		return -ENOMEM;
+
+	data->client = client;
+	data->pen_down_z1 = NS2009_DEFAULT_PEN_DOWN_Z1;
+	if (device_property_present(dev, "touchscreen-min-pressure")) {
+		error = device_property_read_u32(dev, "touchscreen-min-pressure",
+						 &value);
+		if (error)
+			return dev_err_probe(dev, error,
+					     "failed to read touchscreen-min-pressure\n");
+		if (!value || value > NS2009_MAX_12BIT)
+			return dev_err_probe(dev, -EINVAL,
+					     "touchscreen-min-pressure must be 1..4095\n");
+		data->pen_down_z1 = value;
+	}
+	input_set_drvdata(input, data);
+
+	input->name = "ns2009_ts";
+	input->phys = "input/ts";
+	input->id.bustype = BUS_I2C;
+
+	__set_bit(INPUT_PROP_DIRECT, input->propbit);
+	input_set_capability(input, EV_KEY, BTN_TOUCH);
+	input_set_abs_params(input, ABS_X, 0, NS2009_MAX_12BIT, 32, 0);
+	input_set_abs_params(input, ABS_Y, 0, NS2009_MAX_12BIT, 16, 0);
+	touchscreen_parse_properties(input, false, &data->prop);
+
+	error = input_setup_polling(input, ns2009_poll);
+	if (error)
+		return dev_err_probe(dev, error, "failed to set up polling\n");
+
+	input_set_poll_interval(input, NS2009_POLL_INTERVAL_MS);
+
+	error = input_register_device(input);
+	if (error)
+		return dev_err_probe(dev, error,
+				     "failed to register input device\n");
+
+	return 0;
+}
+
+static const struct i2c_device_id ns2009_id[] = {
+	{ "ns2009" },
+	{ }
+};
+MODULE_DEVICE_TABLE(i2c, ns2009_id);
+
+static const struct of_device_id ns2009_of_match[] = {
+	{ .compatible = "nsiway,ns2009" },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, ns2009_of_match);
+
+static struct i2c_driver ns2009_driver = {
+	.driver = {
+		.name = "ns2009",
+		.of_match_table = ns2009_of_match,
+	},
+	.probe = ns2009_probe,
+	.id_table = ns2009_id,
+};
+module_i2c_driver(ns2009_driver);
+
+MODULE_AUTHOR("Icenowy Zheng <icenowy@aosc.xyz>");
+MODULE_DESCRIPTION("Nsiway NS2009 resistive touchscreen controller");
+MODULE_LICENSE("GPL");
-- 
2.56.0