* [PATCH] thermal/fw: Fix kernel-doc parameter names
@ 2026-10-12 15:20 Aryan Sinha
2026-10-13 9:00 ` Daniel Lezcano
0 siblings, 1 reply; 2+ messages in thread
From: Aryan Sinha @ 2026-10-12 15:20 UTC (permalink / raw)
To: Rafael J . Wysocki, Daniel Lezcano
Cc: Zhang Rui, Lukasz Luba, linux-pm, linux-kernel, Aryan Sinha
The kernel-doc for thermal_fwnode_cooling_device_register() still names the
old device tree arguments np and of_index, and
devm_thermal_fwnode_cooling_device_register() documents fw_index rather
than fwn_index. Rename them to match the code and reword the device tree
reference as a firmware node one.
Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com>
---
drivers/thermal/thermal_fw.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/thermal/thermal_fw.c b/drivers/thermal/thermal_fw.c
index e8bd2049c..7c28bfada 100644
--- a/drivers/thermal/thermal_fw.c
+++ b/drivers/thermal/thermal_fw.c
@@ -11,13 +11,13 @@
/**
* thermal_fwnode_cooling_device_register() - register an thermal cooling device
- * @np: a pointer to a device tree node.
- * @of_index: a cooling device index in the cooling controller
+ * @fwnode: a pointer to a firmware node.
+ * @fwn_index: a cooling device index in the cooling controller
* @type: the thermal cooling device type.
* @devdata: device private data.
* @ops: standard thermal cooling devices callbacks.
*
- * This function will register a cooling device with device tree node reference.
+ * This function will register a cooling device with a firmware node reference.
* This interface function adds a new thermal cooling device (fan/processor/...)
* to /sys/class/thermal/ folder as cooling_device[0-*]. It tries to bind itself
* to all the thermal zone devices registered at the same time.
@@ -71,7 +71,7 @@ __devm_thermal_fwnode_cooling_device_register(struct device *dev, struct fwnode_
/**
* devm_thermal_fwnode_cooling_device_register() - register a thermal cooling device
* @dev: a valid struct device pointer of a sensor device.
- * @fw_index: a cooling device index in the cooling controller
+ * @fwn_index: a cooling device index in the cooling controller
* @type: the thermal cooling device type.
* @devdata: device private data.
* @ops: standard thermal cooling devices callbacks.
--
2.46.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] thermal/fw: Fix kernel-doc parameter names
2026-10-12 15:20 [PATCH] thermal/fw: Fix kernel-doc parameter names Aryan Sinha
@ 2026-10-13 9:00 ` Daniel Lezcano
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Lezcano @ 2026-10-13 9:00 UTC (permalink / raw)
To: Aryan Sinha, Rafael J . Wysocki, Daniel Lezcano
Cc: Zhang Rui, Lukasz Luba, linux-pm, linux-kernel
On 10/12/26 17:20, Aryan Sinha wrote:
> The kernel-doc for thermal_fwnode_cooling_device_register() still names the
> old device tree arguments np and of_index, and
> devm_thermal_fwnode_cooling_device_register() documents fw_index rather
> than fwn_index. Rename them to match the code and reword the device tree
> reference as a firmware node one.
>
> Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com>
> ---
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-13 9:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-12 15:20 [PATCH] thermal/fw: Fix kernel-doc parameter names Aryan Sinha
2026-10-13 9:00 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®