From: Dave Stevenson <dave.stevenson@raspberrypi.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Jai Luthra <jai.luthra@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Alexander Shiyan <eagle.alexander923@gmail.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: [PATCH v2 09/13] media: sony-starvis2: Add support for IMX662
Date: Tue, 13 Oct 2026 16:17:08 +0100 [thread overview]
Message-ID: <20261013-media-starvis2-v2-9-3670722d250a@raspberrypi.com> (raw)
In-Reply-To: <20261013-media-starvis2-v2-0-3670722d250a@raspberrypi.com>
IMX662 is a 1080p Starvis 2 sensor that follows the same programming
pattern as IMX678, so add it to the newly parameterised common
driver.
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
drivers/media/i2c/sony-starvis2.c | 157 +++++++++++++++++++++++++++++++++++++-
1 file changed, 156 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/sony-starvis2.c b/drivers/media/i2c/sony-starvis2.c
index 27287924915c..c2d4b0aab8c8 100644
--- a/drivers/media/i2c/sony-starvis2.c
+++ b/drivers/media/i2c/sony-starvis2.c
@@ -8,7 +8,9 @@
* Currently supported are:
* IMX678: Diagonal 8.86 mm (Type 1/1.8) CMOS image sensor with 8.40 M effective
* pixels.
- *
+ * IMX662: Diagonal 6.45mm (Type 1/2.8) CMOS image sensor with 2.12 M effective
+ * pixels.
+
* Copyright (C) 2026 Ideas On Board Oy.
*
* Based on Sony IMX678 driver prepared by Will Whang & Soho Enterprise Ltd.
@@ -661,6 +663,136 @@ const struct starvis2_variant imx678_variant_def = {
.hmax_min_pixel_array = 550,
};
+static const struct cci_reg_sequence imx662_common_regs[] = {
+ { CCI_REG8(0x3444), 0xac },
+ { CCI_REG8(0x3492), 0x08 },
+ { CCI_REG8(0x3b00), 0x39 },
+ { CCI_REG8(0x3b23), 0x2d },
+ { CCI_REG8(0x3b45), 0x04 },
+ { CCI_REG8(0x3c0a), 0x1f },
+ { CCI_REG8(0x3c0b), 0x1e },
+ { CCI_REG8(0x3c38), 0x21 },
+ { CCI_REG8(0x3c44), 0x00 },
+ { CCI_REG8(0x3cb6), 0xd8 },
+ { CCI_REG8(0x3cc4), 0xda },
+ { CCI_REG8(0x3e24), 0x79 },
+ { CCI_REG8(0x3e2c), 0x15 },
+ { CCI_REG8(0x3edc), 0x2d },
+ { CCI_REG8(0x4498), 0x05 },
+ { CCI_REG8(0x449c), 0x19 },
+ { CCI_REG8(0x449d), 0x00 },
+ { CCI_REG8(0x449e), 0x32 },
+ { CCI_REG8(0x449f), 0x01 },
+ { CCI_REG8(0x44a0), 0x92 },
+ { CCI_REG8(0x44a2), 0x91 },
+ { CCI_REG8(0x44a4), 0x8c },
+ { CCI_REG8(0x44a6), 0x87 },
+ { CCI_REG8(0x44a8), 0x82 },
+ { CCI_REG8(0x44aa), 0x78 },
+ { CCI_REG8(0x44ac), 0x6e },
+ { CCI_REG8(0x44ae), 0x69 },
+ { CCI_REG8(0x44b0), 0x92 },
+ { CCI_REG8(0x44b2), 0x91 },
+ { CCI_REG8(0x44b4), 0x8c },
+ { CCI_REG8(0x44b6), 0x87 },
+ { CCI_REG8(0x44b8), 0x82 },
+ { CCI_REG8(0x44ba), 0x78 },
+ { CCI_REG8(0x44bc), 0x6e },
+ { CCI_REG8(0x44be), 0x69 },
+ { CCI_REG8(0x44c0), 0x7f },
+ { CCI_REG8(0x44c1), 0x01 },
+ { CCI_REG8(0x44c2), 0x7f },
+ { CCI_REG8(0x44c3), 0x01 },
+ { CCI_REG8(0x44c4), 0x7a },
+ { CCI_REG8(0x44c5), 0x01 },
+ { CCI_REG8(0x44c6), 0x7a },
+ { CCI_REG8(0x44c7), 0x01 },
+ { CCI_REG8(0x44c8), 0x70 },
+ { CCI_REG8(0x44c9), 0x01 },
+ { CCI_REG8(0x44ca), 0x6b },
+ { CCI_REG8(0x44cb), 0x01 },
+ { CCI_REG8(0x44cc), 0x6b },
+ { CCI_REG8(0x44cd), 0x01 },
+ { CCI_REG8(0x44ce), 0x5c },
+ { CCI_REG8(0x44cf), 0x01 },
+ { CCI_REG8(0x44d0), 0x7f },
+ { CCI_REG8(0x44d1), 0x01 },
+ { CCI_REG8(0x44d2), 0x7f },
+ { CCI_REG8(0x44d3), 0x01 },
+ { CCI_REG8(0x44d4), 0x7a },
+ { CCI_REG8(0x44d5), 0x01 },
+ { CCI_REG8(0x44d6), 0x7a },
+ { CCI_REG8(0x44d7), 0x01 },
+ { CCI_REG8(0x44d8), 0x70 },
+ { CCI_REG8(0x44d9), 0x01 },
+ { CCI_REG8(0x44da), 0x6b },
+ { CCI_REG8(0x44db), 0x01 },
+ { CCI_REG8(0x44dc), 0x6b },
+ { CCI_REG8(0x44dd), 0x01 },
+ { CCI_REG8(0x44de), 0x5c },
+ { CCI_REG8(0x44df), 0x01 },
+ { CCI_REG8(0x4534), 0x1c },
+ { CCI_REG8(0x4535), 0x03 },
+ { CCI_REG8(0x4538), 0x1c },
+ { CCI_REG8(0x4539), 0x1c },
+ { CCI_REG8(0x453a), 0x1c },
+ { CCI_REG8(0x453b), 0x1c },
+ { CCI_REG8(0x453c), 0x1c },
+ { CCI_REG8(0x453d), 0x1c },
+ { CCI_REG8(0x453e), 0x1c },
+ { CCI_REG8(0x453f), 0x1c },
+ { CCI_REG8(0x4540), 0x1c },
+ { CCI_REG8(0x4541), 0x03 },
+ { CCI_REG8(0x4542), 0x03 },
+ { CCI_REG8(0x4543), 0x03 },
+ { CCI_REG8(0x4544), 0x03 },
+ { CCI_REG8(0x4545), 0x03 },
+ { CCI_REG8(0x4546), 0x03 },
+ { CCI_REG8(0x4547), 0x03 },
+ { CCI_REG8(0x4548), 0x03 },
+ { CCI_REG8(0x4549), 0x03 },
+ { STARVIS2_REG_WDMODE, 0x00 },
+ { STARVIS2_REG_MDBIT, 0x01 },
+ { STARVIS2_REG_XXS_DRV, 0x00 },
+};
+
+static const u16 imx662_min_hmax_2lane[] = {
+ [STARVIS2_LINK_FREQ_297MHZ] = 1980,
+ [STARVIS2_LINK_FREQ_360MHZ] = 1980,
+ [STARVIS2_LINK_FREQ_445MHZ] = 1188,
+ [STARVIS2_LINK_FREQ_594MHZ] = 990,
+ [STARVIS2_LINK_FREQ_720MHZ] = 990,
+ [STARVIS2_LINK_FREQ_891MHZ] = 990,
+ [STARVIS2_LINK_FREQ_1039MHZ] = 990,
+ [STARVIS2_LINK_FREQ_1188MHZ] = 990,
+};
+
+const struct starvis2_variant imx662_variant_def = {
+ .name = "imx662",
+ .id_reg = CCI_REG16_LE(0x4d1c),
+ .id_mask = 0x3ff,
+ .id_value = 0x296,
+ .native_area = {
+ .top = 0,
+ .left = 0,
+ .width = 1937,
+ .height = 1101,
+ },
+ .active_area = {
+ .top = 0,
+ .left = 0,
+ .width = 1936,
+ .height = 1096,
+ },
+ .pixel_rate = 222750000,
+ .pix_per_clk = 3,
+ .common_regs = imx662_common_regs,
+ .num_common_regs = ARRAY_SIZE(imx662_common_regs),
+ .vmax_default = 1136,
+ .hmax_min_link_freq = imx662_min_hmax_2lane,
+ .hmax_min_pixel_array = 990,
+};
+
struct starvis2_model_info {
enum starvis2_type type;
const u32 *codes;
@@ -691,6 +823,26 @@ static const struct starvis2_model_info imx678_autodetect_info = {
.auto_detect_mono = &imx678_aamr_info,
};
+static const struct starvis2_model_info imx662_aaqr_info = {
+ .type = STARVIS2_COLOR,
+ .codes = codes_bayer,
+ .num_codes = ARRAY_SIZE(codes_bayer),
+ .variant = &imx662_variant_def,
+};
+
+static const struct starvis2_model_info imx662_aamr_info = {
+ .type = STARVIS2_MONOCHROME,
+ .codes = codes_monochrome,
+ .num_codes = ARRAY_SIZE(codes_monochrome),
+ .variant = &imx662_variant_def,
+};
+
+static const struct starvis2_model_info imx662_autodetect_info = {
+ .variant = &imx662_variant_def,
+ .auto_detect_colour = &imx662_aaqr_info,
+ .auto_detect_mono = &imx662_aamr_info,
+};
+
static const char * const starvis2_supply_name[] = {
"avdd", /* Analog (3.3V) supply */
"dvdd", /* Digital Core (1.1V) supply */
@@ -1499,8 +1651,11 @@ static const struct dev_pm_ops starvis2_pm_ops = {
static const struct of_device_id starvis2_of_match[] = {
{ .compatible = "sony,imx678-aamr", .data = &imx678_aamr_info },
{ .compatible = "sony,imx678-aaqr", .data = &imx678_aaqr_info },
+ { .compatible = "sony,imx662-aamr", .data = &imx662_aamr_info },
+ { .compatible = "sony,imx662-aaqr", .data = &imx662_aaqr_info },
/* for non-conforming DTs that rely on runtime check */
{ .compatible = "sony,imx678", .data = &imx678_autodetect_info },
+ { .compatible = "sony,imx662", .data = &imx662_autodetect_info },
{ /* sentinel */ }
};
--
2.34.1
next prev parent reply other threads:[~2026-10-13 15:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 15:16 [PATCH v2 00/13] Update imx678 to act as a common Sony Starvis 2 driver Dave Stevenson
2026-10-13 15:17 ` [PATCH v2 01/13] media: imx678: Rework into generic Starvis 2 sensor driver Dave Stevenson
2026-10-13 15:17 ` [PATCH v2 02/13] media: sony-starvis2: Reorder link frequencies to remove lookup Dave Stevenson
2026-10-13 15:17 ` [PATCH v2 03/13] media: sony-starvis2: Always program the sensor in window mode Dave Stevenson
2026-10-13 15:17 ` [PATCH v2 04/13] media: sony-starvis2: Parameterise the configuration to allow for other models Dave Stevenson
2026-10-13 15:17 ` [PATCH v2 05/13] media: sony-starvis2: Rework 2 lane support for higher link freqs Dave Stevenson
2026-10-13 15:17 ` [PATCH v2 06/13] media: sony-starvis2: Allow runtime control of link frequency Dave Stevenson
2026-10-13 15:17 ` [PATCH v2 07/13] media: sony-starvis2: Correct the minimum exposure Dave Stevenson
2026-10-13 15:17 ` [PATCH v2 08/13] media: dt-bindings: sony,imx678: Add other Starvis 2 family members Dave Stevenson
2026-10-13 15:17 ` Dave Stevenson [this message]
2026-10-13 15:17 ` [PATCH v2 10/13] media: sony-starvis2: Add support for IMX675 Dave Stevenson
2026-10-13 15:17 ` [PATCH v2 11/13] media: sony-starvis2: Add support for IMX832 Dave Stevenson
2026-10-13 15:17 ` [PATCH v2 12/13] media: sony-starvis2: Only update bits for window mode Dave Stevenson
2026-10-13 15:17 ` [PATCH v2 13/13] media: sony-starvis2: Add support for IMX585 Dave Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013-media-starvis2-v2-9-3670722d250a@raspberrypi.com \
--to=dave.stevenson@raspberrypi.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eagle.alexander923@gmail.com \
--cc=jai.luthra@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®