* [PATCH] staging: rtl8723bs: remove unused defines in HalBtcOutSrc.h
@ 2026-10-13 9:01 Wang Yibo
0 siblings, 0 replies; only message in thread
From: Wang Yibo @ 2026-10-13 9:01 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-staging, linux-kernel, Jennifer Guo, Michael Steinmötzger
HalBtcOutSrc.h still defines a number of constants that no code in the
driver ever references. They either describe hardware variants the
RTL8723BS does not support - extra RF paths, dual-MAC/dual-PHY chips,
MIMO power save modes, coupler antennas - or were simply never wired up:
BTC_RF_OFF, BTC_RF_ON, BTC_RF_B, BTC_RF_C, BTC_RF_D
BTC_DMDP, BTC_DMSP, BTC_MP_UNKNOWN
BTC_MIMO_PS_STATIC, BTC_MIMO_PS_DYNAMIC
BTC_RATE_DISABLE, BTC_RATE_ENABLE
BTC_ANT_WIFI_AT_CPL_MAIN, BTC_ANT_WIFI_AT_CPL_AUX
WIFI_HS_CONNECTED, BTC_RSSI_LOW
Only BTC_RF_A is actually used, as the RF path argument of
fBtcSetRfReg(). The "coupler Antenna definition" comment is removed
together with the two defines it documented.
No functional change intended.
Signed-off-by: Wang Yibo <szwyb123@gmail.com>
---
drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h b/drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h
index c2ac06812bff..12ec83758e4b 100644
--- a/drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h
+++ b/drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h
@@ -10,29 +10,14 @@
#define NORMAL_EXEC false
#define FORCE_EXEC true
-#define BTC_RF_OFF 0x0
-#define BTC_RF_ON 0x1
-
#define BTC_RF_A 0x0
-#define BTC_RF_B 0x1
-#define BTC_RF_C 0x2
-#define BTC_RF_D 0x3
#define BTC_SMSP SINGLEMAC_SINGLEPHY
-#define BTC_DMDP DUALMAC_DUALPHY
-#define BTC_DMSP DUALMAC_SINGLEPHY
-#define BTC_MP_UNKNOWN 0xff
#define BT_COEX_ANT_TYPE_PG 0
#define BT_COEX_ANT_TYPE_ANTDIV 1
#define BT_COEX_ANT_TYPE_DETECTED 2
-#define BTC_MIMO_PS_STATIC 0 /* 1ss */
-#define BTC_MIMO_PS_DYNAMIC 1 /* 2ss */
-
-#define BTC_RATE_DISABLE 0
-#define BTC_RATE_ENABLE 1
-
/* single Antenna definition */
#define BTC_ANT_PATH_WIFI 0
#define BTC_ANT_PATH_BT 1
@@ -40,9 +25,6 @@
/* dual Antenna definition */
#define BTC_ANT_WIFI_AT_MAIN 0
#define BTC_ANT_WIFI_AT_AUX 1
-/* coupler Antenna definition */
-#define BTC_ANT_WIFI_AT_CPL_MAIN 0
-#define BTC_ANT_WIFI_AT_CPL_AUX 1
enum {
BTC_PS_WIFI_NATIVE = 0, /* wifi original power save behavior */
@@ -71,7 +53,6 @@ enum btc_chip_interface {
/* following is for wifi link status */
#define WIFI_STA_CONNECTED BIT(0)
#define WIFI_AP_CONNECTED BIT(1)
-#define WIFI_HS_CONNECTED BIT(2)
#define WIFI_P2P_GO_CONNECTED BIT(3)
#define WIFI_P2P_GC_CONNECTED BIT(4)
@@ -94,7 +75,6 @@ enum {
};
#define BTC_RSSI_HIGH(_rssi_) ((_rssi_ == BTC_RSSI_STATE_HIGH || _rssi_ == BTC_RSSI_STATE_STAY_HIGH) ? true : false)
#define BTC_RSSI_MEDIUM(_rssi_) ((_rssi_ == BTC_RSSI_STATE_MEDIUM || _rssi_ == BTC_RSSI_STATE_STAY_MEDIUM) ? true : false)
-#define BTC_RSSI_LOW(_rssi_) ((_rssi_ == BTC_RSSI_STATE_LOW || _rssi_ == BTC_RSSI_STATE_STAY_LOW) ? true : false)
enum {
BTC_WIFI_BW_LEGACY = 0x0,
--
2.25.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-13 9:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-13 9:01 [PATCH] staging: rtl8723bs: remove unused defines in HalBtcOutSrc.h Wang Yibo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®