From: "Darrick J. Wong" <djwong@kernel.org>
To: Carlos Maiolino <cem@kernel.org>
Cc: Siddh Raman Pant <siddh.raman.pant@oracle.com>,
Dave Chinner <dchinner@redhat.com>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] xfs: Fix duplicate assignment in xfs_alloc_read_agf.
Date: Tue, 13 Oct 2026 07:33:53 -0700 [thread overview]
Message-ID: <20261013143353.GB1615495@frogsfrogsfrogs> (raw)
In-Reply-To: <as5AloTkTT3bZkyq@nidhogg.toxiclabs.cc>
On Tue, Oct 13, 2026 at 04:31:04PM +0200, Carlos Maiolino wrote:
> On Thu, Oct 01, 2026 at 08:21:53PM +0530, Siddh Raman Pant wrote:
> > Probably an (harmless) error in copy-paste.
> >
> > Fixes: db6a2274162d ("xfs: catch stale AGF/AGF metadata")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Siddh Raman Pant <siddh.raman.pant@oracle.com>
> > ---
> > Put in stables <= 6.12 after the backport series lands.
>
> Fix the tags accordingly to Darrick's review and re-send please.
Might I suggest this?
https://lore.kernel.org/linux-xfs/179158948300.3720929.2141793283079787803.stgit@frogsfrogsfrogs/
--D
> >
> > fs/xfs/libxfs/xfs_alloc.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
> > index f762dcce8d13..0ffa82400007 100644
> > --- a/fs/xfs/libxfs/xfs_alloc.c
> > +++ b/fs/xfs/libxfs/xfs_alloc.c
> > @@ -3461,7 +3461,6 @@ xfs_alloc_read_agf(
> > if (!xfs_is_shutdown(pag_mount(pag))) {
> > bool ok = true;
> >
> > - ok &= pag->pagf_freeblks == be32_to_cpu(agf->agf_freeblks);
> > ok &= pag->pagf_freeblks == be32_to_cpu(agf->agf_freeblks);
> > ok &= pag->pagf_btreeblks == be32_to_cpu(agf->agf_btreeblks);
> > ok &= pag->pagf_flcount == be32_to_cpu(agf->agf_flcount);
> > --
> > 2.53.0
> >
> >
prev parent reply other threads:[~2026-10-13 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 14:51 Siddh Raman Pant
2026-10-01 14:58 ` Darrick J. Wong
2026-10-13 14:31 ` Carlos Maiolino
2026-10-13 14:33 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013143353.GB1615495@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=siddh.raman.pant@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®