* [PATCH] xfs: Fix duplicate assignment in xfs_alloc_read_agf.
@ 2026-10-01 14:51 Siddh Raman Pant
2026-10-01 14:58 ` Darrick J. Wong
2026-10-13 14:31 ` Carlos Maiolino
0 siblings, 2 replies; 4+ messages in thread
From: Siddh Raman Pant @ 2026-10-01 14:51 UTC (permalink / raw)
To: Darrick J . Wong, Dave Chinner; +Cc: linux-xfs, linux-kernel, stable
Probably an (harmless) error in copy-paste.
Fixes: db6a2274162d ("xfs: catch stale AGF/AGF metadata")
Cc: stable@vger.kernel.org
Signed-off-by: Siddh Raman Pant <siddh.raman.pant@oracle.com>
---
Put in stables <= 6.12 after the backport series lands.
fs/xfs/libxfs/xfs_alloc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index f762dcce8d13..0ffa82400007 100644
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -3461,7 +3461,6 @@ xfs_alloc_read_agf(
if (!xfs_is_shutdown(pag_mount(pag))) {
bool ok = true;
- ok &= pag->pagf_freeblks == be32_to_cpu(agf->agf_freeblks);
ok &= pag->pagf_freeblks == be32_to_cpu(agf->agf_freeblks);
ok &= pag->pagf_btreeblks == be32_to_cpu(agf->agf_btreeblks);
ok &= pag->pagf_flcount == be32_to_cpu(agf->agf_flcount);
--
2.53.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: Fix duplicate assignment in xfs_alloc_read_agf.
2026-10-01 14:51 [PATCH] xfs: Fix duplicate assignment in xfs_alloc_read_agf Siddh Raman Pant
@ 2026-10-01 14:58 ` Darrick J. Wong
2026-10-13 14:31 ` Carlos Maiolino
1 sibling, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2026-10-01 14:58 UTC (permalink / raw)
To: Siddh Raman Pant; +Cc: Dave Chinner, linux-xfs, linux-kernel, stable
On Thu, Oct 01, 2026 at 08:21:53PM +0530, Siddh Raman Pant wrote:
> Probably an (harmless) error in copy-paste.
>
> Fixes: db6a2274162d ("xfs: catch stale AGF/AGF metadata")
> Cc: stable@vger.kernel.org
Cc: <stable@vger.kernel.org> # v6.16
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> Signed-off-by: Siddh Raman Pant <siddh.raman.pant@oracle.com>
> ---
> Put in stables <= 6.12 after the backport series lands.
>
> fs/xfs/libxfs/xfs_alloc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
> index f762dcce8d13..0ffa82400007 100644
> --- a/fs/xfs/libxfs/xfs_alloc.c
> +++ b/fs/xfs/libxfs/xfs_alloc.c
> @@ -3461,7 +3461,6 @@ xfs_alloc_read_agf(
> if (!xfs_is_shutdown(pag_mount(pag))) {
> bool ok = true;
>
> - ok &= pag->pagf_freeblks == be32_to_cpu(agf->agf_freeblks);
> ok &= pag->pagf_freeblks == be32_to_cpu(agf->agf_freeblks);
> ok &= pag->pagf_btreeblks == be32_to_cpu(agf->agf_btreeblks);
> ok &= pag->pagf_flcount == be32_to_cpu(agf->agf_flcount);
> --
> 2.53.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: Fix duplicate assignment in xfs_alloc_read_agf.
2026-10-01 14:51 [PATCH] xfs: Fix duplicate assignment in xfs_alloc_read_agf Siddh Raman Pant
2026-10-01 14:58 ` Darrick J. Wong
@ 2026-10-13 14:31 ` Carlos Maiolino
2026-10-13 14:33 ` Darrick J. Wong
1 sibling, 1 reply; 4+ messages in thread
From: Carlos Maiolino @ 2026-10-13 14:31 UTC (permalink / raw)
To: Siddh Raman Pant
Cc: Darrick J . Wong, Dave Chinner, linux-xfs, linux-kernel, stable
On Thu, Oct 01, 2026 at 08:21:53PM +0530, Siddh Raman Pant wrote:
> Probably an (harmless) error in copy-paste.
>
> Fixes: db6a2274162d ("xfs: catch stale AGF/AGF metadata")
> Cc: stable@vger.kernel.org
> Signed-off-by: Siddh Raman Pant <siddh.raman.pant@oracle.com>
> ---
> Put in stables <= 6.12 after the backport series lands.
Fix the tags accordingly to Darrick's review and re-send please.
>
> fs/xfs/libxfs/xfs_alloc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
> index f762dcce8d13..0ffa82400007 100644
> --- a/fs/xfs/libxfs/xfs_alloc.c
> +++ b/fs/xfs/libxfs/xfs_alloc.c
> @@ -3461,7 +3461,6 @@ xfs_alloc_read_agf(
> if (!xfs_is_shutdown(pag_mount(pag))) {
> bool ok = true;
>
> - ok &= pag->pagf_freeblks == be32_to_cpu(agf->agf_freeblks);
> ok &= pag->pagf_freeblks == be32_to_cpu(agf->agf_freeblks);
> ok &= pag->pagf_btreeblks == be32_to_cpu(agf->agf_btreeblks);
> ok &= pag->pagf_flcount == be32_to_cpu(agf->agf_flcount);
> --
> 2.53.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: Fix duplicate assignment in xfs_alloc_read_agf.
2026-10-13 14:31 ` Carlos Maiolino
@ 2026-10-13 14:33 ` Darrick J. Wong
0 siblings, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2026-10-13 14:33 UTC (permalink / raw)
To: Carlos Maiolino
Cc: Siddh Raman Pant, Dave Chinner, linux-xfs, linux-kernel, stable
On Tue, Oct 13, 2026 at 04:31:04PM +0200, Carlos Maiolino wrote:
> On Thu, Oct 01, 2026 at 08:21:53PM +0530, Siddh Raman Pant wrote:
> > Probably an (harmless) error in copy-paste.
> >
> > Fixes: db6a2274162d ("xfs: catch stale AGF/AGF metadata")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Siddh Raman Pant <siddh.raman.pant@oracle.com>
> > ---
> > Put in stables <= 6.12 after the backport series lands.
>
> Fix the tags accordingly to Darrick's review and re-send please.
Might I suggest this?
https://lore.kernel.org/linux-xfs/179158948300.3720929.2141793283079787803.stgit@frogsfrogsfrogs/
--D
> >
> > fs/xfs/libxfs/xfs_alloc.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
> > index f762dcce8d13..0ffa82400007 100644
> > --- a/fs/xfs/libxfs/xfs_alloc.c
> > +++ b/fs/xfs/libxfs/xfs_alloc.c
> > @@ -3461,7 +3461,6 @@ xfs_alloc_read_agf(
> > if (!xfs_is_shutdown(pag_mount(pag))) {
> > bool ok = true;
> >
> > - ok &= pag->pagf_freeblks == be32_to_cpu(agf->agf_freeblks);
> > ok &= pag->pagf_freeblks == be32_to_cpu(agf->agf_freeblks);
> > ok &= pag->pagf_btreeblks == be32_to_cpu(agf->agf_btreeblks);
> > ok &= pag->pagf_flcount == be32_to_cpu(agf->agf_flcount);
> > --
> > 2.53.0
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-10-13 14:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-01 14:51 [PATCH] xfs: Fix duplicate assignment in xfs_alloc_read_agf Siddh Raman Pant
2026-10-01 14:58 ` Darrick J. Wong
2026-10-13 14:31 ` Carlos Maiolino
2026-10-13 14:33 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®