From: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
To: <broonie@kernel.org>
Cc: <alsa-devel@alsa-project.org>, <lgirdwood@gmail.com>,
<perex@perex.cz>, <tiwai@suse.com>,
<yung-chuan.liao@linux.intel.com>, <Basavaraj.Hiregoudar@amd.com>,
<Sunil-kumar.Dommati@amd.com>, <venkataprasad.potturu@amd.com>,
<Syed.SabaKareem@amd.com>, <Mario.Limonciello@amd.com>,
<Richard.Gong@amd.com>, <Vijendar.Mukunda@amd.com>,
<linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<sound-open-firmware@alsa-project.org>
Subject: [PATCH 2/9] ASoC: SOF: amd: select descriptor per PCI revision in acp7x probe
Date: Tue, 13 Oct 2026 21:11:34 +0530 [thread overview]
Message-ID: <20261013154644.3788064-3-Vijendar.Mukunda@amd.com> (raw)
In-Reply-To: <20261013154644.3788064-1-Vijendar.Mukunda@amd.com>
Add a static acp7f_pci_id entry carrying the acp7f_desc descriptor.
Update acp7x_pci_probe() to check the config flag before the revision
switch and return the per-revision pci_device_id to sof_pci_probe()
rather than passing the table entry.
Remove driver_data from acp7x_pci_ids[] since the descriptor is now
selected in the probe callback.
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
sound/soc/sof/amd/pci-acp7x.c | 21 +++++++++++----------
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/sound/soc/sof/amd/pci-acp7x.c b/sound/soc/sof/amd/pci-acp7x.c
index 5949aefe26bc3..7261377c615b7 100644
--- a/sound/soc/sof/amd/pci-acp7x.c
+++ b/sound/soc/sof/amd/pci-acp7x.c
@@ -68,23 +68,25 @@ static const struct sof_dev_desc acp7f_desc = {
.ops_init = sof_acp7x_ops_init,
};
+static const struct pci_device_id acp7f_pci_id = {
+ PCI_DEVICE(PCI_VENDOR_ID_AMD, ACP_PCI_DEV_ID),
+ .driver_data = (unsigned long)&acp7f_desc,
+};
+
static int acp7x_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id)
{
unsigned int flag;
+ flag = snd_amd_acp_find_config(pci);
+ if (flag != FLAG_AMD_SOF && flag != FLAG_AMD_SOF_ONLY_DMIC)
+ return -ENODEV;
+
switch (pci->revision) {
- case ACP7B_PCI_ID:
case ACP7F_PCI_ID:
- break;
+ return sof_pci_probe(pci, &acp7f_pci_id);
default:
return -ENODEV;
}
-
- flag = snd_amd_acp_find_config(pci);
- if (flag != FLAG_AMD_SOF && flag != FLAG_AMD_SOF_ONLY_DMIC)
- return -ENODEV;
-
- return sof_pci_probe(pci, pci_id);
}
static void acp7x_pci_remove(struct pci_dev *pci)
@@ -94,8 +96,7 @@ static void acp7x_pci_remove(struct pci_dev *pci)
/* PCI IDs */
static const struct pci_device_id acp7x_pci_ids[] = {
- { PCI_DEVICE(PCI_VENDOR_ID_AMD, ACP_PCI_DEV_ID),
- .driver_data = (unsigned long)&acp7f_desc},
+ { PCI_DEVICE(PCI_VENDOR_ID_AMD, ACP_PCI_DEV_ID) },
{ 0, }
};
MODULE_DEVICE_TABLE(pci, acp7x_pci_ids);
--
2.48.1
next prev parent reply other threads:[~2026-10-13 15:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 15:41 [PATCH 0/9] ASoC: SOF/amd: ACP7.B support and ASP carveout firmware loading Vijendar Mukunda
2026-10-13 15:41 ` [PATCH 1/9] ASoC: SOF: amd: rename acp7x machine table and descriptor to acp7f Vijendar Mukunda
2026-10-13 15:41 ` Vijendar Mukunda [this message]
2026-10-13 15:41 ` [PATCH 3/9] ASoC: amd: add I2S machine table for ACP7.B Vijendar Mukunda
2026-10-13 15:41 ` [PATCH 4/9] ASoC: SOF: amd: add ACP7.B chip descriptor and wire per-revision probe Vijendar Mukunda
2026-10-13 15:41 ` [PATCH 5/9] ASoC: SOF: amd: Propagate PCI subsystem Vendor and Device IDs Vijendar Mukunda
2026-10-13 15:41 ` [PATCH 6/9] ASoC: SOF: amd: consolidate local variable declarations Vijendar Mukunda
2026-10-13 15:41 ` [PATCH 7/9] ASoC: amd: acp: add acp-mach-common.h for shared machine driver types Vijendar Mukunda
2026-10-13 15:41 ` [PATCH 8/9] ASoC: SOF: amd: propagate pdm_sel to SDW machine driver via mach->pdata Vijendar Mukunda
2026-10-13 15:41 ` [PATCH 9/9] ASoC: SOF: amd: add ASP carveout firmware loading for ACP7.B/7.F Vijendar Mukunda
2026-10-14 11:44 ` [PATCH 1/2] ASoC: SOF: amd: fix trailing blank line at EOF in acp_asp_mailbox.c Vijendar Mukunda
2026-10-14 11:44 ` [PATCH 2/2] ASoC: amd: acp: move ACP7X_PDM_DMIC0/1 to acp-mach-common.h Vijendar Mukunda
2026-10-13 19:09 ` [PATCH 0/9] ASoC: SOF/amd: ACP7.B support and ASP carveout firmware loading Mark Brown
2026-10-15 12:00 ` Mukunda,Vijendar
2026-10-15 22:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013154644.3788064-3-Vijendar.Mukunda@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Richard.Gong@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Syed.SabaKareem@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®