From: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
To: <broonie@kernel.org>
Cc: <alsa-devel@alsa-project.org>, <lgirdwood@gmail.com>,
<perex@perex.cz>, <tiwai@suse.com>,
<yung-chuan.liao@linux.intel.com>, <Basavaraj.Hiregoudar@amd.com>,
<Sunil-kumar.Dommati@amd.com>, <venkataprasad.potturu@amd.com>,
<Syed.SabaKareem@amd.com>, <Mario.Limonciello@amd.com>,
<Richard.Gong@amd.com>, <Vijendar.Mukunda@amd.com>,
<linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<sound-open-firmware@alsa-project.org>
Subject: [PATCH 6/9] ASoC: SOF: amd: consolidate local variable declarations
Date: Tue, 13 Oct 2026 21:11:38 +0530 [thread overview]
Message-ID: <20261013154644.3788064-7-Vijendar.Mukunda@amd.com> (raw)
In-Reply-To: <20261013154644.3788064-1-Vijendar.Mukunda@amd.com>
Use u32 instead of unsigned int for hardware register variables and
combine related declarations onto single lines in
sof_amd_check_and_handle_acp7x_sdw_wake_irq() and
handle_amd_sof_acp7x_sdw_pme_event().
No functional change.
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
sound/soc/sof/amd/acp.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c
index 71c39eb36194e..790af65be34a2 100644
--- a/sound/soc/sof/amd/acp.c
+++ b/sound/soc/sof/amd/acp.c
@@ -674,9 +674,8 @@ static int sof_amd_check_and_handle_acp7x_sdw_wake_irq(struct snd_sof_dev *sdev)
{
struct acp_dev_data *adata = sdev->pdata->hw_pdata;
const struct sof_amd_acp_desc *desc = get_chip_info(sdev->pdata);
- unsigned int ext_intr_stat1;
- unsigned int sdw_pme_stat, sdw_wake_en;
- unsigned int i;
+ u32 ext_intr_stat1, sdw_pme_stat, sdw_wake_en;
+ u32 i;
bool sdw_wake_irq = false;
ext_intr_stat1 = snd_sof_dsp_read(sdev, ACP_DSP_BAR, desc->ext_intr_stat1);
@@ -1445,10 +1444,7 @@ static void handle_amd_sof_acp7x_sdw_pme_event(struct snd_sof_dev *sdev)
{
struct acp_dev_data *adata;
struct amd_sdw_manager *amd_manager;
- u32 sdw_pme_stat;
- u32 sdw_wake_en;
- u32 pme_reg;
- u32 wake_mask;
+ u32 sdw_pme_stat, sdw_wake_en, pme_reg, wake_mask;
unsigned int instance;
adata = sdev->pdata->hw_pdata;
--
2.48.1
next prev parent reply other threads:[~2026-10-13 15:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 15:41 [PATCH 0/9] ASoC: SOF/amd: ACP7.B support and ASP carveout firmware loading Vijendar Mukunda
2026-10-13 15:41 ` [PATCH 1/9] ASoC: SOF: amd: rename acp7x machine table and descriptor to acp7f Vijendar Mukunda
2026-10-13 15:41 ` [PATCH 2/9] ASoC: SOF: amd: select descriptor per PCI revision in acp7x probe Vijendar Mukunda
2026-10-13 15:41 ` [PATCH 3/9] ASoC: amd: add I2S machine table for ACP7.B Vijendar Mukunda
2026-10-13 15:41 ` [PATCH 4/9] ASoC: SOF: amd: add ACP7.B chip descriptor and wire per-revision probe Vijendar Mukunda
2026-10-13 15:41 ` [PATCH 5/9] ASoC: SOF: amd: Propagate PCI subsystem Vendor and Device IDs Vijendar Mukunda
2026-10-13 15:41 ` Vijendar Mukunda [this message]
2026-10-13 15:41 ` [PATCH 7/9] ASoC: amd: acp: add acp-mach-common.h for shared machine driver types Vijendar Mukunda
2026-10-13 15:41 ` [PATCH 8/9] ASoC: SOF: amd: propagate pdm_sel to SDW machine driver via mach->pdata Vijendar Mukunda
2026-10-13 15:41 ` [PATCH 9/9] ASoC: SOF: amd: add ASP carveout firmware loading for ACP7.B/7.F Vijendar Mukunda
2026-10-14 11:44 ` [PATCH 1/2] ASoC: SOF: amd: fix trailing blank line at EOF in acp_asp_mailbox.c Vijendar Mukunda
2026-10-14 11:44 ` [PATCH 2/2] ASoC: amd: acp: move ACP7X_PDM_DMIC0/1 to acp-mach-common.h Vijendar Mukunda
2026-10-13 19:09 ` [PATCH 0/9] ASoC: SOF/amd: ACP7.B support and ASP carveout firmware loading Mark Brown
2026-10-15 12:00 ` Mukunda,Vijendar
2026-10-15 22:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013154644.3788064-7-Vijendar.Mukunda@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Richard.Gong@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Syed.SabaKareem@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®