From: Greg KH <greg@kroah.com>
To: vienna-0FFH <viennaoffh@gmail.com>
Cc: Alexander Aring <aahringo@redhat.com>,
David Teigland <teigland@redhat.com>,
gfs2@lists.linux.dev, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
syzbot+04dfbd15d442517e713a@syzkaller.appspotmail.com
Subject: Re: [PATCH] dlm: don't warn when closing a node without a connection
Date: Wed, 14 Oct 2026 13:49:10 +0200 [thread overview]
Message-ID: <2026101400-roman-landmass-d03e@gregkh> (raw)
In-Reply-To: <20261014090237.395-1-viennaoffh@gmail.com>
On Wed, Oct 14, 2026 at 05:02:37PM +0800, vienna-0FFH wrote:
> Opening and closing a configfs comm entry without ever configuring an
> address for it triggers the following warning:
>
> mkdir /sys/kernel/config/dlm/cluster
> mkdir /sys/kernel/config/dlm/cluster/comms/1
> rmdir /sys/kernel/config/dlm/cluster/comms/1
>
> dlm: closing connection to node 1
> ------------[ cut here ]------------
> !con
> WARNING: fs/dlm/lowcomms.c:1455 at dlm_lowcomms_close+0x12d/0x470, CPU#1
>
> Since commit 6f0b0b5d7ae7 ("fs: dlm: remove dlm_node_addrs lookup list")
> the lowcomms connection has the same lifetime as the configfs comm
> entry, but a connection is only created when an address is configured
> via the addr attribute. Removing a comm entry for which no address was
> ever set up is valid and the resulting close call has simply nothing
> to do, so it must not warn.
>
> Reported-by: syzbot+04dfbd15d442517e713a@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=04dfbd15d442517e713a
> Fixes: 6f0b0b5d7ae7 ("fs: dlm: remove dlm_node_addrs lookup list")
> Cc: stable@vger.kernel.org
> Signed-off-by: vienna-0FFH <viennaoffh@gmail.com>
Real name is needed please.
thanks,
greg k-h
prev parent reply other threads:[~2026-10-14 11:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 9:02 vienna-0FFH
2026-10-14 11:49 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026101400-roman-landmass-d03e@gregkh \
--to=greg@kroah.com \
--cc=aahringo@redhat.com \
--cc=gfs2@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+04dfbd15d442517e713a@syzkaller.appspotmail.com \
--cc=teigland@redhat.com \
--cc=viennaoffh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®