Re: [PATCH v8 4/4] cxl/memdev: Don't overwrite the error from an earlier partition poison query

[Davidlohr Bueso <dave@stgolabs.net>]

On Tue, 22 Sep 2026, Richard Cheng wrote:

>cxl_get_poison_by_memdev() queries Get Poison List per partition but
>never checks the result inside the loop, so a later partition's success
>overwrites an earlier partition's failure and the whole scan reports
>success while that partition's poison went unlisted. Before the loop
>conversion the PMEM query returned early on error. Stop the loop on any
>error not already tolerated as a RAM -EFAULT.
>
>Fixes: be5cbd084027 ("cxl: Kill enum cxl_decoder_mode")
>Reviewed-by: Dave Jiang <dave.jiang@intel.com>
>Reviewed-by: Alison Schofield <alison.schofield@intel.com>
>Reviewed-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
>Closes: https://sashiko.dev/#/patchset/20260708074228.43654-1-icheng@nvidia.com?part=5
>Signed-off-by: Richard Cheng <icheng@nvidia.com>

Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>

... with a nit below.

>---
> drivers/cxl/core/memdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
>index b3419df586b9..e39b3d13fd56 100644
>--- a/drivers/cxl/core/memdev.c
>+++ b/drivers/cxl/core/memdev.c
>@@ -231,6 +231,8 @@ static int cxl_get_poison_by_memdev(struct cxl_memdev *cxlmd)
> 		 */
> 		if (rc == -EFAULT && cxlds->part[i].mode == CXL_PARTMODE_RAM)

This wants poison_efault_forgiven() - maybe move out of region.c into core.h?

> 			rc = 0;
>+		if (rc)
>+			break;
> 	}
> 	return rc;
> }
>-- 
>2.43.0
>