mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: Richard Cheng <icheng@nvidia.com>
Cc: jic23@kernel.org, dave.jiang@intel.com,
	alison.schofield@intel.com, vishal.l.verma@intel.com,
	iweiny@kernel.org, ming.li@zohomail.com, kaihengf@nvidia.com,
	kobak@nvidia.com, newtonl@nvidia.com, kristinc@nvidia.com,
	linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
Subject: Re: [PATCH v8 3/4] cxl/region: Start unmapped poison scan at the committed decoder boundary
Date: Tue, 13 Oct 2026 18:57:38 -0700	[thread overview]
Message-ID: <20261014015738.eelvhtdm3nzh3jh3@offworld> (raw)
In-Reply-To: <20260922101129.52794-4-icheng@nvidia.com>

On Tue, 22 Sep 2026, Richard Cheng wrote:

>poison_by_decoder() stops at the last committed decoder and records the
>handoff in ctx->offset, but cxl_get_poison_unmapped() ignores it and
>starts after the highest DPA allocation instead. Allocation exist for
>uncommitted decoders too, so their DPA is skipped by both phases and
>poison there is never reported. Resume the scan at ctx->offset, and scan
>later partitions in full, restoring the pre-rewrite behavior.
>
>Fixes: be5cbd084027 ("cxl: Kill enum cxl_decoder_mode")
>Reviewed-by: Dave Jiang <dave.jiang@intel.com>
>Reviewed-by: Alison Schofield <alison.schofield@intel.com>
>Reviewed-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
>Signed-off-by: Richard Cheng <icheng@nvidia.com>

Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>

>---
> drivers/cxl/core/region.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
>index 042356c71ed7..4869cdd6a3d4 100644
>--- a/drivers/cxl/core/region.c
>+++ b/drivers/cxl/core/region.c
>@@ -2931,7 +2931,6 @@ static int cxl_get_poison_unmapped(struct cxl_memdev *cxlmd,
> {
> 	struct cxl_dev_state *cxlds = cxlmd->cxlds;
> 	const struct resource *res;
>-	struct resource *p, *last;
> 	u64 offset, length;
> 	int rc = 0;
>
>@@ -2944,10 +2943,8 @@ static int cxl_get_poison_unmapped(struct cxl_memdev *cxlmd,
> 	 */
> 	for (int i = ctx->part; i < cxlds->nr_partitions; i++) {
> 		res = &cxlds->part[i].res;
>-		for (p = res->child, last = NULL; p; p = p->sibling)
>-			last = p;
>-		if (last)
>-			offset = last->end + 1;
>+		if (i == ctx->part)
>+			offset = ctx->offset;
> 		else
> 			offset = res->start;
> 		length = res->end - offset + 1;
>-- 
>2.43.0
>

  reply	other threads:[~2026-10-14  1:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 10:11 [PATCH v8 0/4] cxl: Repair poison enumeration regressions Richard Cheng
2026-09-22 10:11 ` [PATCH v8 1/4] cxl/region: Scan all partitions for unmapped poison Richard Cheng
2026-10-14  1:02   ` Davidlohr Bueso
2026-09-22 10:11 ` [PATCH v8 2/4] cxl/region: Don't leak tolerated RAM -EFAULT from unmapped poison scan Richard Cheng
2026-09-25 23:18   ` Jonathan Cameron
2026-10-14  0:51   ` Davidlohr Bueso
2026-09-22 10:11 ` [PATCH v8 3/4] cxl/region: Start unmapped poison scan at the committed decoder boundary Richard Cheng
2026-10-14  1:57   ` Davidlohr Bueso [this message]
2026-09-22 10:11 ` [PATCH v8 4/4] cxl/memdev: Don't overwrite the error from an earlier partition poison query Richard Cheng
2026-10-14  1:13   ` Davidlohr Bueso
2026-10-14 15:30 ` [PATCH v8 0/4] cxl: Repair poison enumeration regressions Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261014015738.eelvhtdm3nzh3jh3@offworld \
    --to=dave@stgolabs.net \
    --cc=alison.schofield@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=icheng@nvidia.com \
    --cc=iweiny@kernel.org \
    --cc=jic23@kernel.org \
    --cc=jonathan.cameron@oss.qualcomm.com \
    --cc=kaihengf@nvidia.com \
    --cc=kobak@nvidia.com \
    --cc=kristinc@nvidia.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.li@zohomail.com \
    --cc=newtonl@nvidia.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®