Re: [PATCH v7 4/5] alpha: decode and acknowledge Tsunami system machine checks

[Matt Turner <mattst88@gmail.com>]

On Tue, Oct 13, 2026 at 23:15 +0200, Magnus Lindholm wrote:
> +	/*
> +	 * Table 10-42 selects the ECC fields whenever CRE or UECC is set.
> +	 * Mixed ECC/PCI bits do not establish which error occurred first.
> +	 */

10.2.5.6 says the register freezes on the first error and only LOST
can be set afterwards. So mixed bits were detected together, and
ordering does not come into it.

> +	/* HRM 10.2.5.7: PERRMASK gates latching, not just notification. */
> +
> +	/* Preserve each chip's transaction and the NXM source before clearing. */

The first comment is not attached to any code, and the changelog
already makes the point. I would drop it.

Table 10-43 gives the PERRMASK reset value as 0, all errors disabled,
and Linux never writes it, so all of the PERROR handling here depends
on what SRM programs. What does PERRMASK read on your ES40?

> +	draina();
> +	tsunami_clear_errors(&live);

10.2.5.6 warns that PERROR read before the error reaches DRIR can
come back with INV set. On a 670 or 630 that races with a new Pchip
error we would acknowledge it with INV set and lose the transaction,
along with the 660 that would have reported it. I would leave the
Pchips alone outside 660/620.

Reviewed-by: Matt Turner <mattst88@gmail.com>