From: Sahaj Chaudhari <sahaj123.sc@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Sahaj Chaudhari <sahaj123.sc@gmail.com>
Subject: Re: [PATCH] spi: omap2-mcspi: handle DMA setup failures
Date: Wed, 14 Oct 2026 10:26:27 +0530 [thread overview]
Message-ID: <20261014045627.2895305-1-sahaj123.sc@gmail.com> (raw)
In-Reply-To: <4a20222b-7d60-4763-9833-bc453d26ade8@sirena.org.uk>
On Tue, Oct 13, 2026 at 04:40:00PM +0100, Mark Brown wrote:
> Do we need to turn off the FIFO here before doing PIO?
Yes, good catch. omap2_mcspi_set_fifo(spi, t, 1) runs before the DMA
attempt, and omap2_mcspi_txrx_pio() polls per-word TXS/RXS without
expecting FIFO mode. v2 disables the FIFO, with the channel off while
its bits change, before falling back.
I injected DMA setup failures on an AM642 with and without this change,
and the PIO fallback completed with no errors or timeouts in both cases.
The bus had no device attached, so that test does not show the FIFO
problem. The change is based on reading the code and not on a
reproduced failure. I have said so in the v2 commit message.
v2: https://lore.kernel.org/r/20261014045617.2894886-1-sahaj123.sc@gmail.com
prev parent reply other threads:[~2026-10-14 4:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 14:20 Sahaj Chaudhari
2026-10-13 15:40 ` Mark Brown
2026-10-14 4:56 ` Sahaj Chaudhari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261014045627.2895305-1-sahaj123.sc@gmail.com \
--to=sahaj123.sc@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®