* [PATCH v1 1/1 RESEND] leds: Add driver for MAX8907 LED cell
2026-10-14 12:12 [PATCH v1 0/1 RESEND] leds: Add driver for MAX8907 LED cell Svyatoslav Ryhel
@ 2026-10-14 12:12 ` Svyatoslav Ryhel
0 siblings, 0 replies; 2+ messages in thread
From: Svyatoslav Ryhel @ 2026-10-14 12:12 UTC (permalink / raw)
To: Lee Jones, Pavel Machek, Svyatoslav Ryhel; +Cc: linux-kernel, linux-leds, mfd
Add a small driver to control the LED cell provided by the MAX8907 PMIC.
The LED does not require any specific configuration and is folded into the
PMIC's node.
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
drivers/leds/Kconfig | 7 ++++
drivers/leds/Makefile | 1 +
drivers/leds/leds-max8907.c | 81 +++++++++++++++++++++++++++++++++++++
drivers/mfd/max8907.c | 1 +
include/linux/mfd/max8907.h | 2 +-
5 files changed, 91 insertions(+), 1 deletion(-)
create mode 100644 drivers/leds/leds-max8907.c
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 59445bbf2140a..ff00ecf5d858d 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -813,6 +813,13 @@ config LEDS_MAX77705
help
LED driver for MAX77705 PMIC from Maxim Integrated.
+config LEDS_MAX8907
+ tristate "LED support for MAX8907 PMIC"
+ depends on LEDS_CLASS && MFD_MAX8907
+ help
+ This option enables support for on-chip LED drivers on
+ MAXIM MAX8907 PMIC.
+
config LEDS_MAX8997
tristate "LED support for MAX8997 PMIC"
depends on LEDS_CLASS && MFD_MAX8997
diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
index ed3fbf2aa2d2d..b9e815b2416d2 100644
--- a/drivers/leds/Makefile
+++ b/drivers/leds/Makefile
@@ -66,6 +66,7 @@ obj-$(CONFIG_LEDS_LTC3220) += leds-ltc3220.o
obj-$(CONFIG_LEDS_MAX5970) += leds-max5970.o
obj-$(CONFIG_LEDS_MAX77650) += leds-max77650.o
obj-$(CONFIG_LEDS_MAX77705) += leds-max77705.o
+obj-$(CONFIG_LEDS_MAX8907) += leds-max8907.o
obj-$(CONFIG_LEDS_MAX8997) += leds-max8997.o
obj-$(CONFIG_LEDS_MC13783) += leds-mc13783.o
obj-$(CONFIG_LEDS_MENF21BMC) += leds-menf21bmc.o
diff --git a/drivers/leds/leds-max8907.c b/drivers/leds/leds-max8907.c
new file mode 100644
index 0000000000000..358505a1c799f
--- /dev/null
+++ b/drivers/leds/leds-max8907.c
@@ -0,0 +1,81 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+#include <linux/err.h>
+#include <linux/leds.h>
+#include <linux/mfd/max8907.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+
+struct max8907_led_data {
+ struct max8907 *max8907;
+ struct regmap *regmap;
+ struct led_classdev cdev;
+};
+
+static enum led_brightness max8907_led_get_brightness(struct led_classdev *cdev)
+{
+ struct max8907_led_data *ddata = container_of(cdev, struct max8907_led_data, cdev);
+ unsigned int brightness_lvl;
+ int ret;
+
+ ret = regmap_read(ddata->regmap, MAX8907_REG_WLED_CNTL, &brightness_lvl);
+ if (ret)
+ return LED_OFF;
+
+ return brightness_lvl;
+}
+
+static int max8907_led_set_brightness(struct led_classdev *cdev,
+ enum led_brightness brightness)
+{
+ struct max8907_led_data *ddata = container_of(cdev, struct max8907_led_data, cdev);
+ int brightness_lvl, ret;
+
+ brightness_lvl = clamp(brightness, LED_OFF, LED_FULL);
+
+ if (brightness_lvl) {
+ ret = regmap_write(ddata->regmap, MAX8907_REG_WLED_CNTL, brightness_lvl);
+ if (ret)
+ return ret;
+ }
+
+ return regmap_update_bits(ddata->regmap, MAX8907_REG_WLED_MODE_CNTL,
+ LED_ON, brightness_lvl ? LED_ON : LED_OFF);
+}
+
+static int max8907_led_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ struct max8907 *max8907 = dev_get_drvdata(dev->parent);
+ struct max8907_led_data *ddata;
+
+ ddata = devm_kzalloc(dev, sizeof(*ddata), GFP_KERNEL);
+ if (!ddata)
+ return -ENOMEM;
+
+ ddata->max8907 = max8907;
+ ddata->regmap = max8907->regmap_gen;
+
+ platform_set_drvdata(pdev, ddata);
+
+ ddata->cdev.brightness = LED_OFF;
+ ddata->cdev.flags = LED_CORE_SUSPENDRESUME;
+ ddata->cdev.max_brightness = LED_FULL;
+ ddata->cdev.name = dev_name(dev);
+
+ ddata->cdev.brightness_get = max8907_led_get_brightness;
+ ddata->cdev.brightness_set_blocking = max8907_led_set_brightness;
+
+ return devm_led_classdev_register(dev->parent, &ddata->cdev);
+}
+
+static struct platform_driver max8907_led_driver = {
+ .driver.name = "max8907-leds",
+ .probe = max8907_led_probe,
+};
+module_platform_driver(max8907_led_driver);
+
+MODULE_AUTHOR("Svyatolsav Ryhel <clamor95@gmail.com>");
+MODULE_DESCRIPTION("MAX8907 LED driver");
+MODULE_LICENSE("GPL");
diff --git a/drivers/mfd/max8907.c b/drivers/mfd/max8907.c
index a8cb2071aa7f4..b4562ec0ce18f 100644
--- a/drivers/mfd/max8907.c
+++ b/drivers/mfd/max8907.c
@@ -21,6 +21,7 @@
static const struct mfd_cell max8907_cells[] = {
{ .name = "max8907-adc", },
+ { .name = "max8907-leds", },
{ .name = "max8907-regulator", },
{ .name = "max8907-rtc", },
};
diff --git a/include/linux/mfd/max8907.h b/include/linux/mfd/max8907.h
index d960dfdd808ba..15901a1b07424 100644
--- a/include/linux/mfd/max8907.h
+++ b/include/linux/mfd/max8907.h
@@ -112,7 +112,7 @@
#define MAX8907_REG_CHG_IRQ2_MASK 0x81
#define MAX8907_REG_CHG_STAT 0x82
#define MAX8907_REG_WLED_MODE_CNTL 0x84
-#define MAX8907_REG_ILED_CNTL 0x84
+#define MAX8907_REG_WLED_CNTL 0x85
#define MAX8907_REG_II1RR 0x8E
#define MAX8907_REG_II2RR 0x8F
#define MAX8907_REG_LDOCTL20 0x9C
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread