* [PATCH v3] staging: greybus: Remove unused header declaration to_fw_mgmt_connection [not found] <20261015020731.98150-1-deaner92.ref@yahoo.com> @ 2026-10-15 2:07 ` Jeremy Dean Clifton 2026-10-15 12:19 ` Alex Elder 0 siblings, 1 reply; 2+ messages in thread From: Jeremy Dean Clifton @ 2026-10-15 2:07 UTC (permalink / raw) To: Viresh Kumar, Johan Hovold, Alex Elder, Greg Kroah-Hartman Cc: outreachy, Jeremy Dean Clifton, greybus-dev, linux-staging, linux-kernel Commit 3228900f80c2 ("staging: greybus: Remove unused function 'to_fw_mgmt_connection'") removed a function definition but did not remove the function prototype. Remove the prototype. Signed-off-by: Jeremy Dean Clifton <deaner92@yahoo.com> --- v3: Change to imperative mood and write in proper English (Julia Lawall). v2: Fix grammar and spelling in commit message. drivers/staging/greybus/firmware.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/firmware.h b/drivers/staging/greybus/firmware.h index 5d2564462ffc..04a67d2d5b8f 100644 --- a/drivers/staging/greybus/firmware.h +++ b/drivers/staging/greybus/firmware.h @@ -22,7 +22,6 @@ /* Firmware Management Protocol specific functions */ int fw_mgmt_init(void); void fw_mgmt_exit(void); -struct gb_connection *to_fw_mgmt_connection(struct device *dev); int gb_fw_mgmt_request_handler(struct gb_operation *op); int gb_fw_mgmt_connection_init(struct gb_connection *connection); void gb_fw_mgmt_connection_exit(struct gb_connection *connection); -- 2.43.0 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3] staging: greybus: Remove unused header declaration to_fw_mgmt_connection 2026-10-15 2:07 ` [PATCH v3] staging: greybus: Remove unused header declaration to_fw_mgmt_connection Jeremy Dean Clifton @ 2026-10-15 12:19 ` Alex Elder 0 siblings, 0 replies; 2+ messages in thread From: Alex Elder @ 2026-10-15 12:19 UTC (permalink / raw) To: Jeremy Dean Clifton, Viresh Kumar, Johan Hovold, Alex Elder, Greg Kroah-Hartman Cc: outreachy, greybus-dev, linux-staging, linux-kernel On 10/14/26 9:07 PM, Jeremy Dean Clifton wrote: > Commit 3228900f80c2 ("staging: greybus: Remove unused function > 'to_fw_mgmt_connection'") removed a function definition but did not > remove the function prototype. > > Remove the prototype. > > Signed-off-by: Jeremy Dean Clifton <deaner92@yahoo.com> This could maybe have a "fixes" but if it gets accepted soon I don't think it will matter, because this will land in the same release as the fixed commit. This looks good. Reviewed-by: Alex Elder <elder@riscstar.com> > --- > v3: Change to imperative mood and write in proper English (Julia > Lawall). > v2: Fix grammar and spelling in commit message. > > drivers/staging/greybus/firmware.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/greybus/firmware.h b/drivers/staging/greybus/firmware.h > index 5d2564462ffc..04a67d2d5b8f 100644 > --- a/drivers/staging/greybus/firmware.h > +++ b/drivers/staging/greybus/firmware.h > @@ -22,7 +22,6 @@ > /* Firmware Management Protocol specific functions */ > int fw_mgmt_init(void); > void fw_mgmt_exit(void); > -struct gb_connection *to_fw_mgmt_connection(struct device *dev); > int gb_fw_mgmt_request_handler(struct gb_operation *op); > int gb_fw_mgmt_connection_init(struct gb_connection *connection); > void gb_fw_mgmt_connection_exit(struct gb_connection *connection); ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-15 12:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20261015020731.98150-1-deaner92.ref@yahoo.com>
2026-10-15 2:07 ` [PATCH v3] staging: greybus: Remove unused header declaration to_fw_mgmt_connection Jeremy Dean Clifton
2026-10-15 12:19 ` Alex Elder
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®