mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] iommu/hyperv: Fix guest IOMMU build issues
@ 2026-10-15  8:23 Yu Zhang
  2026-10-15  8:23 ` [PATCH 1/2] iommu/hyperv: Add missing PCI dependency for the guest IOMMU driver Yu Zhang
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Yu Zhang @ 2026-10-15  8:23 UTC (permalink / raw)
  To: joro
  Cc: iommu, linux-hyperv, linux-kernel, lkp, oe-kbuild-all,
	joerg.roedel, jgg, will, robin.murphy, mhklinux, wei.liu,
	jacob.pan, easwar.hariharan

This series address two issues reported by kernel test robot in the
recently applied Hyper-V guest IOMMU driver.
                                                                                                                                                        
The first one adds the missing PCI dependency to prevent a link failure
when CONFIG_PCI is disabled. And the second makes hv_iommu_device static
to address a sparse warning.

The patches are based on the hyper-v branch of the IOMMU tree.

Yu Zhang (2):
  iommu/hyperv: Add missing PCI dependency for the guest IOMMU driver
  iommu/hyperv: Make hv_iommu_device static

 drivers/iommu/hyperv/Kconfig          | 2 +-
 drivers/iommu/hyperv/hv-iommu-guest.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.52.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] iommu/hyperv: Add missing PCI dependency for the guest IOMMU driver
  2026-10-15  8:23 [PATCH 0/2] iommu/hyperv: Fix guest IOMMU build issues Yu Zhang
@ 2026-10-15  8:23 ` Yu Zhang
  2026-10-15  8:23 ` [PATCH 2/2] iommu/hyperv: Make hv_iommu_device static Yu Zhang
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Yu Zhang @ 2026-10-15  8:23 UTC (permalink / raw)
  To: joro
  Cc: iommu, linux-hyperv, linux-kernel, lkp, oe-kbuild-all,
	joerg.roedel, jgg, will, robin.murphy, mhklinux, wei.liu,
	jacob.pan, easwar.hariharan

Make HYPERV_PVIOMMU depend on PCI, to fix the possible link failure
of pci_request_acs(), if HYPERV_PVIOMMU is enabled yet with PCI disabled. 
Such configuration shall be prevented.

Fixes: 2690d4156b51 ("iommu/hyperv: Add para-virtualized IOMMU support for Hyper-V guest")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202610110511.Nk1sZ8SG-lkp@intel.com/
Signed-off-by: Yu Zhang <zhangyu1@linux.microsoft.com>
---
 drivers/iommu/hyperv/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/hyperv/Kconfig b/drivers/iommu/hyperv/Kconfig
index fe24ed65b6a7..f2f993f647c3 100644
--- a/drivers/iommu/hyperv/Kconfig
+++ b/drivers/iommu/hyperv/Kconfig
@@ -2,7 +2,7 @@
 # Hyper-V para-virtualized IOMMU driver for Linux guests
 config HYPERV_PVIOMMU
 	bool "Microsoft Hyper-V para-virtualized IOMMU driver for Linux guests"
-	depends on X86_64 && HYPERV
+	depends on X86_64 && HYPERV && PCI
 	select IOMMU_DMA
 	select GENERIC_PT
 	select IOMMU_PT
-- 
2.52.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/2] iommu/hyperv: Make hv_iommu_device static
  2026-10-15  8:23 [PATCH 0/2] iommu/hyperv: Fix guest IOMMU build issues Yu Zhang
  2026-10-15  8:23 ` [PATCH 1/2] iommu/hyperv: Add missing PCI dependency for the guest IOMMU driver Yu Zhang
@ 2026-10-15  8:23 ` Yu Zhang
  2026-10-15 12:36 ` [PATCH 0/2] iommu/hyperv: Fix guest IOMMU build issues Jason Gunthorpe
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Yu Zhang @ 2026-10-15  8:23 UTC (permalink / raw)
  To: joro
  Cc: iommu, linux-hyperv, linux-kernel, lkp, oe-kbuild-all,
	joerg.roedel, jgg, will, robin.murphy, mhklinux, wei.liu,
	jacob.pan, easwar.hariharan

Make hv_iommu_device static to give it internal linkage. This
pointer is only used within hv-iommu-guest.c, but previously
has external linkage without a prior declaration. This causes
sparse to warn that the symbol was not declared.

Fixes: 2690d4156b51 ("iommu/hyperv: Add para-virtualized IOMMU support for Hyper-V guest")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202610092126.TuSXnTYR-lkp@intel.com/
Signed-off-by: Yu Zhang <zhangyu1@linux.microsoft.com>
---
 drivers/iommu/hyperv/hv-iommu-guest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/hyperv/hv-iommu-guest.c b/drivers/iommu/hyperv/hv-iommu-guest.c
index fe06bd970621..876a22f21f1e 100644
--- a/drivers/iommu/hyperv/hv-iommu-guest.c
+++ b/drivers/iommu/hyperv/hv-iommu-guest.c
@@ -22,7 +22,7 @@
 #include "iommu.h"
 #include "../iommu-pages.h"
 
-struct hv_iommu_dev *hv_iommu_device;
+static struct hv_iommu_dev *hv_iommu_device;
 
 /*
  * Identity and blocking domains are static singletons: identity is a 1:1
-- 
2.52.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] iommu/hyperv: Fix guest IOMMU build issues
  2026-10-15  8:23 [PATCH 0/2] iommu/hyperv: Fix guest IOMMU build issues Yu Zhang
  2026-10-15  8:23 ` [PATCH 1/2] iommu/hyperv: Add missing PCI dependency for the guest IOMMU driver Yu Zhang
  2026-10-15  8:23 ` [PATCH 2/2] iommu/hyperv: Make hv_iommu_device static Yu Zhang
@ 2026-10-15 12:36 ` Jason Gunthorpe
  2026-10-15 15:29 ` Jacob Pan
  2026-10-15 15:52 ` Jörg Rödel
  4 siblings, 0 replies; 6+ messages in thread
From: Jason Gunthorpe @ 2026-10-15 12:36 UTC (permalink / raw)
  To: Yu Zhang
  Cc: joro, iommu, linux-hyperv, linux-kernel, lkp, oe-kbuild-all,
	joerg.roedel, jgg, will, robin.murphy, mhklinux, wei.liu,
	jacob.pan, easwar.hariharan

On Thu, 15 Oct 2026 16:23:49 +0800, Yu Zhang <zhangyu1@linux.microsoft.com> wrote:
> iommu/hyperv: Fix guest IOMMU build issues
> 
> This series address two issues reported by kernel test robot in the
> recently applied Hyper-V guest IOMMU driver.
> 
> The first one adds the missing PCI dependency to prevent a link failure
> when CONFIG_PCI is disabled. And the second makes hv_iommu_device static
> to address a sparse warning.
> 
> [...]

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

-- 
Jason

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] iommu/hyperv: Fix guest IOMMU build issues
  2026-10-15  8:23 [PATCH 0/2] iommu/hyperv: Fix guest IOMMU build issues Yu Zhang
                   ` (2 preceding siblings ...)
  2026-10-15 12:36 ` [PATCH 0/2] iommu/hyperv: Fix guest IOMMU build issues Jason Gunthorpe
@ 2026-10-15 15:29 ` Jacob Pan
  2026-10-15 15:52 ` Jörg Rödel
  4 siblings, 0 replies; 6+ messages in thread
From: Jacob Pan @ 2026-10-15 15:29 UTC (permalink / raw)
  To: Yu Zhang
  Cc: joro, iommu, linux-hyperv, linux-kernel, lkp, oe-kbuild-all,
	joerg.roedel, jgg, will, robin.murphy, mhklinux, wei.liu,
	easwar.hariharan, jacob.pan

Hi Yu,

On Thu, 15 Oct 2026 16:23:49 +0800
Yu Zhang <zhangyu1@linux.microsoft.com> wrote:

> This series address two issues reported by kernel test robot in the
> recently applied Hyper-V guest IOMMU driver.
>                                                                                                                                                         
> The first one adds the missing PCI dependency to prevent a link
> failure when CONFIG_PCI is disabled. And the second makes
> hv_iommu_device static to address a sparse warning.
> 
> The patches are based on the hyper-v branch of the IOMMU tree.
> 
> Yu Zhang (2):
>   iommu/hyperv: Add missing PCI dependency for the guest IOMMU driver
>   iommu/hyperv: Make hv_iommu_device static
> 
>  drivers/iommu/hyperv/Kconfig          | 2 +-
>  drivers/iommu/hyperv/hv-iommu-guest.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Jacob Pan <jacob.pan@linux.microsoft.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] iommu/hyperv: Fix guest IOMMU build issues
  2026-10-15  8:23 [PATCH 0/2] iommu/hyperv: Fix guest IOMMU build issues Yu Zhang
                   ` (3 preceding siblings ...)
  2026-10-15 15:29 ` Jacob Pan
@ 2026-10-15 15:52 ` Jörg Rödel
  4 siblings, 0 replies; 6+ messages in thread
From: Jörg Rödel @ 2026-10-15 15:52 UTC (permalink / raw)
  To: Yu Zhang
  Cc: iommu, linux-hyperv, linux-kernel, lkp, oe-kbuild-all,
	joerg.roedel, jgg, will, robin.murphy, mhklinux, wei.liu,
	jacob.pan, easwar.hariharan

On Thu, Oct 15, 2026 at 04:23:49PM +0800, Yu Zhang wrote:
> Yu Zhang (2):
>   iommu/hyperv: Add missing PCI dependency for the guest IOMMU driver
>   iommu/hyperv: Make hv_iommu_device static

Applied, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-10-15 15:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-15  8:23 [PATCH 0/2] iommu/hyperv: Fix guest IOMMU build issues Yu Zhang
2026-10-15  8:23 ` [PATCH 1/2] iommu/hyperv: Add missing PCI dependency for the guest IOMMU driver Yu Zhang
2026-10-15  8:23 ` [PATCH 2/2] iommu/hyperv: Make hv_iommu_device static Yu Zhang
2026-10-15 12:36 ` [PATCH 0/2] iommu/hyperv: Fix guest IOMMU build issues Jason Gunthorpe
2026-10-15 15:29 ` Jacob Pan
2026-10-15 15:52 ` Jörg Rödel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®