From: "Darrick J. Wong" <djwong@kernel.org>
To: Reid D <skibletz@gmail.com>
Cc: Carlos Maiolino <cem@kernel.org>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
sandeen@sandeen.net
Subject: Re: [PATCH] xfs: fix bs_xflags copied from wrong compat field
Date: Thu, 15 Oct 2026 22:08:47 -0700 [thread overview]
Message-ID: <20261016050847.GT2705364@frogsfrogsfrogs> (raw)
In-Reply-To: <CAGNJ+_2p_qyY2xx0b7wgHg+PJWLSQzYmfRqk3UCpue2f6GchVQ@mail.gmail.com>
On Thu, Oct 15, 2026 at 10:11:57PM -0400, Reid D wrote:
> From: Reid Downing (b1nv0id) <skibletz@gmail.com>
> Subject: [PATCH] xfs: fix bs_xflags copied from wrong compat field
>
> Read bs_xflags from the correct compat field in
> xfs_ioctl32_bstat_copyin().
>
> Signed-off-by: Reid Downing (b1nv0id) <skibletz@gmail.com>
Yikes. Good thing we don't actually /use/ bs_xflags in swapext.
Cc: <stable@vger.kernel.org> # v2.6.29
Fixes: e94fc4a43e5c39 ("[XFS] Add compat handlers for swapext ioctl")
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_ioctl32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/fs/xfs/xfs_ioctl32.c
> +++ b/fs/xfs/xfs_ioctl32.c
> @@ -124,7 +124,7 @@
> xfs_ioctl32_bstime_copyin(&bstat->bs_mtime, &bstat32->bs_mtime) ||
> xfs_ioctl32_bstime_copyin(&bstat->bs_ctime, &bstat32->bs_ctime) ||
> get_user(bstat->bs_blocks, &bstat32->bs_size) ||
> - get_user(bstat->bs_xflags, &bstat32->bs_size) ||
> + get_user(bstat->bs_xflags, &bstat32->bs_xflags) ||
> get_user(bstat->bs_extsize, &bstat32->bs_extsize) ||
> get_user(bstat->bs_extents, &bstat32->bs_extents) ||
> get_user(bstat->bs_gen, &bstat32->bs_gen) ||
>
next prev parent reply other threads:[~2026-10-16 5:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 2:11 Reid D
2026-10-16 5:08 ` Darrick J. Wong [this message]
2026-10-16 14:26 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016050847.GT2705364@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=skibletz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®