* [PATCH] xfs: fix bs_xflags copied from wrong compat field
@ 2026-10-16 2:11 Reid D
2026-10-16 5:08 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: Reid D @ 2026-10-16 2:11 UTC (permalink / raw)
To: Carlos Maiolino, linux-xfs, linux-kernel
From: Reid Downing (b1nv0id) <skibletz@gmail.com>
Subject: [PATCH] xfs: fix bs_xflags copied from wrong compat field
Read bs_xflags from the correct compat field in
xfs_ioctl32_bstat_copyin().
Signed-off-by: Reid Downing (b1nv0id) <skibletz@gmail.com>
---
fs/xfs/xfs_ioctl32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/xfs/xfs_ioctl32.c
+++ b/fs/xfs/xfs_ioctl32.c
@@ -124,7 +124,7 @@
xfs_ioctl32_bstime_copyin(&bstat->bs_mtime, &bstat32->bs_mtime) ||
xfs_ioctl32_bstime_copyin(&bstat->bs_ctime, &bstat32->bs_ctime) ||
get_user(bstat->bs_blocks, &bstat32->bs_size) ||
- get_user(bstat->bs_xflags, &bstat32->bs_size) ||
+ get_user(bstat->bs_xflags, &bstat32->bs_xflags) ||
get_user(bstat->bs_extsize, &bstat32->bs_extsize) ||
get_user(bstat->bs_extents, &bstat32->bs_extents) ||
get_user(bstat->bs_gen, &bstat32->bs_gen) ||
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xfs: fix bs_xflags copied from wrong compat field
2026-10-16 2:11 [PATCH] xfs: fix bs_xflags copied from wrong compat field Reid D
@ 2026-10-16 5:08 ` Darrick J. Wong
2026-10-16 14:26 ` Eric Sandeen
0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2026-10-16 5:08 UTC (permalink / raw)
To: Reid D; +Cc: Carlos Maiolino, linux-xfs, linux-kernel, sandeen
On Thu, Oct 15, 2026 at 10:11:57PM -0400, Reid D wrote:
> From: Reid Downing (b1nv0id) <skibletz@gmail.com>
> Subject: [PATCH] xfs: fix bs_xflags copied from wrong compat field
>
> Read bs_xflags from the correct compat field in
> xfs_ioctl32_bstat_copyin().
>
> Signed-off-by: Reid Downing (b1nv0id) <skibletz@gmail.com>
Yikes. Good thing we don't actually /use/ bs_xflags in swapext.
Cc: <stable@vger.kernel.org> # v2.6.29
Fixes: e94fc4a43e5c39 ("[XFS] Add compat handlers for swapext ioctl")
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_ioctl32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/fs/xfs/xfs_ioctl32.c
> +++ b/fs/xfs/xfs_ioctl32.c
> @@ -124,7 +124,7 @@
> xfs_ioctl32_bstime_copyin(&bstat->bs_mtime, &bstat32->bs_mtime) ||
> xfs_ioctl32_bstime_copyin(&bstat->bs_ctime, &bstat32->bs_ctime) ||
> get_user(bstat->bs_blocks, &bstat32->bs_size) ||
> - get_user(bstat->bs_xflags, &bstat32->bs_size) ||
> + get_user(bstat->bs_xflags, &bstat32->bs_xflags) ||
> get_user(bstat->bs_extsize, &bstat32->bs_extsize) ||
> get_user(bstat->bs_extents, &bstat32->bs_extents) ||
> get_user(bstat->bs_gen, &bstat32->bs_gen) ||
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xfs: fix bs_xflags copied from wrong compat field
2026-10-16 5:08 ` Darrick J. Wong
@ 2026-10-16 14:26 ` Eric Sandeen
0 siblings, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2026-10-16 14:26 UTC (permalink / raw)
To: Darrick J. Wong, Reid D; +Cc: Carlos Maiolino, linux-xfs, linux-kernel, sandeen
On 10/16/26 1:08 AM, Darrick J. Wong wrote:
> On Thu, Oct 15, 2026 at 10:11:57PM -0400, Reid D wrote:
>> From: Reid Downing (b1nv0id) <skibletz@gmail.com>
>> Subject: [PATCH] xfs: fix bs_xflags copied from wrong compat field
>>
>> Read bs_xflags from the correct compat field in
>> xfs_ioctl32_bstat_copyin().
>>
>> Signed-off-by: Reid Downing (b1nv0id) <skibletz@gmail.com>
>
> Yikes. Good thing we don't actually /use/ bs_xflags in swapext.
Oh good grief!
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Brown-paper-bag-on: Eric Sandeen <sandeen@redhat.com>
> Cc: <stable@vger.kernel.org> # v2.6.29
> Fixes: e94fc4a43e5c39 ("[XFS] Add compat handlers for swapext ioctl")
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
>
> --D
>
>> ---
>> fs/xfs/xfs_ioctl32.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/fs/xfs/xfs_ioctl32.c
>> +++ b/fs/xfs/xfs_ioctl32.c
>> @@ -124,7 +124,7 @@
>> xfs_ioctl32_bstime_copyin(&bstat->bs_mtime, &bstat32->bs_mtime) ||
>> xfs_ioctl32_bstime_copyin(&bstat->bs_ctime, &bstat32->bs_ctime) ||
>> get_user(bstat->bs_blocks, &bstat32->bs_size) ||
>> - get_user(bstat->bs_xflags, &bstat32->bs_size) ||
>> + get_user(bstat->bs_xflags, &bstat32->bs_xflags) ||
>> get_user(bstat->bs_extsize, &bstat32->bs_extsize) ||
>> get_user(bstat->bs_extents, &bstat32->bs_extents) ||
>> get_user(bstat->bs_gen, &bstat32->bs_gen) ||
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-16 14:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-16 2:11 [PATCH] xfs: fix bs_xflags copied from wrong compat field Reid D
2026-10-16 5:08 ` Darrick J. Wong
2026-10-16 14:26 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®