* [PATCH] accel: ethosu: Fix kernel-doc for ethosu_gem_cmdstream_create()
@ 2026-10-16 10:15 Aryan Sinha
2026-10-16 13:27 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Aryan Sinha @ 2026-10-16 10:15 UTC (permalink / raw)
To: Rob Herring, Tomeu Vizoso
Cc: Oded Gabbay, dri-devel, linux-kernel, Aryan Sinha
The comment documents an exclusive_vm argument the function never had, and
leaves out data. Swap the two so the list matches the signature.
Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com>
---
drivers/accel/ethosu/ethosu_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/ethosu/ethosu_gem.c b/drivers/accel/ethosu/ethosu_gem.c
index 9afe2549e..2b89f70f4 100644
--- a/drivers/accel/ethosu/ethosu_gem.c
+++ b/drivers/accel/ethosu/ethosu_gem.c
@@ -712,8 +712,8 @@ static int ethosu_gem_cmdstream_copy_and_validate(struct drm_device *ddev,
* ethosu_gem_cmdstream_create() - Create a GEM object and attach it to a handle.
* @file: DRM file.
* @ddev: DRM device.
- * @exclusive_vm: Exclusive VM. Not NULL if the GEM object can't be shared.
* @size: Size of the GEM object to allocate.
+ * @data: User pointer to the command stream contents.
* @flags: Combination of drm_ethosu_bo_flags flags.
* @handle: Pointer holding the handle pointing to the new GEM object.
*
--
2.46.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] accel: ethosu: Fix kernel-doc for ethosu_gem_cmdstream_create()
2026-10-16 10:15 [PATCH] accel: ethosu: Fix kernel-doc for ethosu_gem_cmdstream_create() Aryan Sinha
@ 2026-10-16 13:27 ` Rob Herring
2026-10-16 13:49 ` Aryan Sinha
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2026-10-16 13:27 UTC (permalink / raw)
To: Aryan Sinha; +Cc: Tomeu Vizoso, Oded Gabbay, dri-devel, linux-kernel
On Fri, Oct 16, 2026 at 03:45:49PM +0530, Aryan Sinha wrote:
> The comment documents an exclusive_vm argument the function never had, and
> leaves out data. Swap the two so the list matches the signature.
>
> Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com>
> ---
> drivers/accel/ethosu/ethosu_gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Why are you sending this again after 4 days?
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] accel: ethosu: Fix kernel-doc for ethosu_gem_cmdstream_create()
2026-10-16 13:27 ` Rob Herring
@ 2026-10-16 13:49 ` Aryan Sinha
0 siblings, 0 replies; 4+ messages in thread
From: Aryan Sinha @ 2026-10-16 13:49 UTC (permalink / raw)
To: Rob Herring; +Cc: Tomeu Vizoso, Oded Gabbay, dri-devel, linux-kernel
On Fri, Oct 16, 2026 at 08:27:26AM -0500, Rob Herring wrote:
> Why are you sending this again after 4 days?
My mistake sorry, this is an accidental resend. It is the same patch as the
12 Oct posting with nothing changed:
https://lore.kernel.org/all/20261012152118.33548-1-sinha.aryan03@gmail.com/
Please ignore this copy and use the original. Sorry for the duplication.
Aryan
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] accel: ethosu: Fix kernel-doc for ethosu_gem_cmdstream_create()
@ 2026-10-12 15:21 Aryan Sinha
0 siblings, 0 replies; 4+ messages in thread
From: Aryan Sinha @ 2026-10-12 15:21 UTC (permalink / raw)
To: Rob Herring, Tomeu Vizoso
Cc: Oded Gabbay, dri-devel, linux-kernel, Aryan Sinha
The comment documents an exclusive_vm argument the function never had, and
leaves out data. Swap the two so the list matches the signature.
Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com>
---
drivers/accel/ethosu/ethosu_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/ethosu/ethosu_gem.c b/drivers/accel/ethosu/ethosu_gem.c
index 9afe2549e..2b89f70f4 100644
--- a/drivers/accel/ethosu/ethosu_gem.c
+++ b/drivers/accel/ethosu/ethosu_gem.c
@@ -712,8 +712,8 @@ static int ethosu_gem_cmdstream_copy_and_validate(struct drm_device *ddev,
* ethosu_gem_cmdstream_create() - Create a GEM object and attach it to a handle.
* @file: DRM file.
* @ddev: DRM device.
- * @exclusive_vm: Exclusive VM. Not NULL if the GEM object can't be shared.
* @size: Size of the GEM object to allocate.
+ * @data: User pointer to the command stream contents.
* @flags: Combination of drm_ethosu_bo_flags flags.
* @handle: Pointer holding the handle pointing to the new GEM object.
*
--
2.46.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-10-16 13:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-16 10:15 [PATCH] accel: ethosu: Fix kernel-doc for ethosu_gem_cmdstream_create() Aryan Sinha
2026-10-16 13:27 ` Rob Herring
2026-10-16 13:49 ` Aryan Sinha
-- strict thread matches above, loose matches on Subject: below --
2026-10-12 15:21 Aryan Sinha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®