mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergey Lebedev <lsa.uz@pm.me>
To: Hao Yao <hao.yao@intel.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Dan Scally" <dan.scally@ideasonboard.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Bingbu Cao" <bingbu.cao@intel.com>,
	platform-driver-x86@vger.kernel.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: int3472: Use actual clock frequency for DSM method
Date: Fri, 16 Oct 2026 11:28:02 +0000	[thread overview]
Message-ID: <20261016112744.39905-1-lsa.uz@pm.me> (raw)

Hi Hao,

This fixes a camera on the Surface Pro 11 with Intel (Lunar Lake), for
your v2:
https://lore.kernel.org/all/20251208035122.2147678-1-hao.yao@intel.com/

Its infrared sensor, an ST VD55G0 (SMO55F0), has 24 MHz in its SSDB,
and INT3472 turns its clock on through the _DSM with 1, 19.2 MHz. The
sensor driver sets the sensor up for 24 MHz, so everything the sensor
derives runs at four fifths: it streamed at 47.31 fps where its
configuration gives 59.14, which also puts its MIPI output at 633.6
Mbps, below the sensor's minimum of 750. With your v2 on media next and
my vd55g0 driver, the sensor runs at 59.14 fps in every mode, as computed.
A value of 0 did not change the clock here either, as you saw on the
oscilloscope.

Tested-by: Sergey Lebedev <lsa.uz@pm.me> # Surface Pro 11 (Intel), VD55G0

Would you send a v3 with the Fixes tag and the note on 0 and 2 that Ilpo
asked for? I will repeat the Tested-by on it. If you are busy, I can
resend it with your authorship.

Sergey


             reply	other threads:[~2026-10-16 11:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 11:28 Sergey Lebedev [this message]
2026-10-16 14:22 ` Hans de Goede
2026-10-16 14:29   ` Sergey Lebedev
  -- strict thread matches above, loose matches on Subject: below --
2025-12-08  3:51 Hao Yao
2025-12-08  7:48 ` Dan Scally
2025-12-08  9:31 ` johannes.goede
2025-12-08 11:27 ` Sakari Ailus
2025-12-29 12:06 ` Ilpo Järvinen
2026-04-02  6:56   ` Hao Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261016112744.39905-1-lsa.uz@pm.me \
    --to=lsa.uz@pm.me \
    --cc=bingbu.cao@intel.com \
    --cc=dan.scally@ideasonboard.com \
    --cc=hansg@kernel.org \
    --cc=hao.yao@intel.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®