Re: [PATCH v2] platform/x86: int3472: Use actual clock frequency for DSM method

[Hans de Goede <hansg@kernel.org>]

Hi,

On 16-Oct-26 13:28, Sergey Lebedev wrote:
> Hi Hao,
> 
> This fixes a camera on the Surface Pro 11 with Intel (Lunar Lake), for
> your v2:
> https://lore.kernel.org/all/20251208035122.2147678-1-hao.yao@intel.com/
> 
> Its infrared sensor, an ST VD55G0 (SMO55F0), has 24 MHz in its SSDB,
> and INT3472 turns its clock on through the _DSM with 1, 19.2 MHz. The
> sensor driver sets the sensor up for 24 MHz, so everything the sensor
> derives runs at four fifths: it streamed at 47.31 fps where its
> configuration gives 59.14, which also puts its MIPI output at 633.6
> Mbps, below the sensor's minimum of 750. With your v2 on media next and
> my vd55g0 driver, the sensor runs at 59.14 fps in every mode, as computed.
> A value of 0 did not change the clock here either, as you saw on the
> oscilloscope.
> 
> Tested-by: Sergey Lebedev <lsa.uz@pm.me> # Surface Pro 11 (Intel), VD55G0
> 
> Would you send a v3 with the Fixes tag and the note on 0 and 2 that Ilpo
> asked for? I will repeat the Tested-by on it. If you are busy, I can
> resend it with your authorship.

Note that from now on int3472 patches are routed through the media-committers
tree since these are related to camera support:

https://gitlab.freedesktop.org/linux-media/media-committers/-/commits/next/drivers/platform/x86/intel/int3472?ref_type=heads

If you send a new version please base it on top of media-committers/next .

Regards,

Hans