mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Kees Cook <kees@kernel.org>
Cc: Bill Wendling <morbo@google.com>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	David Gow <david@davidgow.net>, Petr Mladek <pmladek@suse.com>,
	Shuvam Pandey <shuvampandey1@gmail.com>,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v5 04/12] seq_buf: Copy what fits when seq_buf_puts() and seq_buf_putmem() overflow
Date: Fri, 16 Oct 2026 14:29:29 -0400	[thread overview]
Message-ID: <20261016142929.6a3a4647@gandalf.local.home> (raw)
In-Reply-To: <20261005155708.1471260-4-kees@kernel.org>

On Mon,  5 Oct 2026 08:56:54 -0700
Kees Cook <kees@kernel.org> wrote:

> When seq_buf_puts() or seq_buf_putmem() is given more than fits, it
> copies nothing and only marks the seq_buf as overflowed. If seq_buf_str()
> is used, it will terminate the buffer in its last byte, so every byte
> between the end of the data and the end of the buffer becomes part of
> the string, though the seq_buf never wrote them.
> 
> seq_buf_printf() does not have this problem, because vsnprintf() writes
> as much of the output as fits, followed by a NUL. Repeat this behavior
> in seq_buf_puts(), using strscpy(), and in seq_buf_putmem(), which also
> covers seq_buf_putmem_hex(). seq_buf_putc() needs no change, as it can
> only overflow when the buffer is already full.
> 
> Each writer now records the buffer as full once it has copied what fits,
> so that what it wrote can be told apart from bytes nothing touched.
> 
> Of the callers that check the return value or test for overflow
> afterward, only lpfc_rx_monitor_report() relied on a string that did not
> fit being left out, and the previous patch has it drop such a record
> itself. The others treat overflow as an error or report it. The callers
> that ignore overflow use whatever the buffer holds, which now ends with
> the part of the string that fit.
> 
> Update seq_buf_putmem_hex_overflow_test, which expected a hex group that
> did not fit whole to be left out entirely, and add tests that overflow
> seq_buf_puts(), seq_buf_putmem() and seq_buf_putmem_hex() with stale
> bytes in the buffer.
> 
> The three partial-overflow tests check the buffer itself rather than
> seq_buf_str(). Neither writer leaves the last byte of the buffer alone:
> seq_buf_putmem() copies raw bytes and writes no NUL, and seq_buf_puts()
> relies on strscpy() to write one. That byte is exactly where
> seq_buf_str() writes its terminator, so asserting only on the string
> would pass whether the copy stopped a byte early or dropped the NUL
> entirely.
> 
> seq_buf_putmem() was not exported, so the test failed to link as a
> module. Export it.
> 
> Tests passed under qemu on ARCH=x86_64 with GCC 16.2.0 and CONFIG_KASAN=y,
> and on big-endian ARCH=s390 with GCC s390x-linux-gnu 16.2.0, and the
> test builds as a module (CONFIG_SEQ_BUF_KUNIT_TEST=m).
> 
> Assisted-by: LLM
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Kees Cook <kees@kernel.org>
> ---

Reviewed-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

  reply	other threads:[~2026-10-16 18:29 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 15:56 [PATCH v5 00/12] seq_buf: Add seq_buf_strlen() Kees Cook
2026-10-05 15:56 ` [PATCH v5 01/12] seq_buf: Do not print an empty line from an overflowed seq_buf_do_printk() Kees Cook
2026-10-16 18:28   ` Steven Rostedt
2026-10-05 15:56 ` [PATCH v5 02/12] seq_buf: Do not pop from an overflowed seq_buf Kees Cook
2026-10-16 18:28   ` Steven Rostedt
2026-10-05 15:56 ` [PATCH v5 03/12] scsi: lpfc: Print rx monitor records straight into the seq_buf Kees Cook
2026-10-05 18:54   ` David Laight
2026-10-06 13:26     ` Kees Cook
2026-10-05 15:56 ` [PATCH v5 04/12] seq_buf: Copy what fits when seq_buf_puts() and seq_buf_putmem() overflow Kees Cook
2026-10-16 18:29   ` Steven Rostedt [this message]
2026-10-05 15:56 ` [PATCH v5 05/12] seq_buf: Clear what a writer did not claim when a seq_buf overflows Kees Cook
2026-10-05 18:59   ` David Laight
2026-10-06 21:26     ` Kees Cook
2026-10-16 18:43       ` Steven Rostedt
2026-10-16 18:35   ` Steven Rostedt
2026-10-05 15:56 ` [PATCH v5 06/12] seq_buf: Add seq_buf_strlen() Kees Cook
2026-10-16 18:59   ` Steven Rostedt
2026-10-22 18:06     ` Kees Cook
2026-10-22 19:41       ` Alejandro Colomar
2026-10-22 19:57         ` Steven Rostedt
2026-10-22 20:05           ` Steven Rostedt
2026-10-22 20:11           ` Alejandro Colomar
2026-10-22 20:20             ` Steven Rostedt
2026-10-22 20:38               ` Alejandro Colomar
2026-10-22 20:44                 ` Alejandro Colomar
2026-10-22 20:53                 ` Steven Rostedt
2026-10-22 21:02                   ` Alejandro Colomar
2026-10-23  0:37                     ` Steven Rostedt
2026-10-23  9:36                       ` Alejandro Colomar
2026-10-23 11:38                 ` Alejandro Colomar
2026-10-05 15:56 ` [PATCH v5 07/12] seq_buf: Add seq_buf_terminate() Kees Cook
2026-10-05 15:56 ` [PATCH v5 08/12] bpf: Remove dead newline stripping from format_disasm_line() Kees Cook
2026-10-05 15:56 ` [PATCH v5 09/12] seq_buf: Add seq_buf_init_append() Kees Cook
2026-10-16 19:09   ` Steven Rostedt
2026-10-05 15:57 ` [PATCH v5 10/12] powerpc/papr_scm: Return the string length from the sysfs show functions Kees Cook
2026-10-05 15:57 ` [PATCH v5 11/12] nvdimm: ndtest: Return the string length from flags_show() Kees Cook
2026-10-05 15:57 ` [PATCH v5 12/12] docs: core-api: Document the seq_buf API Kees Cook
2026-10-16 19:13   ` Steven Rostedt
2026-10-12  5:00 ` [PATCH v5 00/12] seq_buf: Add seq_buf_strlen() Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261016142929.6a3a4647@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=david@davidgow.net \
    --cc=kees@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=morbo@google.com \
    --cc=pmladek@suse.com \
    --cc=shuvampandey1@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®