From: Steven Rostedt <rostedt@goodmis.org>
To: Alejandro Colomar <alx+linux-hardening@kernel.org>
Cc: Kees Cook <kees@kernel.org>, Bill Wendling <morbo@google.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
David Gow <david@davidgow.net>, Petr Mladek <pmladek@suse.com>,
Shuvam Pandey <shuvampandey1@gmail.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v5 06/12] seq_buf: Add seq_buf_strlen()
Date: Thu, 22 Oct 2026 16:20:00 -0400 [thread overview]
Message-ID: <20261022162000.18aa4162@gandalf.local.home> (raw)
In-Reply-To: <atptYsHyS6YGtzPV@debian>
On Thu, 22 Oct 2026 22:11:27 +0200
Alejandro Colomar <alx+linux-hardening@kernel.org> wrote:
> Agree.
>
> But still, a better design would do:
>
> static inline void
> seq_buf_set_overflow(struct seq_buf *s)
> {
> s->p = NULL;
> }
>
> This is way more robust, and also easier to understand. My head is
> boiling when trying to review this patch set for correctness. That's
> not a good sign.
But that loses all data. We still want access to what was written.
-- Steve
next prev parent reply other threads:[~2026-10-22 20:20 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 15:56 [PATCH v5 00/12] " Kees Cook
2026-10-05 15:56 ` [PATCH v5 01/12] seq_buf: Do not print an empty line from an overflowed seq_buf_do_printk() Kees Cook
2026-10-16 18:28 ` Steven Rostedt
2026-10-05 15:56 ` [PATCH v5 02/12] seq_buf: Do not pop from an overflowed seq_buf Kees Cook
2026-10-16 18:28 ` Steven Rostedt
2026-10-05 15:56 ` [PATCH v5 03/12] scsi: lpfc: Print rx monitor records straight into the seq_buf Kees Cook
2026-10-05 18:54 ` David Laight
2026-10-06 13:26 ` Kees Cook
2026-10-05 15:56 ` [PATCH v5 04/12] seq_buf: Copy what fits when seq_buf_puts() and seq_buf_putmem() overflow Kees Cook
2026-10-16 18:29 ` Steven Rostedt
2026-10-05 15:56 ` [PATCH v5 05/12] seq_buf: Clear what a writer did not claim when a seq_buf overflows Kees Cook
2026-10-05 18:59 ` David Laight
2026-10-06 21:26 ` Kees Cook
2026-10-16 18:43 ` Steven Rostedt
2026-10-16 18:35 ` Steven Rostedt
2026-10-05 15:56 ` [PATCH v5 06/12] seq_buf: Add seq_buf_strlen() Kees Cook
2026-10-16 18:59 ` Steven Rostedt
2026-10-22 18:06 ` Kees Cook
2026-10-22 19:41 ` Alejandro Colomar
2026-10-22 19:57 ` Steven Rostedt
2026-10-22 20:05 ` Steven Rostedt
2026-10-22 20:11 ` Alejandro Colomar
2026-10-22 20:20 ` Steven Rostedt [this message]
2026-10-22 20:38 ` Alejandro Colomar
2026-10-22 20:44 ` Alejandro Colomar
2026-10-22 20:53 ` Steven Rostedt
2026-10-22 21:02 ` Alejandro Colomar
2026-10-05 15:56 ` [PATCH v5 07/12] seq_buf: Add seq_buf_terminate() Kees Cook
2026-10-05 15:56 ` [PATCH v5 08/12] bpf: Remove dead newline stripping from format_disasm_line() Kees Cook
2026-10-05 15:56 ` [PATCH v5 09/12] seq_buf: Add seq_buf_init_append() Kees Cook
2026-10-16 19:09 ` Steven Rostedt
2026-10-05 15:57 ` [PATCH v5 10/12] powerpc/papr_scm: Return the string length from the sysfs show functions Kees Cook
2026-10-05 15:57 ` [PATCH v5 11/12] nvdimm: ndtest: Return the string length from flags_show() Kees Cook
2026-10-05 15:57 ` [PATCH v5 12/12] docs: core-api: Document the seq_buf API Kees Cook
2026-10-16 19:13 ` Steven Rostedt
2026-10-12 5:00 ` [PATCH v5 00/12] seq_buf: Add seq_buf_strlen() Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261022162000.18aa4162@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=alx+linux-hardening@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=david@davidgow.net \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morbo@google.com \
--cc=pmladek@suse.com \
--cc=shuvampandey1@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®