From: Tamaki Yanagawa <ty@000ty.net>
To: fw@strlen.de
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org,
phil@nwl.cc, coreteam@netfilter.org,
linux-kernel@vger.kernel.org, ty@000ty.net
Subject: Re: [PATCH nf] netfilter: ipset: restore element before rescanning cidrs on seqcount retry
Date: Sun, 18 Oct 2026 05:23:10 +0000 [thread overview]
Message-ID: <20261018052302.29330-1-ty@000ty.net> (raw)
In-Reply-To: <atRROQfgdeGSIU5s@strlen.de>
Florian Westphal <fw@strlen.de> wrote:
> Is this a real world encountered bug or an LLM finding?
An LLM finding (Claude, hence the Assisted-by tag), I haven't hit it in
production. I did confirm it on a KVM guest though: a hash:net set with
10.0.0.0/29 and 11.0.0.0/8, an "iptables -m set --match-set s dst" rule,
a loop adding and deleting 172.16.0.0/12, and UDP traffic to 10.200.3.4.
70 out of ~9.5M packets matched the rule in 60 seconds without the fix,
none with it.
> Why do we need to do this instead of not masking @d in place to begin
> with?
No good reason, your version is cleaner. I'll send a v2 that works on a
local copy and constifies the reset_elem helpers.
Thanks,
Tamaki
next prev parent reply other threads:[~2026-10-18 5:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 3:52 Tamaki Yanagawa
2026-10-18 4:55 ` Florian Westphal
2026-10-18 5:23 ` Tamaki Yanagawa [this message]
2026-10-18 11:44 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261018052302.29330-1-ty@000ty.net \
--to=ty@000ty.net \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®